From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751258AbdAWPOn (ORCPT ); Mon, 23 Jan 2017 10:14:43 -0500 Received: from mail-it0-f47.google.com ([209.85.214.47]:34854 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbdAWPOl (ORCPT ); Mon, 23 Jan 2017 10:14:41 -0500 Subject: Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment To: Johannes Thumshirn , SF Markus Elfring References: <7d68f93d-c14c-60aa-2b02-5005a0a62cad@users.sourceforge.net> <20170123091821.GC3517@linux-x5ow.site> Cc: linux-block@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org From: Jens Axboe Message-ID: Date: Mon, 23 Jan 2017 08:14:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170123091821.GC3517@linux-x5ow.site> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/23/2017 02:20 AM, Johannes Thumshirn wrote: > On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Sat, 21 Jan 2017 22:15:33 +0100 >> >> The script "checkpatch.pl" pointed information out like the following. >> >> ERROR: do not use assignment in if condition >> >> Thus fix the affected source code places. >> >> Signed-off-by: Markus Elfring >> --- > > Reviewed-by: Johannes Thumshirn > if Jens wants doesn't mind. I don't mind these, but I completely agree on the patches for moving the 'error' assignment. What ends up happening for those cases is that someone adds a new section and forgets to set 'error', and then all hell breaks lose. So Markus, don't bother sending those patches again for the block layer or drivers, I'm not going to take them. -- Jens Axboe