From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Tal Zussman" <tz2294@columbia.edu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Mike Rapoport" <rppt@kernel.org>, "Peter Xu" <peterx@redhat.com>,
"James Houghton" <jthoughton@google.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Balbir Singh" <balbirs@nvidia.com>,
"Liam R. Howlett" <liam@infradead.org>,
"Lorenzo Stoakes" <ljs@kernel.org>,
"Vlastimil Babka" <vbabka@kernel.org>,
"Jann Horn" <jannh@google.com>,
"Pedro Falcato" <pfalcato@suse.de>,
"Michal Hocko" <mhocko@suse.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Andrei Vagin" <avagin@gmail.com>,
"Muhammad Usama Anjum" <usama.anjum@arm.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Arnd Bergmann" <arnd@arndb.de>, "Zi Yan" <ziy@nvidia.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Joshua Hahn" <joshua.hahnjy@gmail.com>,
"Byungchul Park" <byungchul@sk.com>,
"Gregory Price" <gourry@gourry.net>,
"Ying Huang" <ying.huang@linux.alibaba.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Nico Pache" <nico.pache@linux.dev>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Dev Jain" <dev.jain@arm.com>, "Barry Song" <baohua@kernel.org>,
"Lance Yang" <lance.yang@linux.dev>,
"Usama Arif" <usama.arif@linux.dev>,
"Kiryl Shutsemau" <kas@kernel.org>,
"Muchun Song" <muchun.song@linux.dev>,
"Oscar Salvador" <osalvador@suse.de>,
"Mikołaj Lenczewski" <miko.lenczewski@arm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org,
"Breno Leitao" <leitao@debian.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Lyude Paul" <lyude@redhat.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Felix Kuehling" <Felix.Kuehling@amd.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
nouveau@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 0/9] userfaultfd: assorted fixes (part 1)
Date: Wed, 18 Nov 2026 16:37:01 +0100 [thread overview]
Message-ID: <bdd849e3-0a0f-4655-9c76-7e40d1e4eb66@kernel.org> (raw)
In-Reply-To: <7d31ba34-8b5f-4eb2-9864-145ea80c3412@columbia.edu>
On 11/18/26 16:26, Tal Zussman wrote:
> On 11/18/26 4:41 AM, David Hildenbrand (Arm) wrote:
>> On 11/18/26 05:28, Tal Zussman wrote:
> ...
>
>>> Patch 6 has little user impact on its own. It is included because,
>>> together with patch 7, it allows removing clear_uffd_wp_pmd().
>>>
>
> ...>
>> So, I would be picking up ...
>>
>>> Tal Zussman (9):
>>> userfaultfd: use anonymous memory for UFFDIO_ZEROPAGE on private file mappings
>>> userfaultfd: refuse UFFDIO_MOVE into a non-present huge destination PMD
>>> fs/proc/task_mmu: downgrade writable migration entries in PAGEMAP_SCAN write-protect
>>> mm/migrate: warn on a writable migration entry with the uffd bit set
>>
>> This
>>
>>> fs/proc/task_mmu: write-protect device-private THPs in PAGEMAP_SCAN
>>> mm/huge_memory: build the moved huge zero PMD from the destination VMA
>>
>> This
>>
>
> So my one concern is that (as per above), the mremap patch removes
> clear_uffd_wp_pmd() after the huge_memory patch removes the other user.
> Splitting them may break compilation. I would've left clear_uffd_wp_pmd()
> alone but then it throws a nice ugly unused code warning :\
Ah, so it's best Andrew picks that up as well then?
--
Cheers,
David
next prev parent reply other threads:[~2026-11-18 15:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 4:28 Tal Zussman
2026-11-18 4:28 ` [PATCH v3 1/9] userfaultfd: use anonymous memory for UFFDIO_ZEROPAGE on private file mappings Tal Zussman
2026-11-18 14:31 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 2/9] userfaultfd: refuse UFFDIO_MOVE into a non-present huge destination PMD Tal Zussman
2026-11-18 14:33 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 3/9] fs/proc/task_mmu: downgrade writable migration entries in PAGEMAP_SCAN write-protect Tal Zussman
2026-11-18 14:36 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 4/9] mm/migrate: warn on a writable migration entry with the uffd bit set Tal Zussman
2026-11-18 9:39 ` David Hildenbrand (Arm)
2026-11-18 14:37 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 5/9] fs/proc/task_mmu: write-protect device-private THPs in PAGEMAP_SCAN Tal Zussman
2026-11-18 14:38 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 6/9] mm/huge_memory: build the moved huge zero PMD from the destination VMA Tal Zussman
2026-11-18 14:41 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 7/9] mm/mremap: resolve uffd state when the context is dropped, not during the move Tal Zussman
2026-11-18 14:45 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 8/9] mm/migrate_device: do not migrate a uffd-protected zero page Tal Zussman
2026-11-18 9:40 ` David Hildenbrand (Arm)
2026-11-18 14:52 ` Mike Rapoport
2026-11-18 4:28 ` [PATCH v3 9/9] mm/userfaultfd: check the hugetlb alignment of every VMA in the pre-scan Tal Zussman
2026-11-18 9:38 ` David Hildenbrand (Arm)
2026-11-18 14:55 ` Mike Rapoport
2026-11-18 9:41 ` [PATCH v3 0/9] userfaultfd: assorted fixes (part 1) David Hildenbrand (Arm)
2026-11-18 15:26 ` Tal Zussman
2026-11-18 15:37 ` David Hildenbrand (Arm) [this message]
2026-11-18 15:19 ` (subset) " David Hildenbrand
2026-11-18 15:20 ` David Hildenbrand
2026-11-18 15:37 ` David Hildenbrand (Arm)
2026-11-18 15:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd849e3-0a0f-4655-9c76-7e40d1e4eb66@kernel.org \
--to=david@kernel.org \
--cc=Felix.Kuehling@amd.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=arnd@arndb.de \
--cc=avagin@gmail.com \
--cc=balbirs@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=byungchul@sk.com \
--cc=dakr@kernel.org \
--cc=dev.jain@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gourry@gourry.net \
--cc=intel-xe@lists.freedesktop.org \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=joshua.hahnjy@gmail.com \
--cc=jthoughton@google.com \
--cc=kas@kernel.org \
--cc=lance.yang@linux.dev \
--cc=leitao@debian.org \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=lyude@redhat.com \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=miko.lenczewski@arm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=muchun.song@linux.dev \
--cc=nico.pache@linux.dev \
--cc=nouveau@lists.freedesktop.org \
--cc=osalvador@suse.de \
--cc=peterx@redhat.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tz2294@columbia.edu \
--cc=usama.anjum@arm.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®