From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbdFLWnH (ORCPT ); Mon, 12 Jun 2017 18:43:07 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:61292 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752619AbdFLWnF (ORCPT ); Mon, 12 Jun 2017 18:43:05 -0400 Subject: Re: [PATCH 3/4] mfd: tps65217: remove duplicated interrupt resources. To: Enric Balletbo i Serra , , , , , Rob Herring CC: Tony Lindgren , Rob Herring , Mark Rutland , Russell King , Lee Jones , Sebastian Reichel , References: <20170612212412.22719-1-enric.balletbo@collabora.com> <20170612212412.22719-3-enric.balletbo@collabora.com> From: Grygorii Strashko Message-ID: Date: Mon, 12 Jun 2017 17:41:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170612212412.22719-3-enric.balletbo@collabora.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.59.147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/12/2017 04:24 PM, Enric Balletbo i Serra wrote: > I don't think it makes sense to have the interrupt resources for charger > and power button in two different places, the driver and the DT binding. > That's confusing so remove the ones from the mfd driver in favour of > having the interrupt resources only described in the DT. Having the > resources in DT may help if there is or will be a similar pmic with > different resource allocation. Wouldn't this break DT compatibility? Old DTs do not contain IRQ resources and so they work only because of IRQ definitions in code. > > Signed-off-by: Enric Balletbo i Serra > --- > drivers/mfd/tps65217.c | 22 +--------------------- > 1 file changed, 1 insertion(+), 21 deletions(-) > > diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c > index f769c7d..fd83bae 100644 > --- a/drivers/mfd/tps65217.c > +++ b/drivers/mfd/tps65217.c > @@ -33,15 +33,6 @@ > #include > #include > > -static struct resource charger_resources[] = { > - DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_AC, "AC"), > - DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_USB, "USB"), > -}; > - > -static struct resource pb_resources[] = { > - DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_PB, "PB"), > -}; > - > static void tps65217_irq_lock(struct irq_data *data) > { > struct tps65217 *tps = irq_data_get_irq_chip_data(data); > @@ -97,14 +88,10 @@ static struct mfd_cell tps65217s[] = { > }, > { > .name = "tps65217-charger", > - .num_resources = ARRAY_SIZE(charger_resources), > - .resources = charger_resources, > .of_compatible = "ti,tps65217-charger", > }, > { > .name = "tps65217-pwrbutton", > - .num_resources = ARRAY_SIZE(pb_resources), > - .resources = pb_resources, > .of_compatible = "ti,tps65217-pwrbutton", > }, > }; > @@ -359,15 +346,8 @@ static int tps65217_probe(struct i2c_client *client, > return ret; > } > > - if (client->irq) { > + if (client->irq) > tps65217_irq_init(tps, client->irq); > - } else { > - int i; > - > - /* Don't tell children about IRQ resources which won't fire */ > - for (i = 0; i < ARRAY_SIZE(tps65217s); i++) > - tps65217s[i].num_resources = 0; > - } > > ret = devm_mfd_add_devices(tps->dev, -1, tps65217s, > ARRAY_SIZE(tps65217s), NULL, 0, > -- regards, -grygorii