From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01C9BC433DB for ; Tue, 9 Mar 2021 12:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95EAC64F67 for ; Tue, 9 Mar 2021 12:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230492AbhCIMYN (ORCPT ); Tue, 9 Mar 2021 07:24:13 -0500 Received: from smtpweb147.aruba.it ([62.149.158.147]:39973 "EHLO smtpweb147.aruba.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230047AbhCIMYK (ORCPT ); Tue, 9 Mar 2021 07:24:10 -0500 Received: from [192.168.1.56] ([79.0.204.227]) by Aruba Outgoing Smtp with ESMTPSA id JbP3l6rNA1jmzJbP3l3J2r; Tue, 09 Mar 2021 13:23:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aruba.it; s=a1; t=1615292638; bh=TXSSX9JzU1wv9wE+kK9LATPw89208zj66bzBcd5DdXE=; h=Subject:To:From:Date:MIME-Version:Content-Type; b=ijPGQdVn6JaUnCvKIb9/Dhj3aQ4RY2QGRx4Scgm5FBuJ6JDgOY0iz6Ml6LoGk3XM9 tT7TW/QtCRmuZ1dXSriyj7o+dlUk2JEHOH+LsPNRm+tF7lrboCaTRZ5qqHJRo5tjhP M+ZlNQLkoWf40LvTyXf+TbdHXyCTGX+Wrs7tGjEzW8aUOwAdtBdwbuctVI021EMjBZ I+Z6ehAhKVEeOpiTUJBM3a4DzKBxTXwkOEOQL1v/qqiw+KDgCE/TvgjNLX7SSDGIBe dIOcH293w8TeJSW/aOfXjF+S8I7PUC2ZBS1IjjEBt4bvedz7uD45fAOX9xkisglNyi U2YF54GrmKpRw== Subject: Re: [PATCH resend v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Ryan Govostes , Greg Kroah-Hartman References: <20210309112403.36633-1-andriy.shevchenko@linux.intel.com> From: Rodolfo Giometti Message-ID: Date: Tue, 9 Mar 2021 13:23:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210309112403.36633-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfC2ATPhzH6vD5AHua1a34RNf/imkge3Hx6JG6nSVAr/PX/CWsZvoubswbog7tv+aND5bLwP+I/c1jEDl4BV8uIK0zd/IttaRnFbJaQcnjQ1z4vpgmgOe Wz02v0Ahckmo1vZ3Ku0/cyqCXlWvX2Ig4cE7KDbZfQ7xdIlfJDIiZKibLlpZVaOX8I08690YbVMx4O7w3IVpS1YLcD7MGGocE04vtLioOtjkBXoPy9y0itgp qGVHs4tFaCJxni8cWo2gD+3bG8HSGaLivB34eW8OevkKnReuf5UbiUwJokP3xakG Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/03/21 12:23, Andy Shevchenko wrote: > When requesting optional GPIO echo line, bail out on error, > so user will know that something wrong with the existing property. > > Signed-off-by: Andy Shevchenko > --- > drivers/pps/clients/pps-gpio.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c > index e0de1df2ede0..f89c31aa66f1 100644 > --- a/drivers/pps/clients/pps-gpio.c > +++ b/drivers/pps/clients/pps-gpio.c > @@ -119,12 +119,12 @@ static int pps_gpio_setup(struct platform_device *pdev) > data->echo_pin = devm_gpiod_get_optional(&pdev->dev, > "echo", > GPIOD_OUT_LOW); > - if (data->echo_pin) { > - if (IS_ERR(data->echo_pin)) { > - dev_err(&pdev->dev, "failed to request ECHO GPIO\n"); > - return PTR_ERR(data->echo_pin); > - } > + if (IS_ERR(data->echo_pin)) { > + dev_err(&pdev->dev, "failed to request ECHO GPIO\n"); > + return PTR_ERR(data->echo_pin); > + } > > + if (data->echo_pin) { > ret = of_property_read_u32(np, > "echo-active-ms", > &value); > Acked-by: Rodolfo Giometti -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti