From: Ilya Maximets <i.maximets@ovn.org>
To: Paolo Abeni <pabeni@redhat.com>,
Adrian Moreno <amorenoz@redhat.com>,
netdev@vger.kernel.org
Cc: i.maximets@ovn.org, aconole@redhat.com, echaudro@redhat.com,
horms@kernel.org, dev@openvswitch.org,
Yotam Gigi <yotam.gi@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 04/10] net: psample: allow using rate as probability
Date: Tue, 25 Jun 2024 13:28:50 +0200 [thread overview]
Message-ID: <bde22f96-d91c-4cfc-b669-3b0b0b23c77e@ovn.org> (raw)
In-Reply-To: <7f6aa18e38ff3c161805b19780c6265d05b4a235.camel@redhat.com>
On 6/25/24 13:17, Paolo Abeni wrote:
> On Fri, 2024-06-21 at 12:10 +0200, Adrian Moreno wrote:
>> diff --git a/include/uapi/linux/tc_act/tc_sample.h b/include/uapi/linux/tc_act/tc_sample.h
>> index fee1bcc20793..7ee0735e7b38 100644
>> --- a/include/uapi/linux/tc_act/tc_sample.h
>> +++ b/include/uapi/linux/tc_act/tc_sample.h
>> @@ -18,6 +18,7 @@ enum {
>> TCA_SAMPLE_TRUNC_SIZE,
>> TCA_SAMPLE_PSAMPLE_GROUP,
>> TCA_SAMPLE_PAD,
>> + TCA_SAMPLE_PROBABILITY,
>> __TCA_SAMPLE_MAX
>> };
>> #define TCA_SAMPLE_MAX (__TCA_SAMPLE_MAX - 1)
>
> I believe Ilya's comment on v3 is correct, this chunk looks unrelated
> and unneeded. I guess you can drop it? Or am I missing something?
Oops, somehow I missed that there is a v4 and replied to v3.
So, my bad. But yes, the comment still applies here.
Best regards, Ilya Maximets.
next prev parent reply other threads:[~2024-06-25 11:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:10 [PATCH net-next v4 00/10] net: openvswitch: Add sample multicasting Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 01/10] net: psample: add user cookie Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 02/10] net: sched: act_sample: add action cookie to sample Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 03/10] net: psample: skip packet copy if no listeners Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 04/10] net: psample: allow using rate as probability Adrian Moreno
2024-06-25 11:17 ` Paolo Abeni
2024-06-25 11:28 ` Ilya Maximets [this message]
2024-06-25 18:32 ` Adrián Moreno
2024-06-21 10:10 ` [PATCH net-next v4 05/10] net: openvswitch: add emit_sample action Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 06/10] net: openvswitch: store sampling probability in cb Adrian Moreno
2024-06-21 10:10 ` [PATCH net-next v4 07/10] selftests: openvswitch: add emit_sample action Adrian Moreno
2024-06-21 10:11 ` [PATCH net-next v4 08/10] selftests: openvswitch: add userspace parsing Adrian Moreno
2024-06-21 10:11 ` [PATCH net-next v4 09/10] selftests: openvswitch: parse trunc action Adrian Moreno
2024-06-21 10:11 ` [PATCH net-next v4 10/10] selftests: openvswitch: add emit_sample test Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde22f96-d91c-4cfc-b669-3b0b0b23c77e@ovn.org \
--to=i.maximets@ovn.org \
--cc=aconole@redhat.com \
--cc=amorenoz@redhat.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yotam.gi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®