Re: [PATCH] ASoC: amd: acp-config: force SoundWire probe on Dell 14S DS14265

["Mukunda,Vijendar" <vijendar.mukunda@amd.com>]

On 10/16/26 14:59, Art O Cathain via B4 Relay wrote:
> [Some people who received this message don't often get email from devnull+art.home.gmail.com@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Art O Cathain <art.home@gmail.com>
>
> The BIOS on the Dell 14S DS14265 (ACP PCI revision 0x72) reports
> acp-audio-config-flag = FLAG_AMD_LEGACY_ONLY_DMIC. As a result
> snd_pci_ps returns early and the SoundWire links are never scanned,
> while the legacy snd_acp_pci driver probes the device, finds no
> matching machine driver ("No matching ASoC machine driver found") and
> no internal sound card is created. The CS42L45 headset codec on link 0
> and the two CS35L63 speaker amplifiers on link 1 never enumerate.
>
> Add a DMI entry for the model to the ACP70 ACPI flag override table so
> the firmware-provided flag is overridden and snd_pci_ps probes instead.
> Match on the product name rather than the board name, as the same
> symptom has been reported on several boards of this model (09PVND,
> 0M0J65, 0C7F12).
>
> Tested on a DS14265 (board 09PVND, BIOS 1.5.3) with Debian's 7.2.6
> kernel, with and without this entry. With it, snd_pci_ps binds, both
> SoundWire links come up, the CS42L45 and both CS35L63 enumerate, the
> existing CS42L45 + 2x CS35L63 machine entry matches, the amplifiers
> load their firmware and calibration, and the amd-soundwire card plays
> through both the internal speakers and the headphone jack. Also
> build-tested on asoc-next with W=1.
>
> Developed with AI assistance. Claude read the ACP driver source,
> identified the BIOS flag as the cause and the override table as the
> fix, wrote the DMI entry and the out-of-tree test module, and drafted
> this changelog. All hardware testing was done by the submitter, who
> has reviewed the change, understands it and takes responsibility for
> it.
>
> Cc: stable@vger.kernel.org
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Art O Cathain <art.home@gmail.com>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
>   sound/soc/amd/acp-config.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
> index 30e01bc47ee0c2b28f369358cd3ea18897ff0c5c..2fb9789cac0ace8365b2c98c21f2ef1a18b6093f 100644
> --- a/sound/soc/amd/acp-config.c
> +++ b/sound/soc/amd/acp-config.c
> @@ -98,6 +98,13 @@ static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
>                          DMI_MATCH(DMI_BOARD_NAME, "8EA2"),
>                  },
>          },
> +       {
> +               /* Dell 14S DS14265 */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Dell 14S DS14265"),
> +               },
> +       },
>          {}
>   };
>
>
> ---
> base-commit: 0f8bc3b93b76d16682a4d4999f9559b1e18016f9
> change-id: 20261016-dell-14s-acp-6628310dd359
>
> Best regards,
> --
> Art O Cathain <art.home@gmail.com>