From: Guenter Roeck <linux@roeck-us.net>
To: Samuel Herdman <lk.gzpc0@passmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Dahlin <jdahlin@gmail.com>
Subject: Re: [PATCH] hwmon: (nct6683) Add customer ID for ASRock X600DC-ITX
Date: Sat, 14 Nov 2026 08:40:26 -0800 [thread overview]
Message-ID: <bde7ca8f-b3c7-4b81-9596-825c52e3af7a@roeck-us.net> (raw)
In-Reply-To: <20261114-nct6683-asrock-x600dc-itx-v1-1-cbccf1a627fe@passmail.com>
On Sat, Nov 14, 2026 at 08:37:11PM +1100, Samuel Herdman wrote:
> From: Samuel Herdman <lk.gzpc0@passmail.com>
>
> The ASRock X600DC-ITX (BIOS 2.02) has an NCT6686D with customer ID
> 0x165f, which the driver does not know, so it only binds with force=1:
>
> nct6683: Found NCT6686D or compatible chip at 0x2e:0xa20
> nct6683 nct6683.2592: Enabling support for unknown customer ID 0x165f
> nct6683 nct6683.2592: NCT6686D EC firmware version 1.0 build 12/23/25
>
> The change:
>
> Add the customer ID so the driver binds on this board without force=1,
> and add the board to the list of tested boards.
>
> Tests:
>
> - With force=1 the readings are plausible: the CPU temperature (AMD TSI
> Addr 98h) is within a few degrees of k10temp's Tctl, VCC, VSB and
> AVSB read 3.36 V, VBAT reads 3.2 V, and fan1 reads about 1450 RPM.
> - With the same change applied to v7.3.3 on this board, the driver
> binds without force=1 and reports temperature and fan readings.
>
> The patch and this changelog were drafted with an AI coding assistant
> (Claude Code); I reviewed them and ran the tests above on my board.
>
> Signed-off-by: Samuel Herdman <lk.gzpc0@passmail.com>
> ---
> This overlaps with Johan Dahlin's pending series "hwmon: (nct6683) Fan
> control and sensor names for ASRock NCT6686D boards" (v2, 11 Nov 2026).
> Its first patch also adds NCT6683_CUSTOMER_ID_ASROCK8 (0x164a) and a
> table row at the same spot, and its later patches key fan control on
> that macro. Whichever lands second needs its macro renumbered
> throughout; I'm happy to rebase on top of that series if preferred.
Applied, fixed conflicts. Thanks a lot for letting me know.
Guenter
prev parent reply other threads:[~2026-11-14 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 9:37 Samuel Herdman via B4 Relay
2026-11-14 16:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde7ca8f-b3c7-4b81-9596-825c52e3af7a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=jdahlin@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lk.gzpc0@passmail.com \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®