From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Biggers <ebiggers3@gmail.com>, Dave Chinner <david@fromorbit.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
syzbot <syzbot+84a67953651a971809ba@syzkaller.appspotmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-xfs@vger.kernel.org,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: WARNING: bad unlock balance in xfs_iunlock
Date: Tue, 8 May 2018 22:32:01 -0500 [thread overview]
Message-ID: <bdee4367-23d8-ca37-2e8a-f05fc2df670b@sandeen.net> (raw)
In-Reply-To: <20180509023721.GA711@sol.localdomain>
On 5/8/18 9:37 PM, Eric Biggers wrote:
> On Wed, May 09, 2018 at 10:50:11AM +1000, Dave Chinner wrote:
>> On Tue, May 08, 2018 at 09:56:01AM +0200, Dmitry Vyukov wrote:
>>> On Wed, May 2, 2018 at 12:51 AM, Dave Chinner <david@fromorbit.com> wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> syzbot hit the following crash on upstream commit
>>>>>>>> 86bbbebac1933e6e95e8234c4f7d220c5ddd38bc (Mon Apr 2 18:47:07 2018 +0000)
>>>>>>>> Merge branch 'ras-core-for-linus' of
>>>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
>>>>>>>> syzbot dashboard link:
>>>>>>>> https://syzkaller.appspot.com/bug?extid=84a67953651a971809ba
>>>>>>>>
>>>>>>>> C reproducer: https://syzkaller.appspot.com/x/repro.c?id=5719304272084992
>>>>>>>> syzkaller reproducer:
>>>>>>>> https://syzkaller.appspot.com/x/repro.syz?id=5767783983874048
>>>>>>>
>>>>>>> What a mess. A hand built, hopelessly broken filesystem image made
>>>>>>> up of hex dumps, written into a mmap()d region of memory, then
>>>>>>> copied into a tmpfs file and mounted with the loop device.
>>>>>>>
>>>>>>> Engineers that can debug broken filesystems don't grow on trees. If
>>>>>>> we are to have any hope of understanding what the hell this test is
>>>>>>> doing, the bot needs to supply us with a copy of the built
>>>>>>> filesystem image the test uses. We need to be able to point forensic
>>>>>>> tools at the image to decode all the structures into human readable
>>>>>>> format - if we are forced to do that by hand or jump through hoops
>>>>>>> to create our own filesystem image than I'm certainly not going to
>>>>>>> waste time looking at these reports...
>>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Here is the image:
>>>>>> https://drive.google.com/file/d/1jzhGGe5SBJcqfsjxCLHoh4Kazke1oTfC/view
>>>>>
>>>>> Have anybody looked at the bug and the image yet?
>>>>
>>>> Yes, I did that a couple of weeks ago. Couldn't reproduce on a TOT
>>>> kernel here.
>>>
>>> Do you think it is fixed now? What fixed it? The bug was there.
>>
>> We merge fixes for fuzzing issues all the time. IIRC a big batch of
>> them from the xfstests fuzzing infrastructure went into 4.17-rc1.
>>
>> If you want a commit, then do a bisect....
>>
>
> The fix was commit 8241f7f983b9728:
>
> #syz fix: xfs: don't iunlock the quota ip when quota block
Ah, thanks. Interestingly that one was sent to the xfs list on 2/22, a couple
months before this bug report. Took some time to get reviewed and merged
upstream, and it actually landed upstream in Linus' kernel not long after
this report...
-Eric
next prev parent reply other threads:[~2018-05-09 3:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 2:01 syzbot
2018-04-03 4:38 ` Dave Chinner
2018-04-05 18:54 ` Dmitry Vyukov
2018-04-05 21:38 ` Dave Chinner
2018-04-06 16:10 ` Darrick J. Wong
2018-04-13 10:03 ` Dmitry Vyukov
2018-04-16 19:22 ` Eric Sandeen
2018-04-30 13:23 ` Dmitry Vyukov
2018-04-30 13:49 ` Eric Sandeen
2018-04-30 14:02 ` Dmitry Vyukov
2018-04-30 15:14 ` Eric Sandeen
2018-05-02 9:54 ` Jan Tulak
2018-05-08 7:52 ` Dmitry Vyukov
2018-05-09 2:48 ` Eric Sandeen
2018-05-09 8:43 ` Dmitry Vyukov
2018-05-09 23:22 ` Dave Chinner
2018-05-11 8:59 ` Dmitry Vyukov
2018-05-12 1:16 ` Dave Chinner
2018-05-08 7:54 ` Dmitry Vyukov
2018-04-30 13:24 ` Dmitry Vyukov
2018-05-01 22:51 ` Dave Chinner
2018-05-08 7:56 ` Dmitry Vyukov
2018-05-09 0:50 ` Dave Chinner
2018-05-09 2:37 ` Eric Biggers
2018-05-09 3:32 ` Eric Sandeen [this message]
2018-05-09 13:55 ` Theodore Y. Ts'o
2018-05-09 14:13 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdee4367-23d8-ca37-2e8a-f05fc2df670b@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dvyukov@google.com \
--cc=ebiggers3@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+84a67953651a971809ba@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®