From: Qu Wenruo <wqu@suse.com>
To: pavankumaryalagada@gmail.com, dsterba@suse.com
Cc: mason@kernel.org, fdmanana@suse.com, josef@toxicpanda.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, quwenruo.btrfs@gmx.com,
syzbot+55d1814e49f1fc0ba542@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] btrfs: Clean up delayed inode items on transaction abort
Date: Mon, 16 Nov 2026 11:35:28 +1030 [thread overview]
Message-ID: <bdef73c6-765e-4ea5-ac9f-6dd1a7296fcc@suse.com> (raw)
In-Reply-To: <20261114154207.73644-1-pavankumaryalagada@gmail.com>
在 2026/11/15 02:12, pavankumaryalagada@gmail.com 写道:
> From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
>
> When a transaction is aborted, btrfs_commit_inode_delayed_inode()
> fails because btrfs_join_transaction() returns an error. This makes
> btrfs_evict_inode() skip btrfs_kill_delayed_inode_items(), leaving
> pending items in the delayed node.
>
> Clean up delayed inode items when the transaction is aborted, even
> if btrfs_commit_inode_delayed_inode() returns an error.
>
> Reported-by: syzbot+55d1814e49f1fc0ba542@syzkaller.appspotmail.com
> Link: https://lore.kernel.org/all/6af131f2.44d55313.247daf.0001.GAE@google.com/T/
> Fixes: 2adc75d61203 ("btrfs: move btrfs_kill_delayed_inode_items into evict")
> Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> ---
> v2:
> - Add a condition to call btrfs_kill_delayed_inode_items() when the
> transaction is aborted, even if the inode update fails.
>
> v1: https://lore.kernel.org/linux-btrfs/avMkGGHSH2scfa0t@user/T/#t
> ---
> fs/btrfs/inode.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index abaa33471456..b3a33541b8c8 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -5623,16 +5623,21 @@ void btrfs_evict_inode(struct inode *inode)
> * the inode update is released.
> */
> ret = btrfs_commit_inode_delayed_inode(BTRFS_I(inode));
> - if (ret)
> - goto out;
>
> /*
> * This drops any pending insert or delete operations we have for this
> * inode. We could have a delayed dir index deletion queued up, but
> * we're removing the inode completely so that'll be taken care of in
> * the truncate.
> + *
> + * We must also clean up delayed inode items when the transaction is
> + * aborted.
> */
> - btrfs_kill_delayed_inode_items(BTRFS_I(inode));
> + if (!ret || test_bit(BTRFS_FS_STATE_TRANS_ABORTED, &fs_info->fs_state))
Sashiko still found a problem with this method, and it looks valid to me:
https://sashiko.dev/#/patchset/20261114154207.73644-1-pavankumaryalagada%40gmail.com
Thanks,
Qu
> + btrfs_kill_delayed_inode_items(BTRFS_I(inode));
> +
> + if (ret)
> + goto out;
>
> btrfs_init_metadata_block_rsv(fs_info, &rsv, BTRFS_BLOCK_RSV_TEMP);
> rsv.size = btrfs_calc_metadata_size(fs_info, 1);
prev parent reply other threads:[~2026-11-16 1:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 15:42 pavankumaryalagada
2026-11-16 1:05 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdef73c6-765e-4ea5-ac9f-6dd1a7296fcc@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.com \
--cc=fdmanana@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@kernel.org \
--cc=pavankumaryalagada@gmail.com \
--cc=quwenruo.btrfs@gmx.com \
--cc=skhan@linuxfoundation.org \
--cc=syzbot+55d1814e49f1fc0ba542@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®