From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbdK1MOO (ORCPT ); Tue, 28 Nov 2017 07:14:14 -0500 Received: from mout.web.de ([212.227.15.4]:58610 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbdK1MOL (ORCPT ); Tue, 28 Nov 2017 07:14:11 -0500 Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions To: Ladislav Michl , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Julia Lawall , Joe Perches , "Andrew F. Davis" , Arvind Yadav , Bartlomiej Zolnierkiewicz , Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org References: <1511809633.32426.70.camel@perches.com> <1511833514.32426.86.camel@perches.com> <7e7e64cf-dbe5-614a-f1e5-29d7b6cf9297@users.sourceforge.net> <1511856244.19952.14.camel@perches.com> <0ecf4b17-7757-adb4-b978-a80ebb15cfe6@users.sourceforge.net> <28816ce9-9d62-7d61-1889-64407eececca@users.sourceforge.net> <20171128102327.GA30267@lenoch> <796a5c89-7c72-776d-e769-e52f5e5bf43f@users.sourceforge.net> <20171128114130.GA1615@lenoch> From: SF Markus Elfring Message-ID: Date: Tue, 28 Nov 2017 13:13:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171128114130.GA1615@lenoch> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:DDeQ+h/uZLrn36xPTdl4VHMz1stJOHBDvAKAmP0avh5+QeZtYHq UeHyaNJEi4JL7t4Q0wNYGRtSIdpTwSRwTDpzTPiDFPErJ7D2KC+4Vtan98qals+H1bVogDE c07TFdDRwSZHUTq2ajDqFlXCSArA37NQ1DNm0j5nDw9qxYQlxNVWyNJtWEvsW2QjtYnlvi6 OdPHAKhLpcLuR6bRRFdag== X-UI-Out-Filterresults: notjunk:1;V01:K0:YUVT3zahXN4=:fmGD2n59uihRcL3wMz57BQ IQ6oSS1YDQ9IrWQiFcZR7NreCdYP0Kuq4hKfsHLM6ckFD5mRZrUZgjJTJhjq6uOUAlTp1HRm4 jGRD5OAZudxQMxJWuf26t6dfn6ALALSNorDlvPjLSke2FirDmH7MMIFaQEXDhPhPp+hg+65mF blKEbVX4uQNkuSQjPzJGosOYJWaAtJKXgKc6emqn6C1MGdjC1twADlsMhqpulI6tQ6RAHkuX9 UfrUFg77FOoUVwgsV6RdaCoT8INVLH1mKqWd8hO2HpaZapPMM8uA5Z4Hhqt8j1Tx3H3JHOTwV o+T7LoxAHksIArkohLUIC6IDdoV9qLgF3W3E/J18J7dIa8+7Rcs86s4uHcuCOo0gJgWOoHWmd XGtZa6c9975GHCaGz1RTe0Ro/opmZbU1SNYr62KxkOcQ88oGQDukOgNSF8R34A5uZUBxlSYT5 du3hhOcXKW0X8CqmMz3zChUEr9hc3yR9kMMXmNRbzmM32PQxINJP6hHpLdo+S6UKkIthEirVf 5MHZVcj2bHEqrFwJAkto7R+GTNzD//jJYSOSHH7RGvpS5FxNFsrb3zPzaRWuSV/dNRhEDZCGJ K+oINOgVT62rQAn34rtfsgHs1Ck/vk3MBRpu2UiaVgjmdg1WA7ACE4qsPpUm0xbUh7scBJvYD Bq2d5FvGh7tOYi7Z8r8KUEdaxgFVL9m5Ps/v499kAsT6nHB6cdZkioVZPal5qhw45Jiw7FDix vkpymEbSSwHokGlAp6vHsu+PcRUI9PK5U7F4cOA94G+z+fixyu5mL2DqCOy/6e0v9iaoJ0ZsE Sbtw4sl4ucfOxZaCpA7bPUEck/gvXPHF4wkGIXAnopW3y+MITc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I am not going to “verify” your update suggestion by my evolving approaches >> around the semantic patch language (Coccinelle software) at the moment. > > As you are sending patches as Markus Elfring I am contributing also some update suggestions. > I would expect you take Coccinelle's suggestion into account The proposed change is based on a semantic patch script which I developed with the support of other well-known Linux contributors. > and actually try to understand code before sending patch. I concentrated my understanding on the concrete transformation pattern in this use case. > That suggestion may lead to actual bug in code which your patch just leaves > unnoticed as it is not apparent from the patch itself There can be other change possibilities left over as usual. > (no, not talking about this very patch it all started with) Thanks for your distinction. > That said, I'm considering Markus Elfring being a human. Thanks for this view. > If you do not like reactions to your patches I am looking for constructive responses. - Disagreements can trigger special communication challenges. > or are interested only in improving tool that generates them, How do you think about to look at any more background information? https://github.com/coccinelle/coccinelle/issues https://systeme.lip6.fr/pipermail/cocci/ > it would be better to just setup a "tip bot for Markus > Elfring" and let it send patches automatically. There is already an other automatic source code analysis system active. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/scripts/coccinelle > The way you are sending patches makes impression (at least to me), > that you spent some time on fixing issue Coccinelle found Yes. - This view is appropriate. > and not just shut the warning up. Additional improvement possibilities can be taken into account after corresponding software development discussions, can't they? Regards, Markus