From: Michal Simek <michal.simek@xilinx.com>
To: Ronak Jain <ronak.jain@xilinx.com>, <michal.simek@xilinx.com>,
<linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <corbet@lwn.net>,
<linux-arm-kernel@lists.infradead.org>, <arnd@arndb.de>,
<lakshmi.sai.krishna.potthuri@xilinx.com>, <radheys@xilinx.com>,
<agodhasa@xilinx.com>
Subject: Re: [PATCH] firmware: xilinx: add support for sd/usb/gem config
Date: Fri, 29 Apr 2022 13:34:33 +0200 [thread overview]
Message-ID: <bdf10e9f-37e3-ee1d-481b-9285fa133a9e@xilinx.com> (raw)
In-Reply-To: <1651227402-17658-1-git-send-email-ronak.jain@xilinx.com>
On 4/29/22 12:16, Ronak Jain wrote:
> Add new APIs in firmware to configure SD/GEM/USB registers. Internally
> it calls PM IOCTL for below SD/GEM/USB register configuration:
> - SD/EMMC select
> - SD slot type
> - SD base clock
> - SD 8 bit support
> - GEM SGMII Mode
> - SD fixed config
> - GEM fixed config
> - USB fixed config
>
> Signed-off-by: Ronak Jain <ronak.jain@xilinx.com>
I think it was said that you shouldn't send interface changes without any user.
It means every function you add should be also used.
Thanks,
Michal
prev parent reply other threads:[~2022-04-29 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:16 Ronak Jain
2022-04-29 11:34 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdf10e9f-37e3-ee1d-481b-9285fa133a9e@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=agodhasa@xilinx.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=lakshmi.sai.krishna.potthuri@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radheys@xilinx.com \
--cc=ronak.jain@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®