mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Babu Moger <babu.moger@amd.com>
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	Reinette Chatre <reinette.chatre@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev
Subject: Re: [PATCH] x86/resctrl: Only check Intel systems for SNC
Date: Mon, 18 May 2026 11:26:16 -0500	[thread overview]
Message-ID: <bdfd62d5-87b2-4a12-b223-63229b038fb2@amd.com> (raw)
In-Reply-To: <20260428232657.107381-1-tony.luck@intel.com>

+ Reinette:

On 4/28/26 18:26, Tony Luck wrote:
> topology_num_nodes_per_package() reports values greater than one on
> certain AMD systems resulting in snc_get_config() printing the confusing
> message "CoD enabled system? Resctrl not supported".
> 
> Add a check for Intel systems before looking at topology.
> 
> Fixes: 59674fc9d0bf ("x86/resctrl: Fix SNC detection")
> Reported-by: Babu Moger Babu <babu.moger@amd.com>

Should be:

Reported-by: Babu Moger <babu.moger@amd.com>

> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Tested-by: Babu Moger Babu <babu.moger@amd.com>

Should be:

Tested-by: Babu Moger <babu.moger@amd.com>

> ---
>   arch/x86/kernel/cpu/resctrl/monitor.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 9bd87bae4983..59215fef3924 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -377,7 +377,12 @@ static const struct x86_cpu_id snc_cpu_ids[] __initconst = {
>   
>   static __init int snc_get_config(void)
>   {
> -	int ret = topology_num_nodes_per_package();
> +	int ret;
> +
> +	if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
> +		return 1;
> +
> +	ret = topology_num_nodes_per_package();
>   
>   	if (ret > 1 && !x86_match_cpu(snc_cpu_ids)) {
>   		pr_warn("CoD enabled system? Resctrl not supported\n");


      reply	other threads:[~2026-05-18 16:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-28 23:26 Tony Luck
2026-05-18 16:26 ` Babu Moger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdfd62d5-87b2-4a12-b223-63229b038fb2@amd.com \
    --to=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@lists.linux.dev \
    --cc=reinette.chatre@intel.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®