From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06CA13876B8 for ; Thu, 2 Apr 2026 10:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125695; cv=none; b=sBcB1ClCr+7usOsdZqMfM3vEM2F2UseiC3QYlW6TzLcdutG72yDuEyETe21ISk2B5HWX5fpyRmf7G0hE5U6SRTg5MZZCsIWPxfATNV88Kz3QL6md02vzIDFaLrqJp700xAAiWgGbZh1VgA5uF4mCyZ7+xHvRhRho3e8okmQdYaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125695; c=relaxed/simple; bh=REcENdaosnAkFqqFzOgJyBHuHUx4hDLNOUZw3J7VwQA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Z2IwcO8sbFzPJ2I3VM3cUgmh1ylqx6GrsE9UPFo67kJmKCMys9ZxLUwVxzU7zAC8FMfojGq4dAhhPgT7CSnbwPb+f5Atl/zxInpXgZx7QTDXtCIv1GwE9n6RxAMO4u2qYmIF97JV5efQS62+nBbXmR1PjdK9HKQ6Dczaqnnv+aA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QtEE2CB/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eVedCqqm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QtEE2CB/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eVedCqqm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6329oj851551329 for ; Thu, 2 Apr 2026 10:28:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AQ7Zd5cgb0yk5pits+gN3wLhngPs3KzNIb6mGSmkcF0=; b=QtEE2CB/LG9Io4Go EGhJemTXECeThCcc/wBzfFu7oYLJTSD+Xjh5AElDvpqmEWXIlVlpD0Iixl/+nm5D KMkDQ6kNvHV3qraajIboWHlpMKVWW1c0I76IDVtT1fhmNlxf0NoIPozhtc/fRoyr wLnS4Wjc0pN+s5BgW/doG+xZhHQsUiLAKA0+KI5FrlSgztvBUMNnQYpNqlw6LAQT SX+AWvVmaBWYYSg48+qbTSRQuP8B6/u/nNN+6my7WhiMO4RkPnj3h/kMOO6CKy8m R8xMlkZ6onc7wmcWOaigKL0DSwHrDSB+3DGmKmNggJKgHmGtyHVr0bY5fFAjOWsM lhxz4Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9heeset7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 10:28:13 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b249975139so17876285ad.0 for ; Thu, 02 Apr 2026 03:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775125692; x=1775730492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AQ7Zd5cgb0yk5pits+gN3wLhngPs3KzNIb6mGSmkcF0=; b=eVedCqqmjefnPpxVXco0mBCu/W1eLTSGcngPGZpQN9eC57LeQ5ZbRnWefvKTw7Qc0i igrkb9BYUclviYIeqAK0SspD642KSMUm9gzNeYh7JHRQMypealwRp+8e1pg0dVn51CY6 09Y3J1wmBGz4mpr6GPJTwKAZCuDZ3uzmZ6AvpudXO3L7LK6KGzBz+EYCWQB9QBx+1dvP jys+1ZHO4cWcP7GpzkTEbEKDaQ0z2PpR1XDgNII4wwCnPJrJXyLVLxREDhm0IYvrqlka /xM/BOnNKrJRMFVSCybvW54CWumMZuUZrM146mzZXrkpqZ7APZE8RAS34Sxe6FgPhDff uC6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775125692; x=1775730492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AQ7Zd5cgb0yk5pits+gN3wLhngPs3KzNIb6mGSmkcF0=; b=HooJG9ExasWbERHVjXy8IK+wcpv3kgIEW8a1d2m/YTW6emzWyd5m5e3h1HPPM9QwK5 UPE3ZfeaiA6mzrrbW5mkeTSmTLc8fJr8yuayLV7+wea8ku9hI5nSla0w1fUkTg5UrMgU UApZaBFxF+f6c9NBhNax+VA9FlZ4du4SBcqZRRiMtRwL0yqJo797Z8xNo0chg7Y3Ppo+ J69jiZsQm8iS9c7DNPhW4rGfGExAKJV7Qn+vjv7x315GcgNaA1lIdGpD2mVzixW+oRVr VvplLOvb72tboyCKqJk7911NPDJefAfP8zPTREWLumqcgU/W9F9FmqqQEKBBbZQ4iXi4 9iAg== X-Gm-Message-State: AOJu0YyRFACRhTGSPx5glWKnNouE8cZf+EYxGqZlRRpNBpE9nEafrVU/ TgJyxdzI1CbflRwEudIRoWmCSZcRJ5ou50DeljvIMVyU70Up58A+jOu8kPNXCFUPL8mVbdE89Dj FBEb+2bl/6SFSKcA2pasOrLAgsmmIzfUy2/VPS9b2i4o3ji+l3+bPvo177PD67A3qc9s= X-Gm-Gg: AeBDiet6XfX0ao5zZzF09mGroXuGWk2p1ye3/BMoZBR+z+KafNLWmUn7/psQrRAHw8G nFPCOvFNKLb0JXkntOG2Yrjnjm6ru4rOJZJz86G26HGuz+L4hco6NagXa1vIdcuWYqooxiJXbqJ QTNEEfNSGy1XcXkDpbi7H33YzYZeBaaIH0WJKyQINikbiXHriqnpn72wkq0IGvEEw5wN61NpgMi FraSqdhgzqA1p304Ug5ziep7JnHFOJ45vlkeO1lbWuFL+yF6HPCTsFgPkZyhvIQA5Un2njdTMb8 qzyKcQiL9WwMfzmGYjHpTS5DgtlaF7igHePXsaY3emhQEOOWZnEvCdzpw/uiKIE5OWiNqLQ9InF k0c5p792aHCVNEmuCmEXxhvqdM1wYCKmlKhx+mF6B3M7hfCsJSPIuSAbIK3McL2gQstFu/fiXkp MHA+grStZhYd0= X-Received: by 2002:a17:903:1a4e:b0:2b0:51f6:d46e with SMTP id d9443c01a7336-2b269c3c5f6mr76030875ad.15.1775125692319; Thu, 02 Apr 2026 03:28:12 -0700 (PDT) X-Received: by 2002:a17:903:1a4e:b0:2b0:51f6:d46e with SMTP id d9443c01a7336-2b269c3c5f6mr76030445ad.15.1775125691854; Thu, 02 Apr 2026 03:28:11 -0700 (PDT) Received: from [10.133.33.180] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27475ff56sm24425525ad.22.2026.04.02.03.28.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 03:28:11 -0700 (PDT) Message-ID: Date: Thu, 2 Apr 2026 18:28:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 5/7] qcom-tgu: Add support to configure next action To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260402092838.341295-1-songwei.chai@oss.qualcomm.com> <20260402092838.341295-6-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260402092838.341295-6-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 1bmKw1DBu8qnTbI5nFHx-GNvdeZTpyI9 X-Authority-Analysis: v=2.4 cv=VY36/Vp9 c=1 sm=1 tr=0 ts=69ce44bd cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=Ex1FgqpvNLb1JEDmgOQA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: 1bmKw1DBu8qnTbI5nFHx-GNvdeZTpyI9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA5MyBTYWx0ZWRfXzmH3wnG5U9YH URBLsuSN/7mtVhS2ZGBL1BWMHVCxzvj4Lg6jZvnkue/mWu3X8+/byr4d+ziCaStiBTWFGj56sda 2wVw5xvGwQoEmiAIDl3tW9RIm3Ci4c0hbeqZwLXCvh0kqeQ8Eitvt/nQspvzJdd3CVN1/yft97t fDydopVRAgAqAxJQPhYgsJBLPgIWAYGDIsqem3IJNcT/DyB4UwGF5IhBLZIkk60uilwBFek/XTS OYeB5geUNz8VXYk2JDjwxu6zj/QZkjFm81G+aBOlPGyIokOqGrXKxkHZNokrdjdbTsAv1uKzBOc Uwo4MgUKp+rOdzD8fy8K86dq9cMnE/SZoXEvoHrgXNkA0i6vwJ9Ek+gYkgJFEMNgprr46OgS85P 1+NymIsPzKOKNxhctLhdCMAQCuDLjLi+4OvKFahae4aLaQHSHgExE47HfQifUcaubJvUlQc9XNF QCD6mfpSJcloDQrnCrg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020093 On 4/2/2026 5:28 PM, Songwei Chai wrote: > Add "select" node for each step to determine if another step is taken, > trigger(s) are generated, counters/timers incremented/decremented, etc. > > Reviewed-by: Jie Gan > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 +++ > drivers/hwtracing/qcom/tgu.c | 53 ++++++++++++++++++- > drivers/hwtracing/qcom/tgu.h | 27 ++++++++++ > 3 files changed, 85 insertions(+), 2 deletions(-) > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > index 4ef0d696d3d0..786cb852bbe5 100644 > --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -21,3 +21,10 @@ KernelVersion: 7.1 > Contact: Jinlong Mao , Songwei Chai > Description: > (RW) Set/Get the decode mode with specific step for TGU. > + > +What: /sys/bus/amba/devices//step[0:7]_condition_select/reg[0:3] > +Date: April 2026 > +KernelVersion: 7.1 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (RW) Set/Get the next action with specific step for TGU. > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > index 5b37eb10f863..4112e6a691d6 100644 > --- a/drivers/hwtracing/qcom/tgu.c > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -29,6 +29,9 @@ static int calculate_array_location(struct tgu_drvdata *drvdata, > case TGU_CONDITION_DECODE: > return step_index * (drvdata->num_condition_decode) + > reg_index; > + case TGU_CONDITION_SELECT: > + return step_index * (drvdata->num_condition_select) + > + reg_index; > default: > break; > } > @@ -71,6 +74,9 @@ static ssize_t tgu_dataset_show(struct device *dev, > case TGU_CONDITION_DECODE: > return sysfs_emit(buf, "0x%x\n", > drvdata->value_table->condition_decode[index]); > + case TGU_CONDITION_SELECT: > + return sysfs_emit(buf, "0x%x\n", > + drvdata->value_table->condition_select[index]); > default: > break; > } > @@ -112,6 +118,10 @@ static ssize_t tgu_dataset_store(struct device *dev, > tgu_drvdata->value_table->condition_decode[index] = val; > ret = size; > break; > + case TGU_CONDITION_SELECT: > + tgu_drvdata->value_table->condition_select[index] = val; > + ret = size; > + break; > default: > ret = -EINVAL; > break; > @@ -146,6 +156,13 @@ static umode_t tgu_node_visible(struct kobject *kobject, > if (tgu_attr->reg_num < drvdata->num_condition_decode) > return attr->mode; > break; > + case TGU_CONDITION_SELECT: > + /* 'default' register is at the end of 'select' region */ > + if (tgu_attr->reg_num == drvdata->num_condition_select - 1) > + attr->name = "default"; > + if (tgu_attr->reg_num < drvdata->num_condition_select) > + return attr->mode; > + break; > default: > break; > } > @@ -184,6 +201,18 @@ static ssize_t tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) > drvdata->base + CONDITION_DECODE_STEP(i, j)); > } > } > + > + for (i = 0; i < drvdata->num_step; i++) { > + for (j = 0; j < drvdata->num_condition_select; j++) { > + index = check_array_location(drvdata, i, > + TGU_CONDITION_SELECT, j); > + if (index == -EINVAL) > + goto exit; > + > + writel(drvdata->value_table->condition_select[index], > + drvdata->base + CONDITION_SELECT_STEP(i, j)); > + } > + } > /* Enable TGU to program the triggers */ > writel(1, drvdata->base + TGU_CONTROL); > exit: > @@ -223,6 +252,8 @@ static void tgu_set_conditions(struct tgu_drvdata *drvdata) > > devid = readl(drvdata->base + TGU_DEVID); > drvdata->num_condition_decode = TGU_DEVID_CONDITIONS(devid); > + /* select region has an additional 'default' register */ > + drvdata->num_condition_select = TGU_DEVID_CONDITIONS(devid) + 1; > } > > static int tgu_enable(struct device *dev) > @@ -366,6 +397,14 @@ static const struct attribute_group *tgu_attr_groups[] = { > CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(5), > CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(6), > CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(7), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(0), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(1), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(2), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(3), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(4), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(5), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(6), > + CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(7), > NULL, > }; > > @@ -373,8 +412,8 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > { > struct device *dev = &adev->dev; > struct tgu_drvdata *drvdata; > - unsigned int *priority, *condition; > - size_t priority_size, condition_size; > + unsigned int *priority, *condition, *select; > + size_t priority_size, condition_size, select_size; > int ret; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > @@ -425,6 +464,16 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > > drvdata->value_table->condition_decode = condition; > > + select_size = drvdata->num_condition_select * drvdata->num_step; > + > + select = devm_kcalloc(dev, select_size, > + sizeof(*(drvdata->value_table->condition_select)), > + GFP_KERNEL); > + if (!select) > + return -ENOMEM; > + > + drvdata->value_table->condition_select = select; > + > drvdata->enabled = false; > > pm_runtime_put(&adev->dev); > diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h > index 987ea07bd618..ac46a2875209 100644 > --- a/drivers/hwtracing/qcom/tgu.h > +++ b/drivers/hwtracing/qcom/tgu.h > @@ -52,6 +52,7 @@ > #define STEP_OFFSET 0x1D8 > #define PRIORITY_START_OFFSET 0x0074 > #define CONDITION_DECODE_OFFSET 0x0050 > +#define CONDITION_SELECT_OFFSET 0x0060 > #define PRIORITY_OFFSET 0x60 > #define REG_OFFSET 0x4 > > @@ -63,6 +64,9 @@ > #define CONDITION_DECODE_STEP(step, decode) \ > (CONDITION_DECODE_OFFSET + REG_OFFSET * decode + STEP_OFFSET * step) > > +#define CONDITION_SELECT_STEP(step, select) \ > + (CONDITION_SELECT_OFFSET + REG_OFFSET * select + STEP_OFFSET * step) > + > #define tgu_dataset_rw(name, step_index, type, reg_num) \ > (&((struct tgu_attribute[]){ { \ > __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \ > @@ -76,6 +80,8 @@ > reg_num) > #define STEP_DECODE(step_index, reg_num) \ > tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_DECODE, reg_num) > +#define STEP_SELECT(step_index, reg_num) \ > + tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_SELECT, reg_num) > > #define STEP_PRIORITY_LIST(step_index, priority) \ > {STEP_PRIORITY(step_index, 0, priority), \ > @@ -107,6 +113,15 @@ > NULL \ > } > > +#define STEP_SELECT_LIST(n) \ > + {STEP_SELECT(n, 0), \ > + STEP_SELECT(n, 1), \ > + STEP_SELECT(n, 2), \ > + STEP_SELECT(n, 3), \ > + STEP_SELECT(n, 4), \ > + NULL \ > + } > + > #define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\ > (&(const struct attribute_group){\ > .attrs = (struct attribute*[])STEP_PRIORITY_LIST(step, priority),\ > @@ -121,12 +136,21 @@ > .name = "step" #step "_condition_decode" \ > }) > > +#define CONDITION_SELECT_ATTRIBUTE_GROUP_INIT(step)\ > + (&(const struct attribute_group){\ > + .attrs = (struct attribute*[])STEP_SELECT_LIST(step),\ > + .is_visible = tgu_node_visible,\ > + .name = "step" #step "_condition_select" \ > + }) > + > + remove extra blank line. Thanks, Jie > enum operation_index { > TGU_PRIORITY0, > TGU_PRIORITY1, > TGU_PRIORITY2, > TGU_PRIORITY3, > TGU_CONDITION_DECODE, > + TGU_CONDITION_SELECT, > }; > > /* Maximum priority that TGU supports */ > @@ -142,6 +166,7 @@ struct tgu_attribute { > struct value_table { > unsigned int *priority; > unsigned int *condition_decode; > + unsigned int *condition_select; > }; > > static inline void TGU_LOCK(void __iomem *addr) > @@ -172,6 +197,7 @@ static inline void TGU_UNLOCK(void __iomem *addr) > * @num_reg: Maximum number of registers > * @num_step: Maximum step size > * @num_condition_decode: Maximum number of condition_decode > + * @num_condition_select: Maximum number of condition_select > * > * This structure defines the data associated with a TGU device, > * including its base address, device pointers, clock, spinlock for > @@ -187,6 +213,7 @@ struct tgu_drvdata { > int num_reg; > int num_step; > int num_condition_decode; > + int num_condition_select; > }; > > #endif