From: "lihuisong (C)" <lihuisong@huawei.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: <lenb@kernel.org>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
<jonathan.cameron@huawei.com>, <zhanjie9@hisilicon.com>,
<zhenglifeng1@huawei.com>, <yubowen8@huawei.com>
Subject: Re: [PATCH v3 3/3] ACPI: processor: Do not expose the global acpi_idle_driver variable
Date: Mon, 22 Sep 2025 09:22:22 +0800 [thread overview]
Message-ID: <be080550-9480-4040-adc2-c438d7d407f4@huawei.com> (raw)
In-Reply-To: <CAJZ5v0hAYpBWTpfJV6ZVX0tLiZZ-S5ABxpmqckxYcPyMyZrJfA@mail.gmail.com>
在 2025/9/19 5:22, Rafael J. Wysocki 写道:
> On Thu, Sep 18, 2025 at 2:23 PM lihuisong (C) <lihuisong@huawei.com> wrote:
>>
>> 在 2025/9/18 4:01, Rafael J. Wysocki 写道:
>>> On Thu, Sep 11, 2025 at 1:24 PM Huisong Li <lihuisong@huawei.com> wrote:
>>>> Currently, processor_driver just use the global acpi_idle_driver variable
>>>> to check if the cpuidle driver is acpi_idle_driver. Actually, there is no
>>>> need to expose this global variable defined in processor_idle.c to outside.
>>>> So move the related logical to acpi_processor_power_init() and do not
>>>> expose it.
>>> And it can also be made static, can't it?
>> ok, will do it in next version. Thanks.
> You may as well rebase it on top of this one:
>
> https://lore.kernel.org/linux-acpi/5044465.31r3eYUQgx@rafael.j.wysocki/
Ok, will will fix it based your patch.
Thank you for the reminder.
>
prev parent reply other threads:[~2025-09-22 1:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 11:24 [PATCH v3 0/3] ACPI: processor: Fix function declaration of processor_idle.c Huisong Li
2025-09-11 11:24 ` [PATCH v3 1/3] ACPI: processor: Remove unused empty function definition for processor_idle.c Huisong Li
2025-09-16 20:22 ` Rafael J. Wysocki
2025-09-11 11:24 ` [PATCH v3 2/3] ACPI: processor: Unify the place of function declaration of processor_idle.c Huisong Li
2025-09-17 19:56 ` Rafael J. Wysocki
2025-09-11 11:24 ` [PATCH v3 3/3] ACPI: processor: Do not expose the global acpi_idle_driver variable Huisong Li
2025-09-17 20:01 ` Rafael J. Wysocki
2025-09-18 12:23 ` lihuisong (C)
2025-09-18 21:22 ` Rafael J. Wysocki
2025-09-22 1:22 ` lihuisong (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be080550-9480-4040-adc2-c438d7d407f4@huawei.com \
--to=lihuisong@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rafael@kernel.org \
--cc=yubowen8@huawei.com \
--cc=zhanjie9@hisilicon.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®