From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BCB63B8BC7 for ; Tue, 31 Mar 2026 07:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941072; cv=none; b=u9zZPqVRZFgpo83n6LSonyloNpDOAq/cNCdocfYYidId4sZXD7LOefJeo3YKgraVi1yjyVdW6jFJSL98HBvsUCis4jvMLrnl6UAQpHiGgmswHIgIyIe3iC/EldDLogoLYsccieUbppZNKOcRhj1AVqDY+pI7co3UwBSMPsVykF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774941072; c=relaxed/simple; bh=DeQTnbqhg+de5c/s3eL98xDzIqw0kK9FCFFZEb6566k=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=PLcblFbDVDpDHg5/pT3H22w0SUGUcibSrleMEK7uq7OGP8hvzoPOR5cAq1r7KKNNy9GFX0JVruyG7MbvigD4j7xhjlZB9OuzVUHY8QUUchfJCdWQSrDqAxdhMLNgDileu3UgnM1c7EbNYr/9I/fBiG+PnluhnGtPOYk02Ydm3mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kfq2G7NU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kfq2G7NU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3154C19423; Tue, 31 Mar 2026 07:11:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774941072; bh=DeQTnbqhg+de5c/s3eL98xDzIqw0kK9FCFFZEb6566k=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=Kfq2G7NUpl/u8TT2bDK+BzffctxAloft9yhUTOJRvcYUJOzX+fiJTKMw956uSUPEY gWahYzuVaWfPpFUJJPuZgddjoqT+tiU8+hHoAyV1a4Ls6zQqlfLu+0FGpBSG/dALaR 4LMf8N8tHRwSJxu8jBeF09FH5mDx6LlPmfBDnK0ru2+2C3SwejG7bZm906Alhi+IXw 5DI4vvtQwI9acRA6GyPkekuCAR4UyqcGl6nactpXg7SJHbs0OCuiAolx3uUMqRAUbN HfobWT3nn97vWH0HAbh54fyEBx3k3HKMrH4ziaFhv9mL8+3QgjSc1GoCAEeAz9yo68 ow/u/bIT5Tvkw== Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfauth.phl.internal (Postfix) with ESMTP id C0034F40078; Tue, 31 Mar 2026 03:11:10 -0400 (EDT) Received: from phl-imap-02 ([10.202.2.81]) by phl-compute-01.internal (MEProxy); Tue, 31 Mar 2026 03:11:10 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdefgeduvdegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedftehrugcu uehivghshhgvuhhvvghlfdcuoegrrhgusgeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpedvueehiedtvedtleekuddutefgffdtleetfeetveejveejieehfefhjeei jeefudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhguodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieejtdehtddtjeel qdeffedvudeigeduhedqrghruggspeepkhgvrhhnvghlrdhorhhgseifohhrkhhofhgrrh gurdgtohhmpdhnsggprhgtphhtthhopeeipdhmohguvgepshhmthhpohhuthdprhgtphht thhopegsphesrghlihgvnhekrdguvgdprhgtphhtthhopehthhhomhgrshdrlhgvnhgurg gtkhihsegrmhgurdgtohhmpdhrtghpthhtoheprghruggsodhgihhtsehgohhoghhlvgdr tghomhdprhgtphhtthhopegvsghighhgvghrsheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepgiekieeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhn vghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ice86485a:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 9AECC700065; Tue, 31 Mar 2026 03:11:10 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: ATwkRWXiqgow Date: Tue, 31 Mar 2026 09:10:50 +0200 From: "Ard Biesheuvel" To: "Ard Biesheuvel" , linux-kernel@vger.kernel.org Cc: x86@kernel.org, "Borislav Petkov" , "Tom Lendacky" , "Eric Biggers" Message-Id: In-Reply-To: <20251010151036.42241-2-ardb+git@google.com> References: <20251010151036.42241-2-ardb+git@google.com> Subject: Re: [PATCH] x86/sev: Remove bogus virtual address check Content-Type: text/plain Content-Transfer-Encoding: 7bit (cc Eric) On Fri, 10 Oct 2025, at 17:10, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > The AES-GCM crypto library operates strictly on virtual addresses, and > never performs any H/W offload, and so calling virt_addr_valid() is not > needed. > > Cc: Borislav Petkov (AMD) > Cc: Tom Lendacky > Signed-off-by: Ard Biesheuvel > --- > arch/x86/coco/sev/core.c | 9 --------- > 1 file changed, 9 deletions(-) > Ping? > diff --git a/arch/x86/coco/sev/core.c b/arch/x86/coco/sev/core.c > index 9ae3b11754e6..c4e2de3687a9 100644 > --- a/arch/x86/coco/sev/core.c > +++ b/arch/x86/coco/sev/core.c > @@ -2249,15 +2249,6 @@ int snp_send_guest_request(struct snp_msg_desc > *mdesc, struct snp_guest_req *req > u64 seqno; > int rc; > > - /* > - * enc_payload() calls aesgcm_encrypt(), which can potentially offload to HW. > - * The offload's DMA SG list of data to encrypt has to be in linear mapping. > - */ > - if (!virt_addr_valid(req->req_buf) || !virt_addr_valid(req->resp_buf)) { > - pr_warn("AES-GSM buffers must be in linear mapping"); > - return -EINVAL; > - } > - > guard(mutex)(&snp_cmd_mutex); > > /* Check if the VMPCK is not empty */ > -- > 2.51.0.740.g6adb054d12-goog