From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D30C433E9 for ; Fri, 5 Mar 2021 21:44:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0827E650A8 for ; Fri, 5 Mar 2021 21:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbhCEVoJ (ORCPT ); Fri, 5 Mar 2021 16:44:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbhCEVnv (ORCPT ); Fri, 5 Mar 2021 16:43:51 -0500 Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2ABFC06175F; Fri, 5 Mar 2021 13:43:50 -0800 (PST) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Dsh7g59sjz1rwn0; Fri, 5 Mar 2021 22:43:43 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Dsh7g3fl1z1qr4d; Fri, 5 Mar 2021 22:43:43 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id zA9oLoIZs84D; Fri, 5 Mar 2021 22:43:41 +0100 (CET) X-Auth-Info: GmqYrIyAYBzZBk9/Hy/h0siIg5F0MIUqR5KnsSVg2Bc= Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 5 Mar 2021 22:43:40 +0100 (CET) Subject: Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for SN65DSI83/84/85 To: Jagan Teki , Rob Herring , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-amarula@amarulasolutions.com References: <20210214174453.104616-1-jagan@amarulasolutions.com> From: Marek Vasut Message-ID: Date: Fri, 5 Mar 2021 22:43:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210214174453.104616-1-jagan@amarulasolutions.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/21 6:44 PM, Jagan Teki wrote: > SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge > controller IC's from Texas Instruments. > > SN65DSI83 - Single Channel DSI to Single-link LVDS bridge > SN65DSI84 - Single Channel DSI to Dual-link LVDS bridge > SN65DSI85 - Dual Channel DSI to Dual-link LVDS bridge [...] > +description: | > + SN65DSI83/84/85 devices are MIPI DSI to LVDS based bridge controller > + IC's from Texas Instruments. > + > + SN65DSI83 - Single Channel DSI to Single-link LVDS bridge > + SN65DSI84 - Single Channel DSI to Dual-link LVDS bridge > + SN65DSI85 - Dual Channel DSI to Dual-link LVDS bridge [...] > +properties: > + compatible: > + enum: > + - ti,sn65dsi83 > + - ti,sn65dsi84 DSI85 seems missing ? > + reg: > + const: 0x2c I have the DSI83 device at 0x2d, so this cannot be const 0x2c ? > + enable-gpios: > + maxItems: 1 > + description: GPIO specifier for bridge enable pin (active high). The bridge can work without this GPIO, so its optional. [...] Also, Doug reported that vcc and vcore regulators should likely be listed, see feedback on: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 bindings