From: Dave Hansen <dave.hansen@intel.com>
To: Fu Hao <fuhao@open-hieco.net>,
puwen@hygon.cn, tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com
Cc: linux-kernel@vger.kernel.org, tingyin.duan@gmail.com
Subject: Re: [PATCH v3 1/7] x86/cpu/hygon: Adjust the die_id and logical_die_id for Hygon models 0x4 through 0x8
Date: Mon, 15 Jun 2026 07:07:30 -0700 [thread overview]
Message-ID: <be116fce-07e6-40c1-90d7-440189d0d45b@intel.com> (raw)
In-Reply-To: <8d0f20314a4fb95111479166b5397e34e382a3f0.1781523812.git.fuhao@open-hieco.net>
On 6/15/26 05:17, Fu Hao wrote:
> + /*
> + * Adjust the die_id and logical_die_id for Hygon models 0x4-0x8.
> + */
> + if (c->x86_model >= 0x4 && c->x86_model <= 0x8) {
> + c->topo.die_id = cpuid_ecx(0x8000001e) & 0xff;
> + c->topo.logical_die_id = (c->topo.die_id >> 4) *
> + topology_amd_nodes_per_pkg() +
> + (c->topo.die_id & 0xf);
> + }
My assumption for Hygon stuff is that there's AMD code _somewhere_ for
99% of it. It's just a matter of using it.
Why doesn't this use parse_8000_001e()?
I think that kind of justification needs to be the baseline for Hygon
work when it adds code. It needs to explain why the code is being added
and why the existing (AMD usually) code doesn't work.
next prev parent reply other threads:[~2026-06-15 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 12:16 [PATCH v3 0/7] Add support for Hygon family 18h models 4h-8h Fu Hao
2026-06-15 12:17 ` [PATCH v3 1/7] x86/cpu/hygon: Adjust the die_id and logical_die_id for Hygon models 0x4 through 0x8 Fu Hao
2026-06-15 14:07 ` Dave Hansen [this message]
2026-06-16 7:10 ` Fu Hao
2026-06-16 7:18 ` Fu Hao
2026-06-16 15:25 ` Dave Hansen
2026-06-17 2:34 ` Fu Hao
2026-06-15 12:18 ` [PATCH v3 2/7] x86/cpu: Get LLC ID for Hygon processor models 0x6 " Fu Hao
2026-06-15 12:19 ` [PATCH v3 3/7] x86/cpu/hygon: Remove Spectral Chicken for Hygon processors Fu Hao
2026-06-15 12:20 ` [PATCH v3 4/7] perf/x86/uncore: Add L3 PMU support for Hygon family 18h model 6h Fu Hao
2026-06-15 12:21 ` [PATCH v3 5/7] x86/microcode/hygon: Add microcode loading support for Hygon processors Fu Hao
2026-06-21 0:13 ` XIAO WU
2026-06-21 17:36 ` Borislav Petkov
2026-06-22 2:22 ` Fu Hao
2026-06-21 0:19 ` XIAO WU
2026-06-22 3:24 ` Fu Hao
2026-06-15 12:22 ` [PATCH v3 6/7] ALSA: hda: Add support for Hygon family 18h model 5h HD-Audio Fu Hao
2026-06-29 10:27 ` Takashi Iwai
2026-06-15 12:23 ` [PATCH v3 7/7] ALSA: hda: Fix single byte writing issue for Hygon family 18h model 5h Fu Hao
2026-06-29 10:27 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be116fce-07e6-40c1-90d7-440189d0d45b@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fuhao@open-hieco.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=tglx@kernel.org \
--cc=tingyin.duan@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome