From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A56BC28CBC for ; Wed, 6 May 2020 11:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05A2B206D5 for ; Wed, 6 May 2020 11:47:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="lXAvBhJk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbgEFLrz (ORCPT ); Wed, 6 May 2020 07:47:55 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:6394 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725796AbgEFLry (ORCPT ); Wed, 6 May 2020 07:47:54 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 06 May 2020 04:46:44 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 06 May 2020 04:47:54 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 06 May 2020 04:47:54 -0700 Received: from [10.25.78.179] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 6 May 2020 11:47:52 +0000 Subject: Re: [PATCH] phy: tegra: Use PTR_ERR_OR_ZERO() to simplify code To: Aishwarya Ramakrishnan , Kishon Vijay Abraham I , Thierry Reding , Jonathan Hunter , Lorenzo Pieralisi , , , References: <20200505150058.17674-1-aishwaryarj100@gmail.com> X-Nvconfidentiality: public From: Vidya Sagar Message-ID: Date: Wed, 6 May 2020 17:17:49 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200505150058.17674-1-aishwaryarj100@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1588765604; bh=BJBqJSRQf6+TfAc5agbOFu+x857JC8+7fnNqVj7P1aE=; h=X-PGP-Universal:Subject:To:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=lXAvBhJkbpUiZOHzaAwwDF61VpqdKcCQGjDYB34C2b8sPNq7TrGSB3yvPYtbmQ2h6 +MUrs1BzMuJRLLzbOQt5hu6exzpC4jTOGViSMgvjbkuolxNc1WLbewql4IROEm6lNQ cnRpdROBQ9U8rfQMeenem0ZdDaHxAOV41X+s2Qi8bwK+V2ZuWuYmQTdcZCkLUGWMdL f0KRQqtmzsrfmiFZpuS0hsMnvYQVMj14ttF9m5thK8LtIfBXbFpi3Ie7fPZ3tPOOiK KYtnFLAkCBGhjbr9DR8YCI2R0NcUWpwWguuDKRaHxKmZD7OC0NFQ33dePxQ8kwkzL8 m/SopzUpAFZCQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for pushing this change. I'm fine with this change as it is attempting to change only the last occurrence of the (IS_ERR(...)) + PTR_ERR combination. But, this code was initially written with PTR_ERR_OR_ZERO() itself but later changed to use (IS_ERR(...)) + PTR_ERR based on the review comment from Dmitry Osipenko ( https://lkml.org/lkml/2019/6/20/1457 ) Adding Dmitry as well to review the change. I'm fine with this change. Reviewed-by: Vidya Sagar On 05-May-20 8:30 PM, Aishwarya Ramakrishnan wrote: > External email: Use caution opening links or attachments > > > PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Aishwarya Ramakrishnan > --- > drivers/phy/tegra/phy-tegra194-p2u.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/phy/tegra/phy-tegra194-p2u.c b/drivers/phy/tegra/phy-tegra194-p2u.c > index 7042bed9feaa..42394d27f4cb 100644 > --- a/drivers/phy/tegra/phy-tegra194-p2u.c > +++ b/drivers/phy/tegra/phy-tegra194-p2u.c > @@ -92,10 +92,7 @@ static int tegra_p2u_probe(struct platform_device *pdev) > phy_set_drvdata(generic_phy, phy); > > phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); > - if (IS_ERR(phy_provider)) > - return PTR_ERR(phy_provider); > - > - return 0; > + return PTR_ERR_OR_ZERO(phy_provider); > } > > static const struct of_device_id tegra_p2u_id_table[] = { > -- > 2.17.1 >