From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: hanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Hans de Goede <hdegoede@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] extcon: extcon-max8997: Fix IRQ freeing at error path
Date: Tue, 25 May 2021 11:58:06 -0400 [thread overview]
Message-ID: <be185a44-43de-59fd-a134-e6a621f74eba@canonical.com> (raw)
In-Reply-To: <1a0f3e0d3c9786f97a0a041469a52ee145712619.1621340116.git.matti.vaittinen@fi.rohmeurope.com>
On 18/05/2021 08:32, Matti Vaittinen wrote:
> If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
> without freeing the requested IRQs.
>
> Free the IRQs prior returning if reading the status fails.
>
> Fixes: 3e34c8198960 ("extcon: max8997: Avoid forcing UART path on drive probe")
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> Changelog:
> v2:
> - new patch (avoid backporting devm_wq just to fix IRQ freeing)
> ---
> drivers/extcon/extcon-max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-05-25 15:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 12:31 [PATCH v2 0/5] Add devm helper for work-queue initialization Matti Vaittinen
2021-05-18 12:31 ` [PATCH v2 1/5] devm-helpers: Add resource managed version of work init Matti Vaittinen
2021-05-18 12:32 ` [PATCH v2 2/5] extcon: extcon-max14577: Fix potential work-queue cancellation race Matti Vaittinen
2021-05-18 12:32 ` [PATCH v2 3/5] extcon: extcon-max77693.c: " Matti Vaittinen
2021-05-18 12:32 ` [PATCH v2 4/5] extcon: extcon-max8997: Fix IRQ freeing at error path Matti Vaittinen
2021-05-25 15:58 ` Krzysztof Kozlowski [this message]
2021-05-18 12:33 ` [PATCH v2 5/5] extcon: extcon-max8997: Simplify driver using devm Matti Vaittinen
2021-05-25 15:59 ` Krzysztof Kozlowski
2021-05-19 0:39 ` [PATCH v2 0/5] Add devm helper for work-queue initialization Rob Herring
2021-05-19 5:33 ` Matti Vaittinen
2021-05-27 11:07 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be185a44-43de-59fd-a134-e6a621f74eba@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®