From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810B126A0DB for ; Wed, 26 Nov 2025 09:45:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150309; cv=none; b=pS52WltOKUAbsMD0G7WA9a4WRIJLy+Y1S7r12QtgLPOQYQaV//H4fycW6EnE0oxGfo4c39gHra5MaRsHJ1XuFPat3B3u/b1VIC5lTNN67vmzg95o0V+a8uhpTknXfRR0PGHJuyZO1fN7gHsJXz0kaCJbzLjwvS/x0aOf4X6B+Fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764150309; c=relaxed/simple; bh=7abUYFU2x1ym9PL2ZhDm/hAZFd6ZeTvVDN4t89ZYHB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j1G6SP2IHrETeaj1O+RWX+FjoiXncQqDKWm1qkqTN/31jmBlM6bXP/b1CxayfbpGftg7JXCzFcXvQmnzBFoj4QvmQCrUMxsWxH2yO/8G7BYbSY6e2RoCpQEuF7sF4c0TF+qReY+f9X8abr8d9P24NkNkYqKJX26U00JBWz9tQjI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YosCgJ4h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HxF+7s8K; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YosCgJ4h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HxF+7s8K" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AQ6m4tF2650397 for ; Wed, 26 Nov 2025 09:45:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 13cX6ISX0IUFbarkIJQizFXgndQqjxKiW+kyYBUSSkw=; b=YosCgJ4hsyVg+UZl S7B6fuq0TULCnoK1e8BnoHE9Z8FtCHY1OWdG/Jw5tnIGejDEVEB7xxTkCArpk18E +capP2Blvy8xFXYLbL6y5P1IwDkzcGFIa6Fwmq9jRnIvyYOvvQRCzfpJRzAsf6b4 kM5UqBdO58egxcFLq7FFxAnt98kA1i9AdZs+kKIWgZHGDyvV3gmFmDedTpkvX2rr x5VQdXOwchqw0+690yGjd8ADXcRUdQIxwqp18wJUXAmZ5pInWVGyEF2OR5PLferm NnkWHt/84F5EAo6/5L9sj1uq2OsjnrMvC+fuEXPrKASjOEfXJdlHL+l7qv0bbPES gyJGHQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4anaabum5b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 09:45:05 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-297f587dc2eso149006405ad.2 for ; Wed, 26 Nov 2025 01:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764150305; x=1764755105; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=13cX6ISX0IUFbarkIJQizFXgndQqjxKiW+kyYBUSSkw=; b=HxF+7s8KLh7rYrw90h0q1tzxCwj1ibtxZPaoYw1u9K8Trc5kmFlbETWeD5pxHZ2m8S l3UFNeCst2rOpqQAs9YQK3Qg4xZD7AiR3/I8IFpzSCqLO1Bro9RhVndycMmW4L4NyAG+ cJstFzGrEQnjYnypDPQmHGyOZZ60gy+rhx3oSEPfhbw1g8sFHskWoE0NEYfOW/L3WGhy vzDoDCd6+jOR+rlbxteFggo1/95FD3/QbAqo45ZgdG/oR7lpjWAL+Wr9xICvfR2pCXan K2a9FlFkJSbfviGn5LkMfPWywv8d6Q70Xs7bYrVCepBiAb6Gb87dgFDYLJVkcVNAw2rG oUcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764150305; x=1764755105; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=13cX6ISX0IUFbarkIJQizFXgndQqjxKiW+kyYBUSSkw=; b=goHgF7n+4VVjOde/x1OBHAxd2IMZ/Sr1OADiy9pR4gIpJR8EHWviHbTYXGfc3x5u2k ODfr8b2CkgO2eRGgvLMiM6F0W7Jro8UTOtBFI8DgtXZl60ghX402S3eg6d3zRfikkYng UEoFvI+M8YOoQK46Djvj2YVGS7DClaz0/iG6EMl/jxR6G39TNlMlVh0ZV4Rjj2gszkEi HkslDCp9rRhCaImhc0/QyCNqWBDO1SRYIqhpF1mDG1i0QAhdkSDvGxIIvxWy9SbPPCd0 TyKhnSBmeVPIt/ylkgPvgAbuP3hI8rIqAFCMexCKmViipCKkhebPxZuUBnzqJdX3fnAz 4hLQ== X-Forwarded-Encrypted: i=1; AJvYcCVmELnxlKN8m1IbHWoDBzZUzofhGOjcSX0CbE3N2A5X2K7WXz9j+QkkNSVzZZPhkEFQj+O6NskUXN0w6B4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxcpe58I+HGUVzf6PXCQgQNwaCG0bSnXF+v6f1KlpAo8KNo410U GKX685+kJT3qHdANj3Kywpb6HGEg0/AYL43zkCcdbGNLrf/kNaFr+1idaNVtLEKQbp2RuOk1Cmg pE2OT0ncTLL5dLn7ffCcqqkQ1H99BJ8amtfRLhKKS7Up98NoBp1PnAhN1j3LlPss+98c= X-Gm-Gg: ASbGncswxo5+2T6Z1FULosboNSB2gd04KoEp5w6Gwv8u24uD4PT6mOOO1jgX/wEu3s5 c8CAgPptw+SKOVRRyzWlWsdxwwgCXNb0CzLlAcZ3MUCytvC0QKxE85deTyAnefD5UgzoGVqFK+P b/V5WRCOUum96SjlFMRRdohauaMf8xR5Qz+1+G5Q9NRNznuRlph/5xYfNMfjWgEFFfOmx7airAU B69yfgo1JYQVatnkNLX8qUKMiDR0vqD6WP2O9XbpARAlw2KPGaUuLaUxkzRL6fAsGPSF4jOsOXe PvbgVVF4Sba+/ceQHbxuymurai2Q4GQ9Mdzs8oQhFBuvC9tii2xPbNPbT/7H5AuUKLM9dleduP5 4ukGgazB16cBLw7oBHcejFiK3UuZGjoSB8CvQPg== X-Received: by 2002:a17:902:d548:b0:297:dad8:f25b with SMTP id d9443c01a7336-29b6bd571b2mr219758845ad.0.1764150304901; Wed, 26 Nov 2025 01:45:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoLbK2maKLMcz84rNu2gUnutRB/aUU1tQn+wSJzASrqsUq98Tp0ErDwtDaGSKIgyssFh4jgA== X-Received: by 2002:a17:902:d548:b0:297:dad8:f25b with SMTP id d9443c01a7336-29b6bd571b2mr219758445ad.0.1764150304372; Wed, 26 Nov 2025 01:45:04 -0800 (PST) Received: from [10.217.217.147] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd75e6c6ad3sm18918239a12.13.2025.11.26.01.44.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Nov 2025 01:45:03 -0800 (PST) Message-ID: Date: Wed, 26 Nov 2025 15:14:57 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] clk: qcom: gcc-sdx75: Update the SDCC RCGs to use shared_floor_ops To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Vinod Koul , Konrad Dybcio , Dmitry Baryshkov , Taniya Das , Melody Olvera , Ajit Pandey , Imran Shaik , Luca Weiss Cc: Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251126-sdcc_shared_floor_ops-v1-0-9038430dfed4@oss.qualcomm.com> <20251126-sdcc_shared_floor_ops-v1-4-9038430dfed4@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20251126-sdcc_shared_floor_ops-v1-4-9038430dfed4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vd36/Vp9 c=1 sm=1 tr=0 ts=6926cc21 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=BxFOA6ydGOS16N4CFHUA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: d5lUAsMbejBqzI69LeOLJA2Oo-o4Facw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDA3OSBTYWx0ZWRfXzdrXMjuQ/09X U/K4Iw75uxi9J8OkBIqeQjVtMIhVXOIpVoQptHIXEsJg6zJeq2lVLf9rPbZwYfbrIpgpmxjIOC3 czo4XI4rlhFpBGcmtRqpo+K/lq5q3InMO1m2oh8H5W2iCyPbIefAVS9INtLQ1e+ZitR7wo/P4mf yEdt1YfEjwivElZR/ILxQr8S+nNx+kVx1CXR41lqcKiLKBntNWpbueh28bf4OGnULOdjn5czE03 ExAXaCSzYEXsb0otYeOrZlEyc/m85MS/9jzL3TKqwXYRoPomsBGqILosnoGSNbMxh4qs6qClGot tOTx4Lc2nOCrPjFQYwxqukvHgHWwY8xRuGSCRw+NM56F6L2hVoOnCCuiHxJQO894FYCrTDhv6HY sNQBkVLfEHHZfM7l4g695JCQUr4XyQ== X-Proofpoint-GUID: d5lUAsMbejBqzI69LeOLJA2Oo-o4Facw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260079 On 11/26/2025 9:45 AM, Jagadeesh Kona wrote: > Use shared_floor_ops for the SDCC RCGs so the RCG is safely parked > during disable and the new parent configuration is programmed in > hardware only when the new parent is enabled, avoiding cases where > the RCG configuration fails to update. > > Fixes: 108cdc09b2de ("clk: qcom: Add GCC driver support for SDX75") > Signed-off-by: Jagadeesh Kona > --- > drivers/clk/qcom/gcc-sdx75.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/gcc-sdx75.c b/drivers/clk/qcom/gcc-sdx75.c > index 453a6bf8e8786308ef785799f71b6cff8a5a9727..1f3cd58483a2d6ef18b43fc2c4ea38a6f8750c5b 100644 > --- a/drivers/clk/qcom/gcc-sdx75.c > +++ b/drivers/clk/qcom/gcc-sdx75.c > @@ -1033,7 +1033,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = { > .name = "gcc_sdcc1_apps_clk_src", > .parent_data = gcc_parent_data_17, > .num_parents = ARRAY_SIZE(gcc_parent_data_17), > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > @@ -1057,7 +1057,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = { > .name = "gcc_sdcc2_apps_clk_src", > .parent_data = gcc_parent_data_18, > .num_parents = ARRAY_SIZE(gcc_parent_data_18), > - .ops = &clk_rcg2_floor_ops, > + .ops = &clk_rcg2_shared_floor_ops, > }, > }; > > Reviewed-by: Taniya Das -- Thanks, Taniya Das