From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A052C38A2D for ; Wed, 26 Oct 2022 14:32:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233731AbiJZOcc (ORCPT ); Wed, 26 Oct 2022 10:32:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233621AbiJZOc3 (ORCPT ); Wed, 26 Oct 2022 10:32:29 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4260BFBCDC for ; Wed, 26 Oct 2022 07:32:28 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id c8so10863905qvn.10 for ; Wed, 26 Oct 2022 07:32:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KsmuzRKKaUB6WHX3gUEBWTikPz5Qncyumloh3N+8ABA=; b=M5TMAE5sy7A990nf/BNmAXdCy+OZXswI3aLNx44wSvxa2Y60r0ELrzDm3S9EHsmdWV EHNqy45ATprsi1/E6kyz6IFjn7NnZaFYRy8LKapINhJ53iEZWSIXB5rPzJIlURwIZA1u I+PtqFrvah0JQNLCBCU3HhfsTgoz3GfUIyFGN02loxIwOMNaR9oNihA0A4wArJCc+FRw jXx1ie+3Ig8MvAevrS7w/qbEKHBp/N+mOWBs5bXxWuGgN/YJh+1w4/rYGJ1qdpk+g+bl TLY7Yx3dGGqfNZgu2uDO9QLVIQ0ItizjvZlcRoePz1Bz1MSQd3bn7xzgxo2Hh6/SCk1E IKzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KsmuzRKKaUB6WHX3gUEBWTikPz5Qncyumloh3N+8ABA=; b=pPQIHaDGo2/co5O3ic6RytVeoagRGAzQ2w4nTsbAClIQZOGYRDmTep/KYC4N2/FOW5 Y93cWgKKCd/j07JB3aaodlU6tcD9ODqAp2RCafOiCLmxElz059HhUyA344ohewOptyzf c19VJdm62/IkDoc4qvQdvPoNeazad9cyina2yReri268/t6MzE5OXSG2cZtqdLNmBiYj Zc1s8uBez6ZQeyO4WrxKcarw4BkB6L2DEV885rnBQFOgjiOxaSXomRNJYKzUW2KPKKyC OActg26mlFrvG6thte2khtDm2UmAiHfD8An7HY8yz1Sde/csgtawESDjr6c6yGBYuqR9 4o7Q== X-Gm-Message-State: ACrzQf0NQwZ4+4Ndzs0bQuuV38ilKi2hJs+yN6iTy23VOFny7BDWWT/2 arfg8LGusOTChAgrxrS69i03NA== X-Google-Smtp-Source: AMsMyM6qnlgeQVjneuzws0s2FvSzmE2JFy9e4/CGKLWbwVCK6VTNr/ZP7ZvzbpLEUl6qkHxFmQyavw== X-Received: by 2002:ad4:5ca7:0:b0:4bb:97ea:27b5 with SMTP id q7-20020ad45ca7000000b004bb97ea27b5mr1910488qvh.104.1666794747320; Wed, 26 Oct 2022 07:32:27 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id cj20-20020a05622a259400b0039cc665d60fsm3202443qtb.64.2022.10.26.07.32.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 07:32:26 -0700 (PDT) Message-ID: Date: Wed, 26 Oct 2022 10:32:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 1/1] dt-bindings: net: snps,dwmac: Document queue config subnodes Content-Language: en-US To: Sebastian Reichel Cc: Rob Herring , Krzysztof Kozlowski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexandre Torgue , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20221021171055.85888-1-sebastian.reichel@collabora.com> <761d6ae2-e779-2a4b-a735-960c716c3024@linaro.org> <20221024222850.5zq426cnn75twmvn@mercury.elektranox.org> <20221025141732.z65kswaptgeuz2cl@mercury.elektranox.org> From: Krzysztof Kozlowski In-Reply-To: <20221025141732.z65kswaptgeuz2cl@mercury.elektranox.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/10/2022 10:17, Sebastian Reichel wrote: > Hi, > > On Mon, Oct 24, 2022 at 07:28:29PM -0400, Krzysztof Kozlowski wrote: >> Old binding did not document "tx-queues-config". Old binding had >> "snps,mtl-tx-config" which was a phandle, so this is an ABI break of >> bindings. >> >> You are changing the binding - adding new properties. > > The new binding still has the phandle. The only thing I changed is > explicitly allowing the referenced node to be a subnode of the dwmac > node. This is 100% compatible, since the binding does not specify > where the referenced node should be. Only the example suggested it > could be next to the ethernet node. But changing any properties in > the config node means a ABI break requiring code changes. > > Note, that right now 4/7 devicetrees with snps,mtl-tx-config already > follow the scheme I documented. The other 3 have the queue config > below the root node like the current example: > > has the queues config in /: > * arch/arm/boot/dts/artpec6.dtsi > * arch/arm64/boot/dts/mediatek/mt2712e.dtsi > * arch/arm64/boot/dts/qcom/sa8155p-adp.dts > > has the queues config in the ethernet node: > * arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > * arch/arm64/boot/dts/freescale/imx8mp-evk.dts > * arch/arm64/boot/dts/rockchip/rk3568.dtsi > * arch/arm64/boot/dts/rockchip/rk356x.dtsi > > After my change both are considered valid. Anyways I'm doing this > for rk3588 and planned to follow the subnode style. But if I have > to fully fix this mess I will just put the queue config to the > root node instead and let somebody else figure this out. Yeah, let it be. Best regards, Krzysztof