From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbdJPKoT (ORCPT ); Mon, 16 Oct 2017 06:44:19 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:52374 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbdJPKoQ (ORCPT ); Mon, 16 Oct 2017 06:44:16 -0400 X-AuditID: cbfec7f2-f793b6d000003243-8b-59e48d7c32fb MIME-version: 1.0 Content-type: text/plain; charset="utf-8" Subject: Re: [RESEND PATCH v2 4/5] drm/bridge/analogix: Do not use device's drvdata To: Jeffy Chen , linux-kernel@vger.kernel.org Cc: dmitry.torokhov@gmail.com, heiko@sntech.de, briannorris@chromium.org, rjw@rjwysocki.net, dianders@chromium.org, tfiga@chromium.org, broonie@kernel.org, seanpaul@chromium.org, dri-devel@lists.freedesktop.org, Caesar Wang , David Airlie , Laurent Pinchart , linux-samsung-soc@vger.kernel.org, Seung-Woo Kim , Inki Dae , linux-rockchip@lists.infradead.org, Kyungmin Park , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, Kukjin Kim , Tomeu Vizoso , zain wang , Archit Taneja , Joonyoung Shim , Shawn Guo , Marek Szyprowski , Mark Yao , Jingoo Han From: Andrzej Hajda Message-id: Date: Mon, 16 Oct 2017 12:44:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 In-reply-to: <20171016100640.26575-5-jeffy.chen@rock-chips.com> Content-transfer-encoding: 8bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0iTYRTHed670uRtLj1UJAyiG5lSwkM3Cwoeyqg+FM0vNfLFIrXYtKuR Wm6meUmzdElEqZmiyds0Cyp10cya0zRNaGppbV3MUrsRas7XwG+/w/+c/3POn0eg1fe5ucLB uHjJEKeP0XK+TO3TPy3LEzMHdCFycxDObHlG4ZS0QRbL34dYnP92gMOO0gYO2254EO74McTh iXefWZzbm8PgX68dHC4bLeSxp6eNwdn9n2nsdFbz2JHyhcfnLxbzWO7vZHH7gyIOD/dN0LjA +YjClU9cPK67VE/hF89fsthV7UDYYw3EBXkfOTySOs7hrMqXHDafLaWwqStgwwJyNamNIe1Z mRSpcxUjct/i4snVtEKWyOXnOXLvZx9LejPsFLlbfIZYX5kZMmZ5zJAsazki9zqv0WREXrDD L9J3bZQUc/CoZFixfp/vAWfz9iN93PHf2d1sEmpg05EggLgK3EXH0pHPJAZAa88dLh35Cmqx BEHvqxJaKUYQOJ7kI6VrFbz/W8EqQimCyvpR1iuoxNnwO6+H8TItLgHPaO4Uq8UPCDIbDnnZ X9wFg+aPU0YakYCzw0Z5jWjxEQ99yQO0V+Amh8fudnOK6Xqo73RTXmbEhWC67J4ynSPugVb5 D+U9wUcMh8EHSHk3CBo63NM7BMLZ1G5GWdoqwK3qMIU3wUROFa2wP3yyW3mF50N7Xgbj3QfE DATD2U28UlxCMP6tYHpiDdjsbazygh/k1l6hlRxVkGZSKy0ECv+WT6e1Eb7nf6GUtOwIKh6O MzkoyDIjMMuMwCwzjrDMOOI6YsqRRkowxkZLxpXBRn2sMSEuOnj/4VgZTX7o5+P24Tr0o2l1 IxIFpJ2lKmvp16lZ/VHjidhGBAKt1aiCUwZ0alWU/sRJyXB4ryEhRjI2onkCow1UrYs06dRi tD5eOiRJRyTDf5USfOYmocU1TdKy1DpXKPp2YZdb2HZh55uSonPytcq3mu0B+afFlTtv+qyb V/N0y8Q+uSQkOXQsT6jYNETqE+PnO2ojTcm2VtKFbnoC/NJsX8P826pu/4wIVyWatxV8KtI0 88nHT32IKIvuDtn8XjrTtWjjDqbHfSPM7dkth+siiDloK9EyxgP60KW0waj/B4tIRJHMAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGe89tx+XsOG8vFhYDCwM1teAFzQyCDhYUhngLbeVBJTdlx0nW h5bmNaaWGjpDsoaIw5xT06TMS2R5W17TD05NS8UbZaYSak2N/PaD53n+z/PhT+NiNelIx8gT OIVcGiuhhETnZvug6x31VMiJ56UuSN3zEUPJGQskMnxfIlHBxBSFustaKNT2bAaggZUlCm19 mSPRo7FcAq0Od1Oo/GeRAM2YegmUMzmHI6NRL0DdyfMClPlQK0CGySES9Tc+odCP8S0cFRqb MFT5blSAGvKbMdTV2UeiUX03QDO1Dqgwb5ZCy6mbFMqu7KNQekoZhtI+2/s5scWqXoLtz1Zj bMOoFrCvNKMCtjijiGQNFZkUW/9rnGTHHrRjbI32Lls7mE6wG5q3BJtdWwHY+qESnF02OF22 ChX6RHKxMYmcwt33mjDa2HEpfpy6tZYzQqpAC5kFLGjInIRff+t22R5+MlVRWUBIixktgOsb esosiBhruJZnIrIATePMMZifL9vxfAPQlDkpMHtsmEC4kD4LzGzLsNA40IaZTTjTJIA6dSa2 k2gHcObFwHYdxbjAjZqR3QZf2Dw0jZmZYJxh2uPp7TY7Jhjqqw+Y0YI5Axcat+/jzGHYMmB2 mNkBpqSOELnAWrNnqub/VM2ehGZP4ikgKoAtp+RlUTLe042XynilPMrtRpzMAP4+ycv367UN IGvxSitgaCCxFO3rnQwRk9JEPknWCiCNS2xFbslTIWJRpDTpNqeIi1AoYzm+FRykCYmDSP1a FyJmoqQJ3E2Oi+cU/1SMtnBUAf/BnmHe32Nz6nSpk32VPrl6eP5cgOtZO92R3EA/5cSpC4tr dlGgoNpLtZJTEh7YVqcsD7teWODcIV/sygjMkAXlePkAO+9Nv3nReb+6/jeicF63NZcn/2B1 9JAQmCJs9rtHhtUHlNhuOKr68u/f81RdDL66eqS80DWU9rYMcpYQfLTU4ziu4KV/AIhL88wg AwAA X-CMS-MailID: 20171016104411eucas1p1bc8ddf45788f5f25bc396037af17a9a9 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-CMS-RootMailID: 20171016100746epcas2p436f3573bcb862275aea1869aabe4ad17 X-RootMTR: 20171016100746epcas2p436f3573bcb862275aea1869aabe4ad17 References: <20171016100640.26575-1-jeffy.chen@rock-chips.com> <20171016100640.26575-5-jeffy.chen@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.10.2017 12:06, Jeffy Chen wrote: > From: Tomasz Figa > > The driver that instantiates the bridge should own the drvdata, as all > driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also > owned by its driver struct. Moreover, storing two different pointer > types in driver data depending on driver initialization status is barely > a good practice and in fact has led to many bugs in this driver. > > Let's clean up this mess and change Analogix entry points to simply > accept some opaque struct pointer, adjusting their users at the same > time to avoid breaking the compilation. > > Signed-off-by: Tomasz Figa > Signed-off-by: Jeffy Chen Thanks for making it a bit saner. Reviewed-by: Andrzej Hajda  -- Regards Andrzej