From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mahesh Rao <mahesh.rao@intel.com>,
Moritz Fischer <mdf@kernel.org>, Xu Yilun <yilun.xu@intel.com>,
Tom Rix <trix@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Wu Hao <hao.wu@intel.com>, Ho Yin <adrian.ho.yin.ng@altera.com>,
Niravkumar L Rabara <nirav.rabara@altera.com>
Cc: linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Mahesh Rao <mahesh.rao@altera.com>
Subject: Re: [PATCH v2 3/3] firmware: stratix10-svc: Add of_platform_default_populate()
Date: Fri, 31 Jan 2025 11:26:18 +0100 [thread overview]
Message-ID: <be1a45c8-f595-4b66-8792-1bc255216bfa@kernel.org> (raw)
In-Reply-To: <20250131-socfpga_sip_svc_misc-v2-3-eeed4ebc35f9@intel.com>
On 31/01/2025 11:17, Mahesh Rao wrote:
>
> -err_unregister_dev:
> +err_unregister_fcs_dev:
> + platform_device_unregister(svc->intel_svc_fcs);
> +err_unregister_rsu_dev:
> platform_device_unregister(svc->stratix10_svc_rsu);
> err_free_kfifo:
> kfifo_free(&controller->svc_fifo);
> @@ -1256,6 +1262,8 @@ static void stratix10_svc_drv_remove(struct platform_device *pdev)
> struct stratix10_svc *svc = dev_get_drvdata(&pdev->dev);
> struct stratix10_svc_controller *ctrl = platform_get_drvdata(pdev);
>
> + of_platform_depopulate(ctrl->dev);
I thought you will use devm for this, but well...
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2025-01-31 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 10:17 [PATCH v2 0/3] stratix10: miscellaneous changes and fix for child driver probing Mahesh Rao
2025-01-31 10:17 ` [PATCH v2 1/3] dt-bindings: fpga: stratix10: Convert to json-schema Mahesh Rao
2025-01-31 15:22 ` Rob Herring (Arm)
2025-01-31 10:17 ` [PATCH v2 2/3] dt-bindings: firmware: " Mahesh Rao
2025-01-31 15:26 ` Rob Herring
2025-02-03 10:42 ` Mahesh Rao
2025-02-03 11:15 ` Krzysztof Kozlowski
2025-02-03 11:22 ` Mahesh Rao
2025-01-31 10:17 ` [PATCH v2 3/3] firmware: stratix10-svc: Add of_platform_default_populate() Mahesh Rao
2025-01-31 10:26 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1a45c8-f595-4b66-8792-1bc255216bfa@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.ho.yin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=hao.wu@intel.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh.rao@altera.com \
--cc=mahesh.rao@intel.com \
--cc=mdf@kernel.org \
--cc=nirav.rabara@altera.com \
--cc=robh@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®