From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8098CC433F5 for ; Tue, 26 Oct 2021 16:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EB9B60527 for ; Tue, 26 Oct 2021 16:12:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237241AbhJZQOr (ORCPT ); Tue, 26 Oct 2021 12:14:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27829 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235340AbhJZQOp (ORCPT ); Tue, 26 Oct 2021 12:14:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635264741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=HXeh27CV8hJRaETDK6hQOpnP45k3CVN3SmEZGClNq7UYeHDti1sMQE40Q9KP2PP6tyaQ2I orJVQXxUk8U1XN2n6u+a3epp9C/dCkhT5MuzOp8x/Js6W5Za41+LrdIs+yGwZJjYq0362v 79f1/BmEa6EFyJMmnSf2RTCKnOJQnls= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-_e0-_2_BMsivapR_nWGHQw-1; Tue, 26 Oct 2021 12:12:19 -0400 X-MC-Unique: _e0-_2_BMsivapR_nWGHQw-1 Received: by mail-ed1-f69.google.com with SMTP id f21-20020a0564021e9500b003dd77985601so3372020edf.9 for ; Tue, 26 Oct 2021 09:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=y/8qPSuga2nSdD4ObnPRjMzoPwBrPBTCysCx0s1aic4=; b=2lsXTs2EaHPow8FanpB+/Y287FZBXp1wU7ORVSJblo+Cps5Nh+9b04gHQ3TF2Wzw+O 14qpj5UQETdUpiSbWOoEDdS/VqXj9s6U1l0NW5VlSzEah01ZHUt6x85BiGfJfihbd+gV JH3eAuidRJircaeuKH+QsjoNfT9JrmL9SXrwWvM9lqaga1H7pKR4en8meHa4ZyvdTcCt zv/ti2Zjlh4V38aqAIPE70IdyU3lQ2tAU0pXTTvt0EnGnp/hby3QBcPe65cE+9rLuZcK i44F29gQ5VYkVw8g2GT/FMOkWa2BQqO2QLMDZv6SvCsgy57IJvwh6m4oWk1tlg59ffu6 zl0A== X-Gm-Message-State: AOAM531o6RALE9mu2MxBcEGSTvLR2D6/ui8I16UBKyCjJES4b7BMqXPP vntw+fkA67NRSnJ/IeCwzfAwMcXIU+8eSGoXhzCOajPWZ2/3XpMzuuMcE0h4ZC2NPJKKvmpBVL5 iSyh7apsbLq//mQ0+OzdYIdyT X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991757eds.371.1635264738786; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwASeQAxYa4SVxx7fzZJcK2OTnFNOTNNHLf+PErJyPRemx/Rf7LwxYWqAfn33dB1Qf24eGGDw== X-Received: by 2002:aa7:da84:: with SMTP id q4mr36991714eds.371.1635264738510; Tue, 26 Oct 2021 09:12:18 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id n1sm4753815edf.45.2021.10.26.09.12.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Oct 2021 09:12:17 -0700 (PDT) Message-ID: Date: Tue, 26 Oct 2021 18:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v2 10/43] KVM: arm64: Move vGIC v4 handling for WFI out arch callback hook Content-Language: en-US To: Marc Zyngier Cc: Sean Christopherson , Huacai Chen , Aleksandar Markovic , Paul Mackerras , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , Cornelia Huck , Claudio Imbrenda , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , Oliver Upton , Jing Zhang References: <20211009021236.4122790-1-seanjc@google.com> <20211009021236.4122790-11-seanjc@google.com> <9236e715-c471-e1c8-6117-6f37b908a6bd@redhat.com> <875ytjbxpq.wl-maz@kernel.org> From: Paolo Bonzini In-Reply-To: <875ytjbxpq.wl-maz@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/21 17:41, Marc Zyngier wrote: >> This needs a word on why kvm_psci_vcpu_suspend does not need the >> hooks. Or it needs to be changed to also use kvm_vcpu_wfi in the PSCI >> code, I don't know. >> >> Marc, can you review and/or advise? > I was looking at that over the weekend, and that's a pre-existing > bug. I would have addressed it independently, but it looks like you > already have queued the patch. I have "queued" it, but that's just my queue - it's not on kernel.org and it's not going to be in 5.16, at least not in the first batch. There's plenty of time for me to rebase on top of a fix, if you want to send the fix through your kvm-arm pull request. Just Cc me so that I understand what's going on. Thanks, Paolo