From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932263AbcEKU2Z (ORCPT ); Wed, 11 May 2016 16:28:25 -0400 Received: from mail-am1on0105.outbound.protection.outlook.com ([157.56.112.105]:39936 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751632AbcEKU2X (ORCPT ); Wed, 11 May 2016 16:28:23 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=axentia.se; Subject: Re: [PATCH] ASoC: MAX9860: new driver To: Mark Brown References: <1462892797-1147-1-git-send-email-peda@axentia.se> <20160511152950.GL6261@sirena.org.uk> CC: , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , , From: Peter Rosin Message-ID: Date: Wed, 11 May 2016 22:28:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160511152950.GL6261@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [217.210.101.82] X-ClientProxiedBy: HE1PR05CA0029.eurprd05.prod.outlook.com (10.162.181.39) To HE1PR02MB1305.eurprd02.prod.outlook.com (10.169.115.151) X-MS-Office365-Filtering-Correlation-Id: 30be2746-da06-4bec-d411-08d379dac9e5 X-Microsoft-Exchange-Diagnostics: 1;HE1PR02MB1305;2:X2QLY3kr1YaiEnaRO7efN20Q1tP7f94JqtDEWISWVZcB6Nbr/fegOtujnjrKq6KWW8oXUXgDvXnng3QqgepbVySOttehBAdXT67GWkJUVSGycu8jIplQH7ecNyPuXISXUlEqq4B79itH2hIwYdvsdiS0DfuC/LTTD2yx6aCZPBgsaFOCV4i1v8IKbXblljmi;3:IyZGBz9PFCBUPfaM/TCxz0tXekkTmlfpXOymqQ/30N/voO0h+KSwJYpgLTIqpvr6oG29fQImX4DYn8bjmtkO1JJ3rzC76If8nUvB7lciUV5XsLPbIpFj3x69IradgPjp X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR02MB1305; X-Microsoft-Exchange-Diagnostics: 1;HE1PR02MB1305;25:N091qVRfG9VOvOIFsoOv5Uy/nexh0eG9iY4XqJm+uae1e0l+JsFOgDAjNlidjpCTuanpXMyzJfY64sR0+NHH+1ESnDhYGaEPO+o2Hk/3IOhOC7tlO5VL9kG8LndE5vBgIFgAE/X7FGg7C5ymu1IjXCFCe6XdQqNm5HpXXFrx/iplH3uG1rI4udPUetJj6+1KyQw/ewoXRSJBuGP+G631lxnQL3pUljZ8hrvtnyAZSyb6ns4NyS+JERYtQDZ4gNVQgxtNoyhSL48KP5CAigzJUYGTEABSbvWOK2wkLg+oj2HRIsz78ZsMS87sY3SH2H2Bci2IP7E+IORyOEdfXbpdyBfGyJ0GkGOz32spSl+rIlXi7QvNfJ5CPMqyp303sSNCXfUJG2I7b1pp6g7CXvIalVOyYxf/GiRw7gYbwxZIzng3VLO67HpaHIItfxTM4mLHUoJ/JctERdvsV/ND0xbnukpUf/ETpvFqX61dgQ9nd3VDCwHG4f1mwoed1zLAgyzq91FHW+t8Ezw1gXbyPDDA38CNghhQraAvVR6q07Pp6FKSevRdeo2HmG8HYdJZpNcxUU5berDjQ7g1kxPzm4grCnVuRTk1pIQJFwBDMCDFezoUL5JnOVGRe4adecm+LPmRaHSZNLfo4jpJUhfpBlx5xi5sQS8QGQzsP0nfAbOeEJM2Ex6emaUFh3zuxy9mOFHkLSZQxuy6ZT6IMMyAMOEZ16nXgLHXStUih1Vp1CsqUpA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:HE1PR02MB1305;BCL:0;PCL:0;RULEID:;SRVR:HE1PR02MB1305; X-Microsoft-Exchange-Diagnostics: 1;HE1PR02MB1305;4:opErXORtZzD4T5iPdRpsidwg4I2Ek0Vi1CNaLnzBv08Od4w4oX/Ii0rgvyYEt9foi1Rc5eo9uhrp2dtSWvVPJ9y0jW9iitWvt5xUDDbBwO6CDvCatxGY4YbxzfYDyWluUaqPwZOzopsalN5CHQmMCd7MNxaLj1IaqLNvFdPtqKXr/WpqIWXwrkdDwTcR/xdB1MHD05SEIMctqHZ+CppxpiX71Cz559aL3ANgH6ZgT921mVJqURWYUXxABkHrY70mB6IChPfpOAL3HCYK9iLbIriMagBWUnV2HKvQOux/wilfkOYyUWWcObJ9EKEhqAkuzlGGAOJUo2jr45cRdKVI+ETpd5TOW49Z2YWxS+pel0YKJpzv6KFnEwo+KkCyb8IUGOsPAh6YHJ2un7lo1sTRyL056CjzETHvSgFk4t7Hqsk= X-Forefront-PRVS: 0939529DE2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(377424004)(24454002)(586003)(3846002)(31696002)(74482002)(50986999)(5008740100001)(76176999)(54356999)(5004730100002)(4326007)(230700001)(6116002)(42186005)(2950100001)(31686004)(50466002)(23746002)(189998001)(36756003)(110136002)(86362001)(77096005)(33646002)(47776003)(92566002)(65956001)(66066001)(117156001)(2906002)(83506001)(81166006)(65826006)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR02MB1305;H:[192.168.0.125];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR02MB1305;23:qqSVSwDE3bjsT5iQ9GjU5S1wLJ/Xevg88t8KL?= =?Windows-1252?Q?ctoIJcyIDtd02Y1+imMTTvEQoXGiZJn4ml0A3Fk4Qu98IqPjE2tW9+J6?= =?Windows-1252?Q?4ueuEsmhmz/iOZhc8C99Ecw3Qv2GVW2u1CEX6UHyDvsinmLEbag+jUcm?= =?Windows-1252?Q?HqrJIGov4RGDtLQ7TjQ2kEeWV6paZA9A+ctcw88yz/Nz0Qp8fQFPAgTW?= =?Windows-1252?Q?XwJwuhVk7jvzO1EWpM3cYJro7Jih3LYTnZfUOFHMmTnFkXGXpc/rGjBJ?= =?Windows-1252?Q?y4Tc9CoQaCQHnJxk1t3Xv3wKByyXPHeSZfzmDVqW9DuV8pVwHZFL2O1E?= =?Windows-1252?Q?w3NgD18x8IRENM+co2f5qIi7wi/dtVNPqq+VlqDnCKQ1Kmj90gHuTaIF?= =?Windows-1252?Q?2TRuaPGTnzjM6LnyBwgjMGppmdbu3U91Cc/K7TbUWkGoeFfJSOiMzlci?= =?Windows-1252?Q?/N+yx/mDpGOp7UzlNvNG09cAaoipbdRTmmd/jAWq4g8Nt75+5bQ3nuTc?= =?Windows-1252?Q?3LAOArk9Go/QHJTGF6fivqhYwEMaS3wN2XicMqXVHQQF2nVjxRhISUYG?= =?Windows-1252?Q?Edp1EW/PcHqS+Tv+iKY51QBs6M6Xp0G+BofWUidVL/I5bSykIApqICCQ?= =?Windows-1252?Q?zgZpbljHaJKaCXii7X9BIdyKpgkeFw3QdHlWAA877N0Ph7zsLBFCIYZx?= =?Windows-1252?Q?gaPdjfqCCohDbl+FRvs1IlLkWe54sjm7YgDAOr3JMpxXwgnLrTWd0RdA?= =?Windows-1252?Q?MlKedhNAxtqHTFg3TJSOKt6mmXM0MiglfB40rDGd+wxCwvMNNfy4eLqK?= =?Windows-1252?Q?KRzciwMJ2qzqwB2PEbq1W7E7M+YmVRiX4xK1LMgjMJrPIRy+KdZhXfpm?= =?Windows-1252?Q?Y44uvwl2Eoj0adyLmJZUC9N0ME3dEKgJyVV7IkzJFK5Q2O45kgFDRv3Y?= =?Windows-1252?Q?F9ljhpz5cOVWA59EqcmiMv1uGphWEGrNlhL+DF6cLC8hHT0PwJMkeZ1P?= =?Windows-1252?Q?ETW/oB5bkq7a+mCYFS7VfueDJe3iTOtWNlfbmxt5YAeYLjBDRA614OOA?= =?Windows-1252?Q?EU952x1DgtDCbckgjDyAU41m8m19Zz9NkJE?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR02MB1305;5:K9ddLTuiMEnOeFOPRoTC/zZup42CdVzHOOr7YiGrwaLc1Q07Ba7a9rwqSInD143smRuBT64FssUajAlnC+mI0qj8yt/eB6uNbjPV3Ho3XvxBoESpYEZen5QPAGzYNueNNcAqNUQoiGd2/BeyAV+/1g==;24:kB1XdzQwFQQJm2GvB0iWRoXqorfdCLeagujr8Yy3MQ2Xa2z/Rw17OHDCR/HMoTbM45h/GmJ7tiala71a/WDmTWL9WJhHh38vuqF0ROhfwc8=;7:FLI5o8POWC1xxP+c4cgvqV7XOAbTs2QITQbcSUJ1DtLECTfapNAWPEZ18030mZiNrFZtqoSP+jSROYi27R4g+Mv2ul+a1maxLsI3ryHWokhm8QzkJ2IEbY4mAdkY+0fQZZnRXiN1oievP+cNwI+cP6KGoc0XatZmfky3sCRwxG8L/0xN8d/Sh/uV2C3oUEXF SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 May 2016 20:28:17.7891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR02MB1305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-05-11 17:29, Mark Brown wrote: > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote: > >> + if (master) { >> + switch (max9860->pclk_rate) { >> + case 12000000: >> + sysclk = MAX9860_FREQ_12MHZ; >> + break; >> + case 13000000: >> + sysclk = MAX9860_FREQ_13MHZ; >> + break; >> + case 19200000: >> + sysclk = MAX9860_FREQ_19_2MHZ; >> + break; >> + } > > What if we have another PCLK rate? In that case the sysclk variable will remain cleared (0) and the code that follows will trigger the PLL section with the N divider for clock master mode (that mode is always used in clock slave mode). >> +#ifdef CONFIG_PM >> +static int max9860_suspend(struct device *dev) >> +{ >> + struct max9860_priv *max9860 = dev_get_drvdata(dev); >> + int ret; >> + >> + ret = regmap_update_bits(max9860->regmap, MAX9860_SYSCLK, >> + MAX9860_PSCLK, MAX9860_PSCLK_OFF); >> + if (ret) { >> + dev_err(dev, "Failed to disable clock: %d\n", ret); >> + return ret; >> + } >> + >> + return 0; >> +} >> + >> +static int max9860_resume(struct device *dev) >> +{ >> + struct max9860_priv *max9860 = dev_get_drvdata(dev); >> + int ret; >> + >> + regcache_cache_only(max9860->regmap, false); >> + ret = regcache_sync(max9860->regmap); > > We didn't go into cache only mode on suspend? I'd also expect to see > the regulators disabled over suspend and some system PM ops. Ooops, that is a leftover, and I think it can be removed. However, your comment suggests that I have misunderstood the workings of SND_SOC_DAPM_REGULATOR_SUPPLY. I thought dapm would take care of the regulators (and the clocks for SND_SOC_DAPM_CLOCK_SUPPLY) so that disabling regulators over suspend was handled by the asoc core? >> +static int max9860_mclk_rate(struct device *dev, unsigned long *mclk_rate) >> +{ >> + struct clk *mclk = clk_get(dev, "mclk"); > > Request resources on probe, not at some random point in driver > execution. That will mean probe deferral works properly and that we > don't get broken devices instantiated in userspace. This function is only called during probe, but yes, it needs to do probe deferral. I'll fix that for the next version. >> + ret = clk_prepare_enable(mclk); >> + if (ret) { >> + dev_err(dev, "Failed to enable MCLK: %d\n", ret); >> + clk_put(mclk); >> + return ret; >> + } >> + >> + *mclk_rate = clk_get_rate(mclk); >> + >> + clk_disable_unprepare(mclk); > > This is definitely confused too. Enabling the clock to read the > programmed frequency is at best odd, and obviously if we do get the rate > this will ensure that MCLK is disabled which probably isn't ideal. This is the same situation as for the regulators, I thought dapm handled it and would prep/enable clocks when they were needed? >> +err_pm: >> + pm_runtime_disable(dev); >> + return ret; >> +} >> +EXPORT_SYMBOL_GPL(max9860_probe); > > I've no idea why this is exported... Me neither. I'll kill that export for the next round. I'll wait for further input on the regulator/clock interaction with dapm before I send a v2. Thanks, Peter