From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750923AbdFOE00 (ORCPT ); Thu, 15 Jun 2017 00:26:26 -0400 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:45343 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbdFOE0Y (ORCPT ); Thu, 15 Jun 2017 00:26:24 -0400 X-ME-Helo: [192.168.1.23] X-ME-Date: Thu, 15 Jun 2017 06:26:22 +0200 X-ME-IP: 92.140.237.203 Subject: Re: [PATCH] sm501fb: Silence a coccinelle script warning. To: Bartlomiej Zolnierkiewicz References: <20170508061116.31471-1-christophe.jaillet@wanadoo.fr> <3551083.sIQ6JeN0q9@amdc3058> Cc: khoroshilov@ispras.ru, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel.janitors,gmane.linux.kernel From: Christophe JAILLET Message-ID: Date: Thu, 15 Jun 2017 06:26:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3551083.sIQ6JeN0q9@amdc3058> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 14/06/2017 à 12:54, Bartlomiej Zolnierkiewicz a écrit : > Hi, > > On Monday, May 08, 2017 08:11:16 AM Christophe JAILLET wrote: >> According to surrounding goto, it is likely that 'goto err_probed_panel' is >> expected here. >> This change is just done in order to silence some coccinelle scripts >> which try to detect wrongly ordered goto. >> >> If 'info->fb[HEAD_PANEL]' and' 'info->fb[HEAD_CRT]' are both NULL, this >> means that no 'framebuffer_alloc' has been performed, so 'goto err_alloc' >> looks fine. >> Anyway, it is also harmless in this case to call 'framebuffer_release'. >> The code looks more straight forward. >> >> Signed-off-by: Christophe JAILLET > It seems that the code for supporting only selected framebuffers > (only HEAD_PANEL fb or only HEAD_CRT fb) is broken anyway as at least > the suspend/resume support assumes that both framebuffers are always > present. Also all sm501fb driver users always try try to initialize > both framebuffers. Therefore I would prefer the removal of non-working > individual framebuffers support (the code that your patch modifies > would be removed as well). Could you please look into it? Thx for the feedback, but no, I won't be able to go further. I don't know the code enough in this area. Sorry. Best regards, CJ