From: Steev Klimaszewski <steev@kali.org>
To: Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Rob Clark <robdclark@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/devfreq: Fix OPP refcnt leak
Date: Thu, 4 Nov 2021 23:32:51 -0500 [thread overview]
Message-ID: <be2222e2-8fec-84f9-bbcf-bf639a1a63bd@kali.org> (raw)
In-Reply-To: <20211104222840.781314-1-robdclark@gmail.com>
On 11/4/21 5:28 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index d32b729b4616..9bf8600b6eea 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -20,8 +20,6 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> struct msm_gpu *gpu = dev_to_gpu(dev);
> struct dev_pm_opp *opp;
>
> - opp = devfreq_recommended_opp(dev, freq, flags);
> -
> /*
> * If the GPU is idle, devfreq is not aware, so just ignore
> * it's requests
> @@ -31,6 +29,8 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> return 0;
> }
>
> + opp = devfreq_recommended_opp(dev, freq, flags);
> +
> if (IS_ERR(opp))
> return PTR_ERR(opp);
>
Testing this here on the Lenovo Yoga C630, and I'm starting to see in my
dmesg output
[ 36.337061] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 36.388122] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 36.810941] wcd934x-codec wcd934x-codec.3.auto: Port Closed RX port
1, value 4
[ 36.811914] wcd934x-codec wcd934x-codec.3.auto: Port Closed RX port
2, value 4
[ 198.794946] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 198.845698] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 502.285421] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 502.339427] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 503.361469] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 503.412757] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 503.871480] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 503.922712] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 503.974474] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 504.025501] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 505.923563] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 505.974513] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 510.313052] usb 3-1.3: USB disconnect, device number 4
[ 519.677148] usb 3-1.3: new high-speed USB device number 5 using xhci-hcd
[ 519.793394] usb 3-1.3: New USB device found, idVendor=5986,
idProduct=2115, bcdDevice=54.20
[ 519.793441] usb 3-1.3: New USB device strings: Mfr=1, Product=2,
SerialNumber=0
[ 519.793472] usb 3-1.3: Product: Integrated Camera
[ 519.793495] usb 3-1.3: Manufacturer: SunplusIT Inc
[ 519.861020] usb 3-1.3: Found UVC 1.00 device Integrated Camera
(5986:2115)
[ 519.892879] input: Integrated Camera: Integrated C as
/devices/platform/soc@0/a8f8800.usb/a800000.dwc3/xhci-hcd.1.auto/usb3/3-1/3-1.3/3-1.3:1.0/input/input27
[ 520.283839] devfreq 5000000.gpu: Couldn't update frequency transition
information.
[ 520.335854] devfreq 5000000.gpu: Couldn't update frequency transition
information.
Is this intended?
next prev parent reply other threads:[~2021-11-05 4:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 22:28 Rob Clark
2021-11-05 0:11 ` Doug Anderson
2021-11-05 4:32 ` Steev Klimaszewski [this message]
2021-11-05 15:29 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be2222e2-8fec-84f9-bbcf-bf639a1a63bd@kali.org \
--to=steev@kali.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®