From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8EDE3E3150 for ; Fri, 12 Jun 2026 17:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781286006; cv=none; b=Fi9TkE3baOokvQE4UpuKjZomycznYR+Sx3ajBH+WYXRFlfbw04EWz0s4ZQFHa95oNx/kAFselXayJHscS6EEJu320a7FaOOeVSXiqPWSSNDPpIn3JmwopKLREfxi1LSr1TmY4NoIcxJslO7xVFQrcDB2267kdR0Khz9vm62cbdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781286006; c=relaxed/simple; bh=XnsAVp/N05Bd286sY4AZGdYjANXS96ZvH0it40jhlpc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZxGoD0oHKiRIbwRG+FedOQHziepnSQfN3c8LAXo0oLbn8XD4Y6nbXuMHG0H5zeGPzNvm9q183N3EpCqB8cSZ33Wh9V9gkGNEq9eTj36nDErYKu008jhcuZA2eoC0ACDrJYHESfoEnDpmU05/73hL6sF8oYs7r5l6GEsZD3GvbD0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Prx1/PYH; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Prx1/PYH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1781286003; bh=XnsAVp/N05Bd286sY4AZGdYjANXS96ZvH0it40jhlpc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Prx1/PYH35axjUWlaKAj58+qPlDJxPz2Syb01q+23nOylMbl0JoWQ++KWFCER7kwo ik5tWwOsAC5+rfZHlxGz/mEH2oWDA+PcrHt7KoThJi5kTFbpvYoMgsw3odq4EgvVyM TYv0FqL3CDgdAmNfvYg9wC4Gl9OX3rkVx46iZU9cGOSrrIKOvonymjRw2j83SD+M19 TsLtWxxc68vkuJEdTUR48BdNWOBDKwFfYWO/oZienr1yTbop/+IprMYIVbXVZ+Ovuv DcWClwpEU9sZlXLNSiPVN4NK1s+eMZ1PjFtp3by4xi/wTjAzfwnVaZM5UG/xvLHWT7 2zsMYU5CkrAIQ== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 41E7017E040C; Fri, 12 Jun 2026 19:40:02 +0200 (CEST) Message-ID: Date: Fri, 12 Jun 2026 20:40:01 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 01/30] drm/fb-helper: Remove unused local variable in hotplug_event() To: Thomas Zimmermann , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Daniel Stone , Dave Stevenson , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org References: <20260602-dw-hdmi-qp-scramb-v7-0-445eb54ee1ed@collabora.com> <20260602-dw-hdmi-qp-scramb-v7-1-445eb54ee1ed@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Thomas, On 6/12/26 4:46 PM, Thomas Zimmermann wrote: > > > Am 02.06.26 um 00:44 schrieb Cristian Ciocaltea: >> Remove the 'err' local variable in drm_fb_helper_hotplug_event() which >> only stores a return value that is never used beyond the immediate >> return statement. This simplifies the code without behavior changes. >> >> Signed-off-by: Cristian Ciocaltea > > Reviewed-by: Thomas Zimmermann > > But why is this patch hidden in this series? It has nothing to do with HDMI support. I came across this while investigating some issues with the HPD-related changes in the series (was part of the call path). Should I send the patch separately, or can it be picked up directly? Thanks for reviewing, Cristian