mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Magnus Lynch <maglyx@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: venkatesh.pallipadi@intel.com, vojtech@suse.cz,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hpet: factor timer allocate from open
Date: Wed, 3 Mar 2010 18:59:31 -0800	[thread overview]
Message-ID: <be233a491003031859s7d409e11k599a319ce04b7696@mail.gmail.com> (raw)
In-Reply-To: <4B8B901E.4050302@ladisch.de>

On Mon, Mar 1, 2010 at 1:59 AM, Clemens Ladisch <clemens@ladisch.de> wrote:
>> @@ -438,6 +469,17 @@ hpet_ioctl(struct inode *inode, struct file *file, unsigned int cmd,
>>  {
>>        struct hpet_dev *devp;
>>
>> +       switch (cmd) {
>> +       case HPET_INFO:
>> +               break;
>> +       default:
>> +               {
>> +                       int r = hpet_alloc_timer(file);
>
> Applications might want to use HPET_INFO to find out which timer they
> got, so I think the driver cannot avoid allocating a timer in this case.

Oh, I missed commenting this in my first reply. I chose to make
HPET_INFO specify timer -1 in case a timer isn't currently allocated.
You think there are extant cases of programs depending on open then
immediate HPET_INFO having a timer allocated? Seems obscure to me. If
so I can change that. I did add the explicit form of allocating timers
to accomodate such a case hypothetically (open, allocate timer, get
info).

  parent reply	other threads:[~2010-03-04  2:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01  5:30 Magnus Lynch
2010-03-01  9:59 ` Clemens Ladisch
2010-03-01 20:24   ` Magnus Lynch
2010-03-01 20:59     ` john stultz
2010-03-03  9:07       ` Magnus Lynch
2010-03-03 16:26         ` john stultz
2010-03-10  2:47           ` Magnus Lynch
2010-03-04  2:59   ` Magnus Lynch [this message]
2010-03-04  8:43     ` Clemens Ladisch
2010-03-08  0:04       ` Magnus Lynch
2010-03-16 16:01         ` Clemens Ladisch
2010-03-18 19:11         ` Andrew Morton
2010-03-19  4:06           ` Magnus Lynch
2010-03-22 22:21             ` Andrew Morton
2010-03-23  2:02               ` Magnus Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be233a491003031859s7d409e11k599a319ce04b7696@mail.gmail.com \
    --to=maglyx@gmail.com \
    --cc=clemens@ladisch.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®