From: Paolo Abeni <pabeni@redhat.com>
To: Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Donald Hunter <donald.hunter@gmail.com>,
Rob Herring <robh@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
Kyle Swenson <kyle.swenson@est.tech>,
Dent Project <dentproject@linuxfoundation.org>,
kernel@pengutronix.de,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v9 02/13] net: pse-pd: Add support for reporting events
Date: Tue, 29 Apr 2025 11:00:19 +0200 [thread overview]
Message-ID: <be2ae666-a891-4dee-8791-3773331ce7d7@redhat.com> (raw)
In-Reply-To: <20250422-feature_poe_port_prio-v9-2-417fc007572d@bootlin.com>
On 4/22/25 4:56 PM, Kory Maincent wrote:
> +/**
> + * pse_control_find_phy_by_id - Find PHY attached to the pse control id
> + * @pcdev: a pointer to the PSE
> + * @id: index of the PSE control
> + *
> + * Return: PHY device pointer or NULL
> + */
> +static struct phy_device *
> +pse_control_find_phy_by_id(struct pse_controller_dev *pcdev, int id)
> +{
> + struct pse_control *psec;
> +
> + mutex_lock(&pse_list_mutex);
> + list_for_each_entry(psec, &pcdev->pse_control_head, list) {
> + if (psec->id == id) {
> + mutex_unlock(&pse_list_mutex);
AFAICS at this point 'psec' could be freed and the next statement could
cause UaF.
It looks like you should acquire a reference to the pse control?
/P
next prev parent reply other threads:[~2025-04-29 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 14:56 [PATCH net-next v9 00/13] Add support for PSE budget evaluation strategy Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 01/13] net: ethtool: Add support for ethnl_info_init_ntf helper function Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 02/13] net: pse-pd: Add support for reporting events Kory Maincent
2025-04-29 9:00 ` Paolo Abeni [this message]
2025-04-29 9:32 ` Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 03/13] net: pse-pd: tps23881: Add support for PSE events and interrupts Kory Maincent
2025-04-29 9:07 ` Paolo Abeni
2025-04-29 12:29 ` Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 04/13] net: pse-pd: Add support for PSE power domains Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 05/13] net: ethtool: Add support for new power domains index description Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 06/13] net: pse-pd: Add helper to report hardware enable status of the PI Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 07/13] net: pse-pd: Add support for budget evaluation strategies Kory Maincent
2025-04-29 9:30 ` Paolo Abeni
2025-04-22 14:56 ` [PATCH net-next v9 08/13] net: ethtool: Add PSE port priority support feature Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 09/13] net: pse-pd: pd692x0: Add support for PSE PI priority feature Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 10/13] net: pse-pd: pd692x0: Add support for controller and manager power supplies Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 11/13] dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 12/13] net: pse-pd: tps23881: Add support for static port priority feature Kory Maincent
2025-04-22 14:56 ` [PATCH net-next v9 13/13] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be2ae666-a891-4dee-8791-3773331ce7d7@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dentproject@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®