mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Alex Shumsky <alexthreed@gmail.com>, linux-wireless@vger.kernel.org
Cc: Al Viro <viro@zeniv.linux.org.uk>, Kalle Valo <kvalo@kernel.org>,
	brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: remove misleading log messages
Date: Tue, 26 Nov 2024 12:02:05 +0100	[thread overview]
Message-ID: <be2f054e-5ff8-4fcb-ad50-0dc0d5c03bf5@broadcom.com> (raw)
In-Reply-To: <20241122180435.1637479-1-alexthreed@gmail.com>

On 11/22/2024 7:04 PM, Alex Shumsky wrote:
> Currently when debug info enabled, dmesg spammed every few minutes with
> misleading messages like:
>    brcmf_netdev_start_xmit phy0-sta0: insufficient headroom (0)
> 
> Do not log this when headroom is actually sufficient.

Thanks for your patch. The message may be misleading, but it is actually 
information that we need to cow the packet. The zero value indicates 
that this is needed because skb_header_cloned(skb) is true. So it is 
still useful in my opinion. If you want to make the message less 
misleading for that case I would be happy to ack the patch.

Regards,
Arend

  reply	other threads:[~2024-11-26 11:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 18:04 Alex Shumsky
2024-11-26 11:02 ` Arend van Spriel [this message]
2024-12-09 20:08   ` Alex Shumsky
2024-12-12  9:30     ` Arend van Spriel
2024-12-13  8:35       ` Alex Shumsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be2f054e-5ff8-4fcb-ad50-0dc0d5c03bf5@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=alexthreed@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®