From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755415AbcGHNYX (ORCPT ); Fri, 8 Jul 2016 09:24:23 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33012 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947AbcGHNYO (ORCPT ); Fri, 8 Jul 2016 09:24:14 -0400 Subject: Re: [PATCH 1/2] KVM: x86: move MSR_IA32_FEATURE_CONTROL handling to x86.c To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com References: <1467979301-19376-1-git-send-email-pbonzini@redhat.com> <1467979301-19376-2-git-send-email-pbonzini@redhat.com> <20160708124156.23l5shhmzuefqyta@hz-desktop> From: Paolo Bonzini Message-ID: Date: Fri, 8 Jul 2016 15:24:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160708124156.23l5shhmzuefqyta@hz-desktop> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/2016 14:41, Haozhong Zhang wrote: > On 07/08/16 14:01, Paolo Bonzini wrote: >> > Because the MSR is listed in msrs_to_save, it is exported to userspace >> > for both AMD and Intel processors. However, on AMD currently getting >> > it will fail. >> > > Is MSR_IA32_FEATURE_CONTROL already be excluded from msrs_to_save[] by > kvm_init_msr_list() on AMD hosts? Uhm... you're right, because the MSR doesn't exist on AMD hosts. Facepalm... Paolo