mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Sjoerd Simons <sjoerd@collabora.com>, linux-mediatek@lists.infradead.org
Cc: robh@kernel.org, conor+dt@kernel.org, mbrugger@suse.com,
	y.oudjana@protonmail.com,
	"Nícolas F. R. A. Prado" <nfraprado@collabora.com>,
	linux-pm@vger.kernel.org, ulf.hansson@linaro.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	mandyjh.liu@mediatek.com, lihongbo22@huawei.com,
	wenst@chromium.org, matthias.bgg@gmail.com, krzk+dt@kernel.org,
	kernel@collabora.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 04/10] pmdomain: mediatek: Refactor bus protection regmaps retrieval
Date: Tue, 14 Oct 2025 11:59:11 +0200	[thread overview]
Message-ID: <be3a2d50-044b-429a-820c-5260c6ce730c@collabora.com> (raw)
In-Reply-To: <a2eae87efe46ebf397bcec3580eb9bc152b80846.camel@collabora.com>

Il 13/10/25 15:41, Sjoerd Simons ha scritto:
> Hey,
> 
> On Tue, 2025-08-05 at 09:47 +0200, AngeloGioacchino Del Regno wrote:
>> In preparation to add support for new generation SoCs like MT8196,
>> MT6991 and other variants, which require to set bus protection on
>> different busses than the ones found on legacy chips, and to also
>> simplify and reduce memory footprint of this driver, refactor the
>> mechanism to retrieve and use the bus protection regmaps.
>>
>> This is done by removing the three pointers to struct regmap from
>> struct scpsys_domain (allocated for each power domain) and moving
>> them to the main struct scpsys (allocated per driver instance) as
>> an array of pointers to regmap named **bus_prot.
> 
> Trying to boot v6.18.0-rc1 on a Genio 700 EVK using the arm64 defconfig,
> ends up hanging at boot (seemingly when probing MTU3 and/or mmc, but that
> might be a red herring).
> 
> Either reverting this patch *or* having CONFIG_MTK_MMSYS builtin rather
> then a module seems to solve that.
> 

Thanks for the report.

This is not a problem with this patch specifically, but surely some race condition
that was already present before and that does get uncovered with this one in some
conditions.

Without the devicetree updates (which are not upstream yet) this patch is
fully retaining the legacy functionality 1-to-1.

I'll check what's going on ASAP.

Cheers,
Angelo

  reply	other threads:[~2025-10-14  9:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05  7:47 [PATCH v3 00/10] pmdomain: Partial refactor, support modem and RTFF AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 01/10] dt-bindings: memory: mtk-smi: Document #access-controller-cells AngeloGioacchino Del Regno
2025-08-05 17:53   ` Rob Herring
2025-08-05  7:47 ` [PATCH v3 02/10] dt-bindings: clock: mediatek: " AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 03/10] dt-bindings: power: mediatek: Document access-controllers property AngeloGioacchino Del Regno
2025-08-05 17:56   ` Rob Herring (Arm)
2025-08-05  7:47 ` [PATCH v3 04/10] pmdomain: mediatek: Refactor bus protection regmaps retrieval AngeloGioacchino Del Regno
2025-10-13 13:41   ` Sjoerd Simons
2025-10-14  9:59     ` AngeloGioacchino Del Regno [this message]
2025-10-29  4:11       ` Macpaul Lin (林智斌)
2025-10-29 10:56         ` AngeloGioacchino Del Regno
2025-10-29 15:01           ` Macpaul Lin (林智斌)
2025-11-21 12:57             ` AngeloGioacchino Del Regno
2026-02-12  7:58       ` Macpaul Lin (林智斌)
2026-02-12 11:15         ` AngeloGioacchino Del Regno
2026-02-13 16:07           ` Macpaul Lin (林智斌)
2026-02-17 17:00             ` Louis-Alexis Eyraud
2025-08-05  7:47 ` [PATCH v3 05/10] pmdomain: mediatek: Handle SoCs with inverted SRAM power-down bits AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 06/10] pmdomain: mediatek: Move ctl sequences out of power_on/off functions AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 07/10] pmdomain: mediatek: Add support for modem power sequences AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 08/10] pmdomain: mediatek: Add support for RTFF Hardware in MT8196/MT6991 AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 09/10] pmdomain: mediatek: Convert all SoCs to new style regmap retrieval AngeloGioacchino Del Regno
2025-08-05  7:47 ` [PATCH v3 10/10] arm64: dts: mediatek: Convert all SoCs to use access-controllers AngeloGioacchino Del Regno
2025-08-05 14:36 ` [PATCH v3 00/10] pmdomain: Partial refactor, support modem and RTFF Rob Herring (Arm)
2025-08-19 12:27 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be3a2d50-044b-429a-820c-5260c6ce730c@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=lihongbo22@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mandyjh.liu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mbrugger@suse.com \
    --cc=nfraprado@collabora.com \
    --cc=robh@kernel.org \
    --cc=sjoerd@collabora.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wenst@chromium.org \
    --cc=y.oudjana@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®