mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [RFC PATCH v2 2/3] regmap: mmio: allow reset control in a MMIO regmap
Date: Sun, 11 Dec 2022 10:23:26 +0800	[thread overview]
Message-ID: <be3f9f0f68ce371b1a3837d21146daa25ebe77a0.camel@codeconstruct.com.au> (raw)
In-Reply-To: <Y5MvOp7kLoEJfwkk@sirena.org.uk>

Hi Mark,

> > A syscon device may need to be taken out of reset before functioning
> > - this change adds a facility to attach a reset control to a mmio
> > regmap, and performs the necessary deassert/assert operations on the
> > reset controller on attach/detach.
> 
> Managment of reset feels like something that should be done at a
> higher level - typically reset also implies losing all the register
> contents which means it should be somewhere above the cache layer.

Yep, that makes sense. I'll rework to do the reset controller handling
in the syscon layer instead - unless there are any objections to that?

Cheers,


Jeremy

  reply	other threads:[~2022-12-11  2:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  1:33 [RFC PATCH v2 0/3] Add reset control for mfd syscon devices Jeremy Kerr
2022-12-09  1:33 ` [RFC PATCH v2 1/3] dt-bindings: mfd/syscon: Add resets property Jeremy Kerr
2022-12-09  1:33 ` [RFC PATCH v2 2/3] regmap: mmio: allow reset control in a MMIO regmap Jeremy Kerr
2022-12-09 12:51   ` Mark Brown
2022-12-11  2:23     ` Jeremy Kerr [this message]
2022-12-09  1:33 ` [RFC PATCH v2 3/3] mfd: syscon: allow reset control for syscon devices Jeremy Kerr
2022-12-09 11:17 ` [RFC PATCH v2 0/3] Add reset control for mfd " Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be3f9f0f68ce371b1a3837d21146daa25ebe77a0.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®