From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 721BFC47080 for ; Wed, 2 Jun 2021 02:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4748E61008 for ; Wed, 2 Jun 2021 02:31:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbhFBCde (ORCPT ); Tue, 1 Jun 2021 22:33:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229792AbhFBCde (ORCPT ); Tue, 1 Jun 2021 22:33:34 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2BB9C06174A for ; Tue, 1 Jun 2021 19:31:51 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id lx17-20020a17090b4b11b029015f3b32b8dbso2590422pjb.0 for ; Tue, 01 Jun 2021 19:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=sT/ogThoChr1uPFVVzKVR3CGfQEDl6jQU/9/uFyWW5g=; b=R9SHjWMTNpwstv/KAwlpVle1p5NurrO10Nvcb7Vjyuop9tVSCA42g8zz5PZY5Wrzrz FYKfTjjUvMYQBCxBG9FQutYPG11L+K45/FrOX8zcg74Mj7wMgx8lw2AWRqqmEj1wDWrV t7UTR3pqRrCXMTso4D4WiEg/ZQDspEPKPPJJIEJEPkk3bbacXj8onLXOJYKlVD4tCW8o vTv6Z707Weo+A4cz6F56Ri26U3Rx4t9ZEHL8xGylXpIjQeVzPRvxHUO4nNQ43rUt3Qaz ZkBxtyzzYSRsbYsi+dfU6AB3lkeH70d4G9VPOyC6ZWtaW4Uam9muoVY9r3nCSE9HplXi X1zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=sT/ogThoChr1uPFVVzKVR3CGfQEDl6jQU/9/uFyWW5g=; b=owqF+tK1ZlaSK2Faj27uYiyRzOuBFkABIeiCvNOPMECEI5JeQEkR9gkFyIrgTriFAq LxWr6PVj1/MgfPaa3OKrywBQ8TnEnRzPtSImGzWfRWii1OA6DP4Zr8FQNFGu0YFC+ZrR VjM+ROJfAVcAA+Cs1vPZUQ9q/GY402cOmHIBJEQ2nQrvUDUTCFi3qrypCt2lrnGkCKAg eQAkXGo/KdWOFgGsGTrGMsZMwUcrpp5GxnkF878GfAcyOC3YaPf6Z+zgVrzdUREwqN9r FAbvi/ruKRD+3KW3BEePi/91/dD/XYu+zR8jURnyHGn1RMsIB4eoXyvLnej8QoJiNAPd C1tA== X-Gm-Message-State: AOAM5328nAs2tZysRJguq6CGMp0gQQZqGcoBWP4YCV0d0e/WWpXp2Bj+ C/pDEH0c/dU4HrFO7L7TChbBeA== X-Google-Smtp-Source: ABdhPJwb+DeSZnRW4rwnn+8msc5yEgIKNM8POntUbCZwyaInAWajfp7lemFjPNJpBZnKi7mhxS7cxQ== X-Received: by 2002:a17:902:e309:b029:f1:9342:2036 with SMTP id q9-20020a170902e309b02900f193422036mr28802305plc.53.1622601111408; Tue, 01 Jun 2021 19:31:51 -0700 (PDT) Received: from [10.86.119.121] ([139.177.225.224]) by smtp.gmail.com with ESMTPSA id q24sm15120581pgb.19.2021.06.01.19.31.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 19:31:50 -0700 (PDT) Subject: Re: [External] Re: [PATCH v2] fs/proc/kcore.c: add mmap interface To: Andrew Morton Cc: adobriyan@gmail.com, rppt@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, songmuchun@bytedance.com, zhouchengming@bytedance.com, chenying.kernel@bytedance.com, zhengqi.arch@bytedance.com References: <20210601082241.13378-1-zhoufeng.zf@bytedance.com> <20210601192257.65a514606382f0a972f918c3@linux-foundation.org> From: zhoufeng Message-ID: Date: Wed, 2 Jun 2021 10:31:44 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210601192257.65a514606382f0a972f918c3@linux-foundation.org> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/6/2 ÉÏÎç10:22, Andrew Morton дµÀ: > On Tue, 1 Jun 2021 16:22:41 +0800 Feng zhou wrote: > >> From: ZHOUFENG >> >> When we do the kernel monitor, use the DRGN >> (https://github.com/osandov/drgn) access to kernel data structures, >> found that the system calls a lot. DRGN is implemented by reading >> /proc/kcore. After looking at the kcore code, it is found that kcore >> does not implement mmap, resulting in frequent context switching >> triggered by read. Therefore, we want to add mmap interface to optimize >> performance. Since vmalloc and module areas will change with allocation >> and release, consistency cannot be guaranteed, so mmap interface only >> maps KCORE_TEXT and KCORE_RAM. >> >> ... >> >> +static int mmap_kcore(struct file *file, struct vm_area_struct *vma) >> +{ >> + size_t size = vma->vm_end - vma->vm_start; >> + u64 start, pfn; >> + int nphdr; >> + size_t data_offset; >> + size_t phdrs_len, notes_len; >> + struct kcore_list *m = NULL; >> + int ret = 0; >> + >> + down_read(&kclist_lock); >> + >> + get_kcore_size(&nphdr, &phdrs_len, ¬es_len, &data_offset); >> + >> + start = kc_offset_to_vaddr(((u64)vma->vm_pgoff << PAGE_SHIFT) - >> + ((data_offset >> PAGE_SHIFT) << PAGE_SHIFT)); >> + >> + list_for_each_entry(m, &kclist_head, list) { >> + if (start >= m->addr && size <= m->size) >> + break; >> + } >> + >> + if (&m->list == &kclist_head) { >> + ret = -EINVAL; >> + goto out; >> + } >> + >> + if (vma->vm_flags & (VM_WRITE | VM_EXEC)) { >> + ret = -EPERM; >> + goto out; >> + } >> + >> + vma->vm_flags &= ~(VM_MAYWRITE | VM_MAYEXEC); >> + vma->vm_flags |= VM_MIXEDMAP; >> + vma->vm_ops = &kcore_mmap_ops; >> + >> + if (kern_addr_valid(start)) { >> + if (m->type == KCORE_RAM || m->type == KCORE_REMAP) > > KCORE_REMAP was removed by > https://lkml.kernel.org/r/20210526093041.8800-2-david@redhat.com > > I did this: > > --- a/fs/proc/kcore.c~fs-proc-kcorec-add-mmap-interface-fix > +++ a/fs/proc/kcore.c > @@ -660,7 +660,7 @@ static int mmap_kcore(struct file *file, > vma->vm_ops = &kcore_mmap_ops; > > if (kern_addr_valid(start)) { > - if (m->type == KCORE_RAM || m->type == KCORE_REMAP) > + if (m->type == KCORE_RAM) > pfn = __pa(start) >> PAGE_SHIFT; > else if (m->type == KCORE_TEXT) > pfn = __pa_symbol(start) >> PAGE_SHIFT; > Thank you very much.