From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbdAUSKW (ORCPT ); Sat, 21 Jan 2017 13:10:22 -0500 Received: from mout.web.de ([212.227.15.4]:54752 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdAUSKO (ORCPT ); Sat, 21 Jan 2017 13:10:14 -0500 Subject: [PATCH 1/5] s390/pci: Return directly after a failed parameter validation in clp_normal_command() To: linux-s390@vger.kernel.org, =?UTF-8?Q?Gerald_Sch=c3=a4fer?= , Heiko Carstens , Martin Schwidefsky , Sebastian Ott References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sat, 21 Jan 2017 19:10:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yvd7ZTacd8AwzXUCJN/vHeg7jmhKXBLKHt8h1bpdG03oWVqxmGS zcKIJTQLSmlLC+ht4w6CjNMZdQGPpRE0HqoJrR3c/w4o5cADUh6Bc108puSfAdB2FrBnNKQ 2FZCFtXk86MvPUwjxNryNq4CMGvOn4lMnu3NBDVX9Mc56H62ScX90j1TMGzP8YwOQCPdJoa 9EflUDf99bEi54Q0XiAlg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Qn+vLfdhxCc=:dC3A8d+zot+OwsdSY+9mBP mvkF7EIlZinkf1B6EnCXNXpsIaz5Q4Z8iqWu5EPlJhfxXJDcjHgfcO++kFvqNnIhpgKXuht1M XDevNFssrtz+VPU7gKtjsk2FOg4G0oEdQD8SvAXOyjId545xEGf9G3vXLV+XXwSsM3jOVk8rp Tmdf2OdHoM81/WAjbrQBZCNaiiDf4k22XKYWsRzDtzRDZ3pikNc59AdMkySZbKqFklPYX4INi rsB4lRRc0APWi9FGgVNsiys4iTdEAg8arYpMWjuHf1bwehYoF2I7wQMvOTAg7yzkfvTXHPjJo /NMjht6uBlbZ+42shH4mKyRXCQGF4vsynuRNWIiS3N9uiCC/3WJMmdZYYiVL/IS0v4CtzDjaA tM5p+W/CIbeGJh0xqpgmX0cmhwsIVQ/2d26aK6mEL3lpPbJUG+7OzQlubC2IBHFepsaJFRGLf E3kr0bePGSpxGTwd0QyGkmlDG6Fh12jkIQa5EiO1nw0ydGittV/iqeV8VR/qmv1dY0D6yG+dj 5xmSPYYnNjFGbqfgDnLEeCr7pUw895Mfea4BCo8+3L7PK7ukPtRW+/iCsnYSpTbFCn3EUQjEK 54HNdbEe0p+ZEV35rQJbM1+/ua3iuow9Ie5DYyGOYwR+Nrp3diq7wpHVxELDX/Y1pe0CtwIQd 6H6deNXBO8TQZovCSp5i7vB/HDSCeDdj3eVumpFyBWDFxNsHnKWVvxbke0UCkjSLddJiYeLyI vi5jMhjHYfvgEtcWC2Q72YA/lqNfA4s9Wd8NaBnuthQxi2dak4jPW3ReuTvVBeL39ZU7+mlGP 0A2SHn7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 21 Jan 2017 17:49:00 +0100 Return directly after an inappropriate input parameter was detected. Signed-off-by: Markus Elfring --- arch/s390/pci/pci_clp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c index 1c3332ac1957..4f5a1bf3b14b 100644 --- a/arch/s390/pci/pci_clp.c +++ b/arch/s390/pci/pci_clp.c @@ -514,9 +514,8 @@ static int clp_normal_command(struct clp_req *req) void __user *uptr; int rc; - rc = -EINVAL; if (req->lps != 0 && req->lps != 2) - goto out; + return -EINVAL; rc = -ENOMEM; lpcb = clp_alloc_block(GFP_KERNEL); -- 2.11.0