From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Mathieu Poirier <mathieu.poirier@linaro.org>,
Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Bjorn Andersson <andersson@kernel.org>,
Beleswar Padhi <b-padhi@ti.com>, Andrew Davis <afd@ti.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH v2] remoteproc: k3-dsp: Fix an error handling path in k3_dsp_rproc_probe()
Date: Tue, 10 Sep 2024 18:56:07 +0200 [thread overview]
Message-ID: <be4bcfa9-6445-4e8a-a510-0777341026b0@wanadoo.fr> (raw)
In-Reply-To: <ZuBlvhf5AszNHV1e@p14s>
Le 10/09/2024 à 17:29, Mathieu Poirier a écrit :
>> +static void k3_dsp_free_channel(void *data)
>> +{
>> + struct k3_dsp_rproc *kproc = data;
>
> How did the struct rproc from devm_add_action_or_reset() got turned into a
> struct k3_dsp_rproc?
>
Well, Linux is a wonderful system, that is able to make wonderful thinks!
In this particular case, if it is not the correct explanation, it is
likely an unfortunate typo :(
Sorry about that, and thanks for the careful review.
I'll send a v3.
But, looking at it, and trying to see if similar issues may exist, the
following naive script spots 2 similar issues. 1 of them looks valid.
I'll try to improve it (Julia in copy, if she wants to give it a look
as-well :))
CJ
@devm@
expression RET, DEV;
identifier FCT, VAR;
type T;
@@
T VAR;
...
(
RET = devm_add_action_or_reset(DEV, FCT, VAR);
|
devm_add_action_or_reset(DEV, FCT, VAR);
)
@depends on devm@
identifier FCT = devm.FCT, x, VAR;
type T1 = devm.T, T2;
@@
void FCT(void *x)
{
...
(
T1 VAR = x;
|
* T2 VAR = x;
)
...
}
prev parent reply other threads:[~2024-09-10 17:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-07 6:33 Christophe JAILLET
2024-09-10 15:29 ` Mathieu Poirier
2024-09-10 16:56 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4bcfa9-6445-4e8a-a510-0777341026b0@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=afd@ti.com \
--cc=andersson@kernel.org \
--cc=b-padhi@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®