From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93F8025B0A5 for ; Sat, 30 May 2026 19:51:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780170703; cv=none; b=nLRPosyDDaKxl5da0a/qiWEM0ygav+AUhkBcbeFqkpHujGFGfWemqU7nr+mmPc7tIbHiCy6siQ7lz/GxoqzeaojcxUGrOCfqGj51oUzCboyBS6IJTkWCjhZwEufi/9m1dzIRtM2XGjFBIgiuCfr1pmzcxYYjdRad2kmAN/BR6iA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780170703; c=relaxed/simple; bh=afSC4jVwoq9wJZAIow45WnW1XZnhKA6USnmIw+3RvJ4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sIVaMy6EQC3NTkt+p5vQUkTQfcJgs1TYxvB42NjUUetH27aSTCfdn+jylYzS3R9T26jeGKiz23dfrMlPWrLQiwcGA37e+yB15GRHVs6czD3+opA15MAIPfTw57riXXBU39ujoZrTsGvmtbxQoSklSNov7sw/qE/MhrvOIA3/2ac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rb2xKjs4; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rb2xKjs4" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-36babe2c4bdso1207299a91.1 for ; Sat, 30 May 2026 12:51:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780170702; x=1780775502; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KUPVDO4TuLnw66Ni1+lzz4Gz256nyEweInp7TugqCsg=; b=Rb2xKjs4yH3o+5y1lEvd1A5A785gst6TlaS03qgi6hcmka45u3dC+eymsW/psu6w1g 0EsbjAl6ihjvSRDBrLZXIVkl7SuSZASANtp2U0H0TxR2ItanvJTub7I325GPnSLNh0NT KH5tfqcX93ltlmzwSJvoDw5w/bq1rgfhIDUCYSJ0DBWH/90hmDTHskVbMLEgJUJ5zkIH ZwTi9lUg8GTjxTY82QLNCGHuBeeWPLAAfciq2aCQx2AiWbuQkXIEOjzXvS4DWsL8OBxq Hq3NkX3Ulwlyg+OquZ9/5xdxmElFM5aYWq+BPBuFhS4lHoZ3msx3F4WyACydOTK/nfiy qgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780170702; x=1780775502; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KUPVDO4TuLnw66Ni1+lzz4Gz256nyEweInp7TugqCsg=; b=plZoV36oT5Bmd5bJhvGiKHeE9yTCjMdqptpSh+ysICnLugR+HyaTYLk0RuHm65ErYX Y/RCgIUDjWEVzjertxtw6JHlGkEJqlCI0E2uebgveFdPb6ClbgDjAw0raMDr9eeXyZHB 7v9lKzwh5TE/Qn6g3rTR8FC66tTDMwgDXt4CfszdmIZN5Hj18oDGgbQRNLu7KxdVu3Zm 2AFL3KVq1+jxwcmx6uMsl7mHrbNNWmpxlr8RVk6zi6dAKlTM9bF+dasyEN0qyU4GpJEd JNOhb0xHWulFpCmJzW1Ivze4rAU59D+b5TB6AB/4RfR/eo/4xPyu0HyJg3iSdekPDldj Gl7w== X-Forwarded-Encrypted: i=1; AFNElJ/EP9Ch7+oggiuJzaEJ+RO5m4dajVYN15kIvQH6Ep7GB9nP5UIcOvnCmaCVya07h9QyRkKvlu54j/+I8Qg=@vger.kernel.org X-Gm-Message-State: AOJu0YyneQUO97KO3YOQC+ekJRSjt15CBYhP/aTwOegfdm96hsEGoSWM VJfchiZJ3HJaRUetv5RVtrLSLcb1Lv3DaqXYy7JWJQfciI/SnJ/YEeFB X-Gm-Gg: Acq92OEU9v5GnDVZYHOsj6UCyxUmnmA8lkFFcShO4m0YQ8coPO/XfOgoNZ8biKNu+uM IuZc5wo5S06RRcYbscd/Ewubago2Dj/77tYW1Cx/wrVodGHXJjbKPGkXDPND5l7X4EPP7GWl6iV HyDlQZz9G320pdRLySvXGiZOF1R/2S8lCMa/oK2wIUA7XJ57yha4BBZwqsAdyvZseB3hbuC1YwA pqauBrVCWJJ9NOg7OMPILzQ6uWqwTm9hCJ6FwAMKezvPbmoIqoD700yJWR48PV7Bs1E0Clnz4Sw GKqVD7LLmRxu98FZBY8E/aRqQPS1lTHxH8gcavGrmRIaM/BCWgo5hCubMyCNcmrn2YBkjY2F/Zv eexQ6gK7xAI5rRkiVf3rUOFEBL93uKBoGPoxecxwKwB+E6YQHmMQvR1D6GUJCGOWky9ymGLpM9D PdhKa8O9d2fWwZSQ+iXnVwX4LTQMgB9XMj7+KMSjUM6DMwImA7VE3vwABRbvU/gbQv+65+0X6x4 98JIWaRJ4VNrRj2uHYJBFapdz7gbp0c1RaJ61UcUk+nHQ== X-Received: by 2002:a17:90b:1ccb:b0:36b:ad81:c134 with SMTP id 98e67ed59e1d1-36c4ff410b9mr4361367a91.10.1780170701892; Sat, 30 May 2026 12:51:41 -0700 (PDT) Received: from [192.168.0.101] ([103.181.54.100]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36bbdb5c91bsm3439199a91.1.2026.05.30.12.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 May 2026 12:51:41 -0700 (PDT) Message-ID: Date: Sun, 31 May 2026 01:17:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: leds: bcm6358: Convert to DT schema To: Conor Dooley Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonas.gorski@gmail.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org References: <20260525033258.144291-1-ninadnaik07@gmail.com> <20260525-wreckage-gap-9d857408445a@spud> Content-Language: en-US From: Ninad Naik In-Reply-To: <20260525-wreckage-gap-9d857408445a@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> +patternProperties: >> + "^led@(0|1?[0-9a-f])$": >> + type: object >> + $ref: common.yaml# >> + description: Each LED is represented as a sub-node of >> + this device. >> + >> + properties: >> + reg: >> + description: LED pin number. >> + minimum: 0 >> + maximum: 31 > Is this missing a maxItems: 1? Thanks Conor for pointing this out. I will include it in v2. > >> + >> + required: >> + - reg >> + >> + unevaluatedProperties: false > I wonder if this should be additionalProperties: false instead, and list > the three properties mentioned by the text binding explicitly? > > > Cheers, > Conor. I added unevaluatedProperties: false because my understanding was that explicitly listing the properties inherited from common.yaml would be redundant. I'd be interested to hear the maintainers' preference here, and can adjust this in v2 if needed. Thanks, Ninad Naik