From: Andrew Lunn <andrew@lunn.ch>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jacob.e.keller@intel.com,
rentao.bupt@gmail.com, f.fainelli@gmail.com, andrew@aj.id.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net] net: ftgmac100: refactor getting phy device handle
Date: Sat, 12 Oct 2024 19:17:48 +0200 [thread overview]
Message-ID: <be591afe-d70b-4208-a189-40e65227ad14@lunn.ch> (raw)
In-Reply-To: <20241011081633.2171603-1-jacky_chou@aspeedtech.com>
On Fri, Oct 11, 2024 at 04:16:33PM +0800, Jacky Chou wrote:
> The ftgmac100 supports NC-SI mode, dedicated PHY and fixed-link
> PHY. The dedicated PHY is using the phy_handle property to get
> phy device handle and the fixed-link phy is using the fixed-link
> property to register a fixed-link phy device.
>
> In of_phy_get_and_connect function, it help driver to get and register
> these PHYs handle.
> Therefore, here refactors this part by using of_phy_get_and_connect.
>
> Fixes: 38561ded50d0 ("net: ftgmac100: support fixed link")
> Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property")
Fixes: implies something is broken. What is actually wrong with this
code? What sort of problem does a user see?
> - phy_support_asym_pause(phy);
> + if (of_get_property(np, "phy-handle", NULL))
> + phy_support_asym_pause(phy);
This is probably wrong. This is the MAC layer telling phylib that the
MAC supports asym pause. It should makes no difference to the MAC what
sort of PHY is being used, all the MAC is looking at/sending is pause
frames.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-10-12 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 8:16 Jacky Chou
2024-10-12 17:17 ` Andrew Lunn [this message]
2024-10-14 2:38 ` 回覆: " Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be591afe-d70b-4208-a189-40e65227ad14@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jacky_chou@aspeedtech.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rentao.bupt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®