From: Manfred Spraul <manfred@colorfullife.com>
To: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
1vier1@web.de
Subject: Re: Invalid locking pattern in Documentation/kernel-hacking/locking.rst?
Date: Fri, 9 Dec 2022 19:47:52 +0100 [thread overview]
Message-ID: <be5a4c10-3b69-1c2d-d413-62f79ccc178b@colorfullife.com> (raw)
In-Reply-To: <442ecdf402f8e726f2be4ab19c7299d272e27c0b.camel@siemens.com>
Hi Alexander,
On 12/9/22 13:23, Sverdlin, Alexander wrote:
> Dear documentation maintainers,
>
> the latest version of locking.rst contains the following (since 2005):
>
> "Manfred Spraul points out that you can still do this, even if the data
> is very occasionally accessed in user context or softirqs/tasklets. The
> irq handler doesn't use a lock, and all other accesses are done as so::
>
> spin_lock(&lock);
> disable_irq(irq);
> "
>
> Isn't it "sleeping in atomic" actually because of the sleeping
> disable_irq()?
Good catch!
The documentation of disable_irq() claims that the function is safe to
be called from IRQ context (for careful callers)
But it calls synchronize_irq(). And synchronize_irq() claims that the
function can be called only from preemptible code.
The change was in 2009:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.1-rc8&id=3aa551c9b4c40018f0e261a178e3d25478dc04a9
@Thomas/@Ingo: What do we want?
Declare disable_irq()&synchronize_irq() as safe from irq context only if
no threaded irq handlers are used?
Or declare both function as preemptible context only?
The update for locking.rst would be to switch from spin_lock() to
mutex_lock().
https://elixir.bootlin.com/linux/latest/source/kernel/irq/manage.c#L126
> /**
> * synchronize_irq - wait for pending IRQ handlers (on other CPUs)
> * @irq: interrupt number to wait for
> *
> * This function waits for any pending IRQ handlers for this interrupt
> * to complete before returning. If you use this function while
> * holding a resource the IRQ handler may need you will deadlock.
> *
> * Can only be called from preemptible code as it might sleep when
> * an interrupt thread is associated to @irq.
> *
> * It optionally makes sure (when the irq chip supports that method)
> * that the interrupt is not pending in any CPU and waiting for
> * service.
> */
> void synchronize_irq
> <https://elixir.bootlin.com/linux/latest/C/ident/synchronize_irq>(unsigned int irq)
> {
> struct irq_desc <https://elixir.bootlin.com/linux/latest/C/ident/irq_desc> *desc = irq_to_desc
> <https://elixir.bootlin.com/linux/latest/C/ident/irq_to_desc>(irq);
>
> if (desc) {
> __synchronize_hardirq
> <https://elixir.bootlin.com/linux/latest/C/ident/__synchronize_hardirq>(desc, true <https://elixir.bootlin.com/linux/latest/C/ident/true>);
> /*
> * We made sure that no hardirq handler is
> * running. Now verify that no threaded handlers are
> * active.
> */
> wait_event
> <https://elixir.bootlin.com/linux/latest/C/ident/wait_event>(desc->wait_for_threads
> <https://elixir.bootlin.com/linux/latest/C/ident/wait_for_threads>,
> !atomic_read
> <https://elixir.bootlin.com/linux/latest/C/ident/atomic_read>(&desc->threads_active
> <https://elixir.bootlin.com/linux/latest/C/ident/threads_active>));
> }
> }
> EXPORT_SYMBOL
> <https://elixir.bootlin.com/linux/latest/C/ident/EXPORT_SYMBOL>(synchronize_irq
> <https://elixir.bootlin.com/linux/latest/C/ident/synchronize_irq>);
https://elixir.bootlin.com/linux/latest/source/kernel/irq/manage.c#L716
> /**
> * disable_irq - disable an irq and wait for completion
> * @irq: Interrupt to disable
> *
> * Disable the selected interrupt line. Enables and Disables are
> * nested.
> * This function waits for any pending IRQ handlers for this interrupt
> * to complete before returning. If you use this function while
> * holding a resource the IRQ handler may need you will deadlock.
> *
> * This function may be called - with care - from IRQ context.
> */
> void disable_irq
> <https://elixir.bootlin.com/linux/latest/C/ident/disable_irq>(unsigned int irq)
> {
> if (!__disable_irq_nosync
> <https://elixir.bootlin.com/linux/latest/C/ident/__disable_irq_nosync>(irq))
> synchronize_irq
> <https://elixir.bootlin.com/linux/latest/C/ident/synchronize_irq>(irq);
> }
>
--
Manfred
next prev parent reply other threads:[~2022-12-09 18:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 12:23 Sverdlin, Alexander
2022-12-09 18:47 ` Manfred Spraul [this message]
2022-12-12 14:43 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be5a4c10-3b69-1c2d-d413-62f79ccc178b@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=1vier1@web.de \
--cc=alexander.sverdlin@siemens.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®