mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Ruan Jinjie <ruanjinjie@huawei.com>, <jirislaby@kernel.org>,
	<mickflemm@gmail.com>, <mcgrof@kernel.org>, <kvalo@kernel.org>,
	<linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] wifi: ath5k: Remove redundant dev_err()
Date: Mon, 7 Aug 2023 07:02:35 -0700	[thread overview]
Message-ID: <be5aa2bf-17fb-d241-25b1-c06b27fdcf89@quicinc.com> (raw)
In-Reply-To: <20230726171235.2475625-1-ruanjinjie@huawei.com>

On 7/26/2023 10:12 AM, Ruan Jinjie wrote:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as it is
> going to display an appropriate error message in case of a failure.
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>

> ---
>   drivers/net/wireless/ath/ath5k/ahb.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> index 28a1e5eff204..08bd5d3b00f1 100644
> --- a/drivers/net/wireless/ath/ath5k/ahb.c
> +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> @@ -115,7 +115,6 @@ static int ath_ahb_probe(struct platform_device *pdev)
>   
>   	irq = platform_get_irq(pdev, 0);
>   	if (irq < 0) {
> -		dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
>   		ret = irq;
>   		goto err_iounmap;
>   	}


  parent reply	other threads:[~2023-08-07 14:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 17:12 Ruan Jinjie
2023-08-04  1:15 ` Ruan Jinjie
2023-08-07 14:02 ` Jeff Johnson [this message]
2023-08-22 13:34 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be5aa2bf-17fb-d241-25b1-c06b27fdcf89@quicinc.com \
    --to=quic_jjohnson@quicinc.com \
    --cc=jirislaby@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mickflemm@gmail.com \
    --cc=ruanjinjie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®