From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95FFA156983 for ; Mon, 15 Apr 2024 19:42:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210169; cv=none; b=GuMbfu4Em0ke57y8VUKpwgDKFQE2ZxjINAh/Ta1lUicrX2XnEDFuXbRwimsHtS3QzHtSbxalD5XR85hc1UOVfH1Cnq/kxB5Kv75Fo3GZM2xbqAg1Mpfed+r3AsCbBQSEUJsYL1bS6Tz84SsTcWlGjybhBQYgqdG9mP3Dv5G9mjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713210169; c=relaxed/simple; bh=axLQ6Vb2y+fBkXSAxVnB3Ffwdojty5NQbps9GG6vRfU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FRqMSQVRCsaQPkIGElbTMmVpBNagwIAxq4XxI1WXEi8BiJJupfcoDlD0onLg2NDGhhCTQE0qw7Op2jHqaL5zXPhxF2d8+DJnKo6Z0DnZGjjGkRCQJcXkTfOaXeutPyV/TVI7HMXC9Z8M6cFj1pT6wBzuiZTcR2QDUkSmOzfl8P8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HHcm5IRa; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HHcm5IRa" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-516cbf3fd3dso4563654e87.2 for ; Mon, 15 Apr 2024 12:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713210166; x=1713814966; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pel4IuSMXhoiMO3e3jJODv6FFXqtNPQdDIe5/vhiNjE=; b=HHcm5IRaaK/ftAilAH5XGNzsTAs9K6vsr2r8g4ukWrRTNo6PdmBFDRL2WL8OGQv1+u bozQe6mWyYF+ZooTPKGUrCZuEx9e5/wXBv9K8kXasdQzYO28RFvmxOl95CYNycd3hetq lTlQBffZZffu7SCBQo8qGJfv4Q4BQkt7LTGS8rOjX0qzIZc0aPKPMXd97SvaOzxpNba+ jC0/icpYTyeWhBYzjwa52sSn9V+6deI3F15Psz+6Zf58VpfNIy8ogMB9yLzx3Hbp/lNL lcTYdrFvnj36Bp6Fi4L76U1ghJMiQl5G/THy3/NDVT3/vhp0zUXTu4iu9OIm8UaG77No MGOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713210166; x=1713814966; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pel4IuSMXhoiMO3e3jJODv6FFXqtNPQdDIe5/vhiNjE=; b=PXUsKIAyn+5YnGVm03Ae4TnU0sTOtKlUvhW9yscYgGh96XDBxrgVa9UzSEpiQCnyd7 U2/KdCINUzuG/ncZ2VKdFFoHYfuAI/R/8Aswwvqp6SxKywy1dfDMI0l8zEA0J/mAdDmt CmhmLIdblMyeRDVLECc1JVamhDPE8ZIBJaj1RlybZYsMgPtUd/H62t4x+wiY0gXdi6du uziwAXiu3s8lpeZ3S/W8/4jWLrZVCR2fTZw3SrraNzbqSLPIRLB8oGGXZmpIEHzyUUpy TeHSTjjC00cCg1QHa2VkgyCrysKUh5aSfDlR36o52Ri2z0iGfTVsgO1W9KXC3jFFN88M NjLA== X-Forwarded-Encrypted: i=1; AJvYcCVUT+WW/M/ZQ4jtQDUcx3S58B+FXGUCbUB3Gp2PocbcvGjwYOw7zTCYz5DCP2qe1j8cB3x9vNhDS3RyX8afqJYjjV69Xmou2nIhRi7v X-Gm-Message-State: AOJu0YwLR8kj2vSp1RJ983sPuuHhPvXitc130qhFnqpBp+e55VaHUddZ fyktpALJMpVfhc+K2UHxl+IIdjfN/OP3a53J87fMoqprqp+K4taG/1OA46F5VGY= X-Google-Smtp-Source: AGHT+IGjEnRycaBaSeP36Mt4IjxeEF3ElKi4vzIgUYlEGvDUqVdK0yPDppZzA2T8o+u/CJIaTfH0/g== X-Received: by 2002:ac2:4144:0:b0:519:231:e4c0 with SMTP id c4-20020ac24144000000b005190231e4c0mr1585142lfi.43.1713210165791; Mon, 15 Apr 2024 12:42:45 -0700 (PDT) Received: from [172.30.205.18] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id o21-20020ac24355000000b00516cba5b4cesm1334507lfl.46.2024.04.15.12.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 12:42:45 -0700 (PDT) Message-ID: Date: Mon, 15 Apr 2024 21:42:40 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Add PSCI SYSTEM_RESET2 types for qcm6490-idp To: Elliot Berman , Dmitry Baryshkov Cc: Bjorn Andersson , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Andy Yan , Lorenzo Pieralisi , Mark Rutland , Bartosz Golaszewski , Satya Durga Srinivasu Prabhala , Melody Olvera , Shivendra Pratap , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20240414-arm-psci-system_reset2-vendor-reboots-v2-0-da9a055a648f@quicinc.com> <20240414-arm-psci-system_reset2-vendor-reboots-v2-4-da9a055a648f@quicinc.com> <20240414173158942-0700.eberman@hu-eberman-lv.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20240414173158942-0700.eberman@hu-eberman-lv.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/15/24 02:32, Elliot Berman wrote: > On Mon, Apr 15, 2024 at 02:13:29AM +0300, Dmitry Baryshkov wrote: >> On Sun, 14 Apr 2024 at 22:32, Elliot Berman wrote: >>> >>> Add nodes for the vendor-defined system resets. "bootloader" will cause >>> device to reboot and stop in the bootloader's fastboot mode. "edl" will >>> cause device to reboot into "emergency download mode", which permits >>> loading images via the Firehose protocol. >>> >>> Co-developed-by: Shivendra Pratap >>> Signed-off-by: Shivendra Pratap >>> Signed-off-by: Elliot Berman >>> --- >>> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> index e4bfad50a669..a966f6c8dd7c 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >>> @@ -126,6 +126,11 @@ debug_vm_mem: debug-vm@d0600000 { >>> }; >>> }; >>> >>> + psci { >> >> Please use a label instead. Otherwise it looks as if you are adding >> new device node. >> > > Right. Fixed for the next revision. Are you guys planning to make this sorta ABI-like? If so (which would be greatly appreciated by the way..), perhaps you could stick these magic values in dt-bindings and give them cool names FWIW DEN0022 (my second-favorite book) suggests these values are almost totally vendor-defined, so if I were Qualcomm, I'd take the creative liberty to come up with a set of numbers and never ever ever change them Konrad