From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C21C6778F for ; Thu, 26 Jul 2018 11:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7260520846 for ; Thu, 26 Jul 2018 11:17:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7260520846 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729405AbeGZMd1 convert rfc822-to-8bit (ORCPT ); Thu, 26 Jul 2018 08:33:27 -0400 Received: from eu-smtp-delivery-211.mimecast.com ([146.101.78.211]:58328 "EHLO eu-smtp-delivery-211.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729254AbeGZMd0 (ORCPT ); Thu, 26 Jul 2018 08:33:26 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-141-VT_VZgBJNsaraEwH0KPUOw-1; Thu, 26 Jul 2018 12:10:55 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Thu, 26 Jul 2018 12:12:34 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Thu, 26 Jul 2018 12:12:34 +0100 From: David Laight To: "'Eric W. Biederman'" , David Ahern CC: Cong Wang , David Miller , Linux Kernel Network Developers , "nikita.leshchenko@oracle.com" , Roopa Prabhu , Stephen Hemminger , Ido Schimmel , Jiri Pirko , "Saeed Mahameed" , Alexander Aring , "linux-wpan@vger.kernel.org" , NetFilter , LKML Subject: RE: [PATCH RFC/RFT net-next 00/17] net: Convert neighbor tables to per-namespace Thread-Topic: [PATCH RFC/RFT net-next 00/17] net: Convert neighbor tables to per-namespace Thread-Index: AQHUJD6H+qoWXPCE1EOKssF/GlMy5KShWeQg Date: Thu, 26 Jul 2018 11:12:34 +0000 Message-ID: References: <1a3f59a9-0ba5-c83f-16a6-f9550a84f693@gmail.com> <1a27e301-3275-b349-a2f8-afdfdc02f04f@gmail.com> <20180718.125938.2271502580775162784.davem@davemloft.net> <28c30574-391c-b4bd-c337-51d3040d901a@gmail.com> <5021d874-8e99-6eba-f24b-4257c62d4457@gmail.com> <87muufze8w.fsf@xmission.com> <4b03b5f6-87ce-9ff2-7c14-598beebd8fb8@gmail.com> <87zhyfw70m.fsf@xmission.com> In-Reply-To: <87zhyfw70m.fsf@xmission.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.33] MIME-Version: 1.0 X-MC-Unique: VT_VZgBJNsaraEwH0KPUOw-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric W. Biederman > Sent: 25 July 2018 18:38 ... > >> Further unless I misread something you are increasing the number of > >> timers to 3 per namespace. If I create create a thousand network > >> namespaces that feels like it will hurt system performance overall. > > > > It seems to me the timers are per neighbor entry not table. The per > > table ones are for proxies. > > It seems I misread that bit when I was refreshing my memory on what > everything is doing. If we can already have 1024 timers that makes > timers not a concern. Surely it is enough to just have a timestamp in each entry. Deletion of expired items need not be done until insert (which has the table suitable locked) bumps into an expired item. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)