From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712A1EB64D9 for ; Thu, 6 Jul 2023 12:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232437AbjGFMsS (ORCPT ); Thu, 6 Jul 2023 08:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232319AbjGFMsJ (ORCPT ); Thu, 6 Jul 2023 08:48:09 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B8A1FFC for ; Thu, 6 Jul 2023 05:47:44 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0609C6606FBA; Thu, 6 Jul 2023 13:47:30 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1688647651; bh=zXq0RxESpSkRSGtoAWJi6JGEGgsz7+mOEqGxgmgm5F0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QWRwQrxYxEJii4Oy32ULOt49iEq2NvCXfSWiYq1uVb0ISH25jO1fQqLl8XZ7p0na0 8W5v74OYEWDgDegmPjTOu/5iqn+Kb9WXI1KNGWOTUf1DMqn7xJoDBLh2BRXyT9suYS 2kMgqKdIITNXxzNuBra3luErq+Gy9f+0aN1fvHy4DH6yV0unaiwLQUlFsOXVQukhRW TQqSUfpI88zRTyUVdjkv2KCos8Mh6/OlGTTT2YIEOBoq5sjlesR3FdnSs8ObjigLyr iS1svXJgKtFT8XOwDk9AuxqfPPdT1flRG+LiPrmhami61Vm74IZcxr8KA45UZ0WNQr hUBpKoXlctegw== Message-ID: Date: Thu, 6 Jul 2023 14:47:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] drm/mediatek: Fix potential memory leak if vmap() fail Content-Language: en-US To: Sui Jingfeng , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230626185801.684451-1-suijingfeng@loongson.cn> From: AngeloGioacchino Del Regno In-Reply-To: <20230626185801.684451-1-suijingfeng@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 26/06/23 20:58, Sui Jingfeng ha scritto: > Also return -ENOMEM if such a failure happens, the implement should take > responsibility for the error handling. > > Signed-off-by: Sui Jingfeng This commit needs a Fixes tag. Please add the relevant one and resend. Thanks, Angelo > --- > drivers/gpu/drm/mediatek/mtk_drm_gem.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > index a25b28d3ee90..9f364df52478 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c > @@ -247,7 +247,11 @@ int mtk_drm_gem_prime_vmap(struct drm_gem_object *obj, struct iosys_map *map) > > mtk_gem->kvaddr = vmap(mtk_gem->pages, npages, VM_MAP, > pgprot_writecombine(PAGE_KERNEL)); > - > + if (!mtk_gem->kvaddr) { > + kfree(sgt); > + kfree(mtk_gem->pages); > + return -ENOMEM; > + } > out: > kfree(sgt); > iosys_map_set_vaddr(map, mtk_gem->kvaddr);