From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E19EF33AD85 for ; Fri, 9 Jan 2026 11:14:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767957252; cv=none; b=ffVJNUAcEk/kLlyVok/3a6Njtlrut3YWPM6pEiruMZFdGdDmt9vZOwbuOfoJlHpj7FnVY1rYFmY6hTrXGQwAUgQEShVEJAKebpagciU2gHsVZkhC4BhX3yEtrVs8XIpbrs0fIclHhe8h/caf7cpo3tQy0IJJ9zzrPLC3RHrVN4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767957252; c=relaxed/simple; bh=hVtNJAfAuRuf73LQMtg59ts4s2e//TKY93Vcy8rZE+s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NCRBaTdbyBQqumjEqS9nOiTCg4QhHdhV4J4gaT8p1EizyILnsEro3tzwfB1NhWWtUQBTa9TOERf+iDn79HTtMDsh2+T5/fbaD7d0fqZnIfu31FAXmtB/xxIyQKRYT2S1Rlb+BVuNUQpdkpEMTG9bIc5z9dbJXavRqe4q3usu5+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ARHEqsJB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PI0UByHo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ARHEqsJB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PI0UByHo" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6096cPx31953482 for ; Fri, 9 Jan 2026 11:14:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pbGsyEjb9GLUxR/KE7Zt2yh4eaMOiAA5kJ01ApCC77w=; b=ARHEqsJBnJaq2osq Z87MjGzAlY18jovCmDfmtA3z3cSuu0Fr70TN1CKh6m9jWM9CFxn7mw4SDL9Hlg0a l3EvtqvtYViUB3lbOl/u6ZuLoSWg36RUH64qc2CB+HF31wGLPXZSFvluq/9g4Ggm ZSqcFrGopLuge3wVPZuRpDnjytjfv5sTUGyL41Y87noMqVEg0PKxcHvGcIUosZ3/ 6ypZRzdYCxV6kFo9BAHZUmsjo0Ad1O3nhNVnUgYjgW/UmdkOrkDA1CnkOClUREG2 8TJtnDPLGXUrs1g2aKe7gdAKbJxlFh9HAxA3sS27pdu7x0KlZdyTYTmi3IMP/VRr xSW5Rg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bjfdab3ew-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Jan 2026 11:14:09 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee07f794fcso11855001cf.2 for ; Fri, 09 Jan 2026 03:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767957249; x=1768562049; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pbGsyEjb9GLUxR/KE7Zt2yh4eaMOiAA5kJ01ApCC77w=; b=PI0UByHo6Nocb032JL8/w0cPhZ3M06cMrc8lFRAMdElQQ6SJYGREUNg4arRipJWqis YiisqVI2N5ziA6ooXscRZlXS2N/5mTWHFkFUgYe96b7ahwNKfJORgrBzMWOdvTQG+Z2v M7G8jCfaQeMgZaRdaaBqh8qd4PzPCSykp/gsETuGzeENzuI9VIKilMMnTIft9zIHXuGJ 4K83Eyxr/zsR/vXascN5zp4gibVOVNOampY7akoDu2fav4iUSLI+MXZufO+aztt6P+ry 8EZJi9g510T2LhkDe7lmvBk8MNsVX6SPBX2Cpd1WTFJjNW1pN0g+/13LNtEeZ61EdhLW T3vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767957249; x=1768562049; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pbGsyEjb9GLUxR/KE7Zt2yh4eaMOiAA5kJ01ApCC77w=; b=cKHoMqsIeCwMq2eWBY6k9LUn8uG8Vz/WxHqqO+aFKMZyLrdiohZ1337Rh+Y35WGEnp v+GiuMyklLWSv1EZjHsQjOUoxRQK/F7C3nYJ5l6Y7YiwhAHjPUdmociB0XWPCDnWaE2z 08yuYJ2zacsAN8qda5jCt9ilmpR3XDz4vwLpjSgoIga+irTR9Jdl9PBaHxXIwWC/7sgx Yt72VJCtd1OxFPe8X8lmNSY7sc4D2WR90Fg8VF/RkB5plqCSjvC8K2K8Ju0sNRJyJH1j /UkkyRlxlxFyVamcXwrOeoBqd8lF6KuLaz1QURnpVA4PkNo+du3yZJfiX7kWweE5K5af c7dw== X-Forwarded-Encrypted: i=1; AJvYcCV0ON3QQgDzCjHREslANqnmG+vptOJU00+u1c4/4YkIn2rolFyMt/JhOoKeCF348Q2QATknKO8bIspJgBU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy60QNLnzAmQ4Xa4VkQ2FXVv1Hndmue5ddqMwIf5Q9JN1DHViEN Hv88BCMwt2fi5i7Mdu94SeT1lsHToR1QYst2AncAGKnO7hhZ2lyLHaaJAj/Ewm4YwrEFErscY/B rXETONuuJb4UZHwsjcvMs5z4TkiEjjjZ3mbrQQAzG5uiY1p9DhxtztqM2Qbes+6wTIc+N6VIy2x E= X-Gm-Gg: AY/fxX6xRux6JihH7IDN0fcf8JsGzgBa8/4dD2DlrCpUIlXxBqGHCMPORXTl0rgswYT xLTkCBclp6U4QgNKJcF4MQa2IEDct3IX6Mj3POM+9DSnwD3Gt5wXeIKzB8SwaHdg8i5QZ3Ucf0B N10X29cnC1e/Kki2xyynJPX6V563sn237xOZ4M2ZefLwFT4ajhvU/P2BcHSBo6w7PIGAX03OAkI eq9O/EHbm/w3r73BrO9J05CpnNtRa8vQHDcy9R6zJjJ0M5vKgSLDJd0QX/+6b/sSDry2Wh9SA/l z9TUntEWzdWTlo/Nv7FdW0YzhsA3REEMVbRtBTXVydXpuxPZ0cAx5YM0E/X1JlUmm3CzgcOGQ57 gT57MqVbXAocLu1BFps3Zw433c++qK6xOXUU4Dh/L8nGa8+KO3S1STGKzxwOTnvqXnyI= X-Received: by 2002:a05:622a:51:b0:4ee:2339:a056 with SMTP id d75a77b69052e-4ffb487fcb1mr106443641cf.2.1767957249103; Fri, 09 Jan 2026 03:14:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdvN0j1mfTjJ9QiVsMbOTGrNWeD/W2yvwWHCpWlcYUo0gPkpqG1W9F+oG5sS4PJEpVUDXSWw== X-Received: by 2002:a05:622a:51:b0:4ee:2339:a056 with SMTP id d75a77b69052e-4ffb487fcb1mr106443331cf.2.1767957248609; Fri, 09 Jan 2026 03:14:08 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4cfd97sm1044008866b.36.2026.01.09.03.14.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jan 2026 03:14:07 -0800 (PST) Message-ID: Date: Fri, 9 Jan 2026 12:14:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] PCI: qcom: Keep PERST# GPIO state as-is during probe To: Krishna Chaitanya Chundru , Vinod Koul , Neil Armstrong , Philipp Zabel , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20260109-link_retain-v1-0-7e6782230f4b@oss.qualcomm.com> <20260109-link_retain-v1-3-7e6782230f4b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260109-link_retain-v1-3-7e6782230f4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Ue1ciaSN c=1 sm=1 tr=0 ts=6960e301 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=M-jGJTmE-ygQmRKCDXMA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: mezYJXFpOeYKNUZHbRS0sGE6O4Vb7Inx X-Proofpoint-GUID: mezYJXFpOeYKNUZHbRS0sGE6O4Vb7Inx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA5MDA4MiBTYWx0ZWRfX5OhCr+lO/U/R mCvdc5wdcdohuTWPMyPfr6aQfwPA6Q9dUpaMcfl+VuTMa0CaR6R4NOwABb5uKJ8xWBBfK25aJiu G3fD9qyAsCtMNwcFRyYhl0uxn6IY4GSRfZjLbpkEOXWF6vt2fcsjZLn5ixQ4fPZbJ8PTtUT70Dw c+kyGn6fyUMMPDPOVD82Mj3LS5W+vKMNMxw9gYQ8RDmlsHMd1CglKFsiX5rH07neusEeU9y8IEi xUmDy9c+71wm2PzIJ+TOwSb9ke80VKRMk8OOah23SR0B/m7qjl4G7lK/vbduXjqKn+t7Lp0AtvL /ghRvBmRABaRt/7VcrolqJCjp5gUD16iOCZH6uHbda1pQRFoNyp8FiKm0m3jT3zOQpDOX34Keb3 wMNbSnfFdyO0gwdH4R8MIbEbIJqAFfXMcdkVLop1lkzTAftDb9VZu8P3BkD3fFuxBVR2BzygQLB eD2InMnET1pd6vBLyQQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-09_03,2026-01-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601090082 On 1/9/26 8:21 AM, Krishna Chaitanya Chundru wrote: > The PERST# signal is used to reset PCIe devices. Currently, the driver > requests the GPIO with GPIOD_OUT_HIGH, which forces the line high > during probe. This can unintentionally assert reset early, breaking ^ de-assert, probably? Konrad > link retention or causing unexpected device behavior. > > Change the request to use GPIOD_ASIS so the driver preserves the > existing state configured by the bootloader or firmware. This allows > platforms that manage PERST# externally to maintain proper reset > sequencing. > > Signed-off-by: Krishna Chaitanya Chundru > --- > drivers/pci/controller/dwc/pcie-qcom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 7b92e7a1c0d9364a9cefe1450818f9cbfc7fd3ac..9342f9c75f1c3017b55614069a7aa821a6fb8da7 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1711,7 +1711,7 @@ static int qcom_pcie_parse_port(struct qcom_pcie *pcie, struct device_node *node > int ret; > > reset = devm_fwnode_gpiod_get(dev, of_fwnode_handle(node), > - "reset", GPIOD_OUT_HIGH, "PERST#"); > + "reset", GPIOD_ASIS, "PERST#"); > if (IS_ERR(reset)) > return PTR_ERR(reset); > > @@ -1772,7 +1772,7 @@ static int qcom_pcie_parse_legacy_binding(struct qcom_pcie *pcie) > if (IS_ERR(phy)) > return PTR_ERR(phy); > > - reset = devm_gpiod_get_optional(dev, "perst", GPIOD_OUT_HIGH); > + reset = devm_gpiod_get_optional(dev, "perst", GPIOD_ASIS); > if (IS_ERR(reset)) > return PTR_ERR(reset); > >