From: Sarangdhar Joshi <spjoshi@codeaurora.org>
To: Andy Gross <andy.gross@linaro.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes
Date: Thu, 20 Oct 2016 14:59:49 -0700 [thread overview]
Message-ID: <be72dfec-b502-1888-4495-9a476f91d6b6@codeaurora.org> (raw)
In-Reply-To: <20161020215137.GF3145@hector.attlocal.net>
On 10/20/2016 02:51 PM, Andy Gross wrote:
> On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
>> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
>>> On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
>>>
>>>> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>>>>
>>>> Add SMEM and TCSR DT nodes on MSM8996.
>>>>
>>>> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>>> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
>>>> ---
>>>> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
>>>> 1 file changed, 19 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> index 949b096..0a810f5 100644
>>>> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
>>>> @@ -169,12 +169,31 @@
>>>> method = "smc";
>>>> };
>>>>
>>>> + smem {
>>>> + compatible = "qcom,smem";
>>>> +
>>>> + memory-region = <&smem_mem>;
>>>> +
>>>> + hwlocks = <&tcsr_mutex 3>;
>>>> + };
>>>> +
>>>> soc: soc {
>>>> #address-cells = <1>;
>>>> #size-cells = <1>;
>>>> ranges = <0 0 0 0xffffffff>;
>>>> compatible = "simple-bus";
>>>>
>>>> + tcsr_mutex_regs: syscon@740000 {
>>>> + compatible = "syscon";
>>>> + reg = <0x740000 0x20000>;
>>>> + };
>>>> +
>>>> + tcsr_mutex: hwlock {
>>>> + compatible = "qcom,tcsr-mutex";
>>>> + syscon = <&tcsr_mutex_regs 0 0x1000>;
>>>> + #hwlock-cells = <1>;
>>>> + };
>>>
>>> Sorry, I got this in the wrong place, the hwlock node should sit outside
>>> of soc {} - looks like we got this wrong in msm8916 as well.
>>
>> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
>> root)?
>
> Yes. Any node that doesn't have reg properties should go under the root.
>
Got it. Will update the patch(es) and add cover letter. Thanks.
>
> Andy
>
Regards,
Sarang
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-20 21:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 18:56 [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Sarangdhar Joshi
2016-10-20 18:56 ` [PATCH 2/4] arm64: dts: msm8996: Add reserve-memory nodes Sarangdhar Joshi
2016-10-20 19:57 ` Bjorn Andersson
2016-10-20 21:17 ` Sarangdhar Joshi
2016-10-20 18:56 ` [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Sarangdhar Joshi
2016-10-20 19:56 ` Bjorn Andersson
2016-10-20 21:18 ` Sarangdhar Joshi
2016-10-20 21:51 ` Andy Gross
2016-10-20 21:59 ` Sarangdhar Joshi [this message]
2016-10-20 18:56 ` [PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes Sarangdhar Joshi
2016-10-20 20:03 ` Bjorn Andersson
2016-10-20 21:22 ` Sarangdhar Joshi
2016-10-20 19:57 ` [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Bjorn Andersson
2016-10-20 21:16 ` Sarangdhar Joshi
2016-10-20 21:53 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be72dfec-b502-1888-4495-9a476f91d6b6@codeaurora.org \
--to=spjoshi@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=tsoni@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome