From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Liviu Dudau <liviu.dudau@arm.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"James (Qian) Wang" <james.qian.wang@arm.com>,
Mihail Atanassov <mihail.atanassov@arm.com>,
Brian Starkey <brian.starkey@arm.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm: komeda: Make rt_pm_ops dependent on CONFIG_PM
Date: Fri, 6 Mar 2020 09:52:25 +0000 [thread overview]
Message-ID: <be7a17bf-86f8-a086-9783-3f4a211cf9e3@arm.com> (raw)
In-Reply-To: <20200305184255.GH364558@e110455-lin.cambridge.arm.com>
Hi Liviu,
On 3/5/20 6:42 PM, Liviu Dudau wrote:
> On Wed, Mar 04, 2020 at 02:54:12PM +0000, Vincenzo Frascino wrote:
>> komeda_rt_pm_suspend() and komeda_rt_pm_resume() are compiled only when
>> CONFIG_PM is enabled. Having it disabled triggers the following warning
>> at compile time:
>>
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12:
>> warning: ‘komeda_rt_pm_resume’ defined but not used [-Wunused-function]
>> static int komeda_rt_pm_resume(struct device *dev)
>> ^~~~~~~~~~~~~~~~~~~
>> linux/drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12:
>> warning: ‘komeda_rt_pm_suspend’ defined but not used [-Wunused-function]
>> static int komeda_rt_pm_suspend(struct device *dev)
>>
>> Make komeda_rt_pm_suspend() and komeda_rt_pm_resume() dependent on
>> CONFIG_PM to address the issue.
>>
>> Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
>> Cc: Liviu Dudau <liviu.dudau@arm.com>
>> Cc: Mihail Atanassov <mihail.atanassov@arm.com>
>> Cc: Brian Starkey <brian.starkey@arm.com>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Daniel Vetter <daniel@ffwll.ch>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>
> Acked-by: Liviu Dudau <liviu.dudau@arm.com>
>
> Thanks for the patch, I will push it into drm-misc-fixes tomorrow.
>
Thank you!
> Best regards,
> Liviu
>
>> ---
>> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> index ea5cd1e17304..dd3ae3d88687 100644
>> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
>> @@ -146,6 +146,7 @@ static const struct of_device_id komeda_of_match[] = {
>>
>> MODULE_DEVICE_TABLE(of, komeda_of_match);
>>
>> +#ifdef CONFIG_PM
>> static int komeda_rt_pm_suspend(struct device *dev)
>> {
>> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>> @@ -159,6 +160,7 @@ static int komeda_rt_pm_resume(struct device *dev)
>>
>> return komeda_dev_resume(mdrv->mdev);
>> }
>> +#endif /* CONFIG_PM */
>>
>> static int __maybe_unused komeda_pm_suspend(struct device *dev)
>> {
>> --
>> 2.25.1
>>
>
--
Regards,
Vincenzo
prev parent reply other threads:[~2020-03-06 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 14:54 Vincenzo Frascino
2020-03-05 18:42 ` Liviu Dudau
2020-03-06 4:14 ` james qian wang (Arm Technology China)
2020-03-06 9:51 ` Vincenzo Frascino
2020-03-06 9:52 ` Vincenzo Frascino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be7a17bf-86f8-a086-9783-3f4a211cf9e3@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=airlied@linux.ie \
--cc=brian.starkey@arm.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.qian.wang@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=mihail.atanassov@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®