From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D093921CE for ; Tue, 23 Jun 2026 06:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782195064; cv=none; b=rKOj2Y2aoehdBwCEW/eKX/EeW1D1EeRte2TQvGsh39N9UpzmR6BNXu5LcjGRl5bywiXQti6lTth8DhTOayoeOAo3Z3Hs0+VbGhoaL1dqaVcq5VnHFmOOokjAhOJXkPLVChT70QqomGKk5U7Ja1evQozT4Z/NwD1Efe22yXtNmD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782195064; c=relaxed/simple; bh=An93r6atHIL6rwjLrAyy+PRR6c90xs2VuccXAJ0FMvg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=iPaHle3YNrsS4PxGRUvWcjcjmCLozvWz4Fnv+4cyDOVvRoNI5Y3x3cBaVIs+f9XPJWJGrvfjtXZWUdDtjGw49tupd96gyIBA7tUKRLfHEiND8iFqeck/LdO+y8fOKeJrujQyLVdBj/Vp1p7AAXoIUjIdVmc1gNASM1rw3139mW0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bJPmCmu2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kPnCBH+J; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bJPmCmu2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kPnCBH+J" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N1Y7G62672818 for ; Tue, 23 Jun 2026 06:10:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= REGPcR4Pi7Z05BCfV22gSGTbkuS69uSGblJRXEsBRvs=; b=bJPmCmu2sH9jXztE GZaO/Xg+MKHfkJEn5+MD8qpWbrDuk9wDxhWoh0QeLB2ctiJlZnv9GJiJuQsj/XXb qTHwM0BKsjejOjfwmrEYztvRtPH5dSUBBwXp3IBNOFsBkThzQNNc47MHlvft1+H5 Xqy0Vg4OOQ42BqvB7zBK4Y8Rc7L0cIvxrJCj/MHrPhG+4pkuvgsGFIxiPTGDQNdZ g8Q5tpE8fN4LledBpsOY488zHtqntCZtP1DG0PWcrybhUB7nDHLWSt0UqEdRzpNn vsXByBxQUGEkSWccwQDjtmg1edSUssCXRsUVyrhGiIEoGOUt0Pil4/uZfWBiqA1E cPEWZQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eygkjgtda-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 06:10:57 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-37c648d3ab9so3320111a91.3 for ; Mon, 22 Jun 2026 23:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782195056; x=1782799856; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=REGPcR4Pi7Z05BCfV22gSGTbkuS69uSGblJRXEsBRvs=; b=kPnCBH+JBVXxgeOfp4XfH/SP40cD3ybH7d3kvh72unKAaNJ1OdUMVCsU0L/UlArrvH qmQBj67TdTvktjft6GbtaAvCpGKt2YqBuG4GDydEjcWxPHgfmTjDBfV8KsoBTjZ4bVtZ tA0emp4Kj/7GFqSjHPRx1CnQZY8tngkPF5LYvXysFDlsunrnBUGg3eZH8Z3eHbfsPPfj 7yJiGMFlxa6n78CvEEHUaMegeWWMzEk5c73ltjNisEUgRS3AXVwBoPm4kwEU7QWfwwdh L9jP6Zlblx1nzgHv4uyvGubgmul6sLJGKjCl+PbvY53h6QEUs3ZVfM5P9qY8w26OQa42 TKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782195056; x=1782799856; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:cc:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=REGPcR4Pi7Z05BCfV22gSGTbkuS69uSGblJRXEsBRvs=; b=XHChN4SCf/qRmXqtjFnuyR/DxP0P/BacHbc+0RM80ndzGc9+nb1/M8cHDeT7qGNEaw s7F5DL4tEAGRbduCJs95HM9efvlsG9rdKi0gIUMdSYEadTi9QLunC2vLXBPrSYPQiWPP H+5BstF4W+OKkfsh1YskFjHETCOmqLQlbg2oARMxxba8728rQbcqEFwaHkCPaiRDZsjA 0WbUbCocr1Ve2Ly04w3zbvbXEr4HXST3iom2mTfzqX5WBPVY5EjVRdQXFU44LDdpK+us fOp6kViOwFW7PDT/8E6rW/Zrxvfs2lAG8FI5YQr9vnyG+x1I/aK3O6OuMA1UxZB4giwg RR9g== X-Forwarded-Encrypted: i=1; AHgh+RpjFMza4bD4S/p5oWfFRBmwy15eGRGUCfTKJRaNvDYN6DvLfd28Za/qgfCj69nIW3gQLCV8UUSzIaXFHH4=@vger.kernel.org X-Gm-Message-State: AOJu0YwXNcx3DN52MncEOoGwvaHbZSTBOXOZYk0d8rYKKWY7bww9f1YS Z9y9aR+UiJC2moYLk6oom611JAz/FzFbN6kKbjsPGPxmLfi7aUfB/MVH6wc0AzeVbDF2oG0oJfD hmFeu1ICIbjYAVn8IvCIPKEOJBFOYuRUZiNQKXspIrNCbmKDdBPh/prBTjL3Otqtu+IQ= X-Gm-Gg: AfdE7clLwFSym6wudLUi8z6WDTjMrIojCcLXOvyTgNpFdR/nDs75LE6SXh3n7fEJi+b 81niPaRZ4GukOA1YLHR2GPZq6ELMXKjmShnAU9DmesJqsBqK9zgOkBxd+G4ckRnylM3smMcQZky YHhymJQvKBb+Lt63YDrPWMLWgVe4OSH6Upf53QQLYGOHSKgiM1yAXDPsGNlha9dm48GcXipsOf1 +ACG0Z9T31PTk6Jg/9Xu8Y+3frB6C323rihdbNuwybg3Lojv5iJ4XrAVdJJ19ENgXRlc1UQsqAM ii44zgob01fDDByUts5YYC/SnXQto2HQcO01HI/7KBvoLGcN0hwnfgtlndLEkdKsH4ExyTP7mpV AzEViSEypkEsqEDpIZ8llGgU0LYuTyPeA+9tKGO8NQMjl9aN26IXkP4Iz5sFCST/qM+h/GrmqZu S+02v/5Q== X-Received: by 2002:a17:90b:380f:b0:368:5367:d679 with SMTP id 98e67ed59e1d1-37d160489famr16689075a91.9.1782195056634; Mon, 22 Jun 2026 23:10:56 -0700 (PDT) X-Received: by 2002:a17:90b:380f:b0:368:5367:d679 with SMTP id 98e67ed59e1d1-37d160489famr16689047a91.9.1782195056152; Mon, 22 Jun 2026 23:10:56 -0700 (PDT) Received: from [10.249.22.156] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d1536b541sm11655278a91.1.2026.06.22.23.10.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jun 2026 23:10:55 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 14:10:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: wangao.wang@oss.qualcomm.com, Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , quic_qiweil@quicinc.com, Renjiang Han , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] media: qcom: iris: Add request key frame support for encoder To: Dmitry Baryshkov References: <20260604-dynamic_encode-v2-0-6e97df032482@oss.qualcomm.com> <20260604-dynamic_encode-v2-2-6e97df032482@oss.qualcomm.com> Content-Language: en-US From: Wangao Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA0NyBTYWx0ZWRfX5F/b5FxR3BJ8 PkNLsmDs5K4dDisEROahQovqvVXJI1LhxABan1tEaLeSeFSBG1zrSVVMsHZ90HYHBHkfXnpvoJU EA/O/erkyYqOxVDNAwBK+Z/qGGuj0qENbS+jmbPUOrLoZvYtLJw6xDM7saDYamvPmMr8SaYu6sg EFtSHKNjvHx0nx45ShRpGDfQkG6HzgJBWgS4bnLOcVrX2irdd1jZvDN0Eh16946fZg2pK1Ued/C tWJPIw/1aRy3dB/kf00uqGoST/5n6d3LPtX85VX8mo5RzfmIFo8v1lTMCFB9ecZjITwJRxNMXvS F6lHrR5EIOqcqbwKJMlsj0pBREu/xUBJHM/Bk0t1CZLfSSOhcluQXJDRgQ4wZSqX8GqUsG1zxiT m/38V0sJohP7gCd42sw03dU9Z8QoChxZ4VXb/NUjqYQCh9PZG7e4E7VPEj5ABU3Jyle/uotaMfM vn6zh/yDMLqiuTSJ61g== X-Proofpoint-GUID: cMcqDnAxksPfZlkYP1bl-ngwHE9OYP_A X-Authority-Analysis: v=2.4 cv=SoKgLvO0 c=1 sm=1 tr=0 ts=6a3a2371 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=wAVQDYQ2tgOr7hSGGKsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA0NyBTYWx0ZWRfXzOTbipF0Cj7d j/R1ymTMoWzQL6RrP6L6FhGsxCX5gfy2+hN0I20RJCicnQrbSHqBFYALcBdaEGWY/2rLMqCKlfD 6nuLEuYWzoIRU0CShgK7MH9y0ke4PkA= X-Proofpoint-ORIG-GUID: cMcqDnAxksPfZlkYP1bl-ngwHE9OYP_A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_01,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230047 On 2026/6/8 4:37, Dmitry Baryshkov wrote: >> + { >> + .cap_id = REQUEST_SYNC_FRAME, >> + .min = 0, >> + .max = 0, >> + .step_or_mask = 0, >> + .value = 0, > > How does it work if min = max = 0? > >> + .hfi_id = HFI_PROPERTY_CONFIG_VENC_REQUEST_SYNC_FRAME, >> + .flags = CAP_FLAG_INPUT_PORT | CAP_FLAG_DYNAMIC_ALLOWED, >> + .set = iris_set_req_sync_frame, >> + }, >> }; >> > When using this cap, the value here is not actually read, so it runs fine. But I think you're right — max should be set to 1. Will be fixed in the next version. -- Best Regards, Wangao