mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Claudiu.Beznea@microchip.com>
To: <andriy.shevchenko@linux.intel.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <Ludovic.Desroches@microchip.com>, <linus.walleij@linaro.org>,
	<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device
Date: Fri, 17 Feb 2023 11:54:02 +0000	[thread overview]
Message-ID: <be808124-f350-125c-9c74-5a3f87db32af@microchip.com> (raw)
In-Reply-To: <20230215134242.37618-6-andriy.shevchenko@linux.intel.com>

On 15.02.2023 15:42, Andy Shevchenko wrote:
> @@ -1758,7 +1750,7 @@ static int at91_gpio_of_irq_setup(struct platform_device *pdev,
>         if (!gpiochip_prev) {
>                 girq->parent_handler = gpio_irq_handler;
>                 girq->num_parents = 1;
> -               girq->parents = devm_kcalloc(&pdev->dev, 1,
> +               girq->parents = devm_kcalloc(dev, girq->num_parents,

There is still the change of the 2nd argument of devm_kcalloc() from 1 ->
girq->num_parents (no functional change, though) which doesn't match the
purpose of the patch and is not specified anywhere. Other than this:

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

>                                              sizeof(*girq->parents),
>                                              GFP_KERNEL);


  reply	other threads:[~2023-02-17 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15 13:42 [PATCH v3 0/5] pinctrl: at91: Cleanups Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 1/5] pinctrl: at91: use devm_kasprintf() to avoid potential leaks (part 2) Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 2/5] pinctrl: at91: Don't mix non-devm calls with devm ones Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 3/5] pinctrl: at91: Use of_device_get_match_data() Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 4/5] pinctrl: at91: Use dev_err_probe() instead of custom messaging Andy Shevchenko
2023-02-15 13:42 ` [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device Andy Shevchenko
2023-02-17 11:54   ` Claudiu.Beznea [this message]
2023-02-17 11:59     ` Andy Shevchenko
2023-02-27 21:44       ` Linus Walleij
2023-02-27 22:20         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be808124-f350-125c-9c74-5a3f87db32af@microchip.com \
    --to=claudiu.beznea@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®