From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E419FC282DD for ; Sat, 20 Apr 2019 03:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B95D821736 for ; Sat, 20 Apr 2019 03:37:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727846AbfDTDh0 (ORCPT ); Fri, 19 Apr 2019 23:37:26 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:33588 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725911AbfDTDh0 (ORCPT ); Fri, 19 Apr 2019 23:37:26 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 27878C09A7799721599E; Sat, 20 Apr 2019 11:37:24 +0800 (CST) Received: from [127.0.0.1] (10.177.31.96) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Sat, 20 Apr 2019 11:37:19 +0800 Subject: Re: [PATCH -next] sched/fair: Make some functions static To: , References: <20190322143030.17348-1-yuehaibing@huawei.com> CC: From: YueHaibing Message-ID: Date: Sat, 20 Apr 2019 11:37:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190322143030.17348-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pls ignore this. On 2019/3/22 22:30, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warnings: > > kernel/sched/fair.c:2596:6: warning: symbol 'task_tick_numa' was not declared. Should it be static? > kernel/sched/fair.c:3570:6: warning: symbol 'sync_entity_load_avg' was not declared. Should it be static? > kernel/sched/fair.c:3583:6: warning: symbol 'remove_entity_load_avg' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > kernel/sched/fair.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index fdab7eb..18fb781 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -2593,7 +2593,7 @@ void task_numa_work(struct callback_head *work) > /* > * Drive the periodic memory faults.. > */ > -void task_tick_numa(struct rq *rq, struct task_struct *curr) > +static void task_tick_numa(struct rq *rq, struct task_struct *curr) > { > struct callback_head *work = &curr->numa_work; > u64 period, now; > @@ -3567,7 +3567,7 @@ static inline u64 cfs_rq_last_update_time(struct cfs_rq *cfs_rq) > * Synchronize entity load avg of dequeued entity without locking > * the previous rq. > */ > -void sync_entity_load_avg(struct sched_entity *se) > +static void sync_entity_load_avg(struct sched_entity *se) > { > struct cfs_rq *cfs_rq = cfs_rq_of(se); > u64 last_update_time; > @@ -3580,7 +3580,7 @@ void sync_entity_load_avg(struct sched_entity *se) > * Task first catches up with cfs_rq, and then subtract > * itself from the cfs_rq (task must be off the queue now). > */ > -void remove_entity_load_avg(struct sched_entity *se) > +static void remove_entity_load_avg(struct sched_entity *se) > { > struct cfs_rq *cfs_rq = cfs_rq_of(se); > unsigned long flags; >